[commit: ghc] master: Comment out a leftover pprTrace (a5b7ee5)

[Simon Peyton-Jones]

Actually that pprTrace is deliberate!  Something is wrong if we have more than 10 iterations in the fixpoint loop and I'd like to know.

Actually this *is* happening right now (I should make a ticket). I know why but have not worked out a good way to fix it.  And POPL is pressing. Anyway leave it for now and I'll make a ticket

S

| -----Original Message-----
| From: ghc-commits-bounces at haskell.org [mailto:ghc-commits-
| bounces at haskell.org] On Behalf Of Gabor Greif
| Sent: 03 July 2013 21:58
| To: ghc-commits at haskell.org
| Subject: [commit: ghc] master: Comment out a leftover pprTrace (a5b7ee5)
| 
| Repository : http://darcs.haskell.org/ghc.git/
| 
| On branch  : master
| 
| https://github.com/ghc/ghc/commit/a5b7ee5fc26ac322e7dc79de96e478cde81964
| 0c
| 
| >---------------------------------------------------------------
| 
| commit a5b7ee5fc26ac322e7dc79de96e478cde819640c
| Author: Gabor Greif <ggreif at gmail.com>
| Date:   Wed Jul 3 22:56:23 2013 +0200
| 
|     Comment out a leftover pprTrace
| 
| >---------------------------------------------------------------
| 
|  compiler/stranal/DmdAnal.lhs | 14 +++++++-------
|  1 file changed, 7 insertions(+), 7 deletions(-)
| 
| diff --git a/compiler/stranal/DmdAnal.lhs b/compiler/stranal/DmdAnal.lhs
| index 572a39d..0aff8ff 100644
| --- a/compiler/stranal/DmdAnal.lhs
| +++ b/compiler/stranal/DmdAnal.lhs
| @@ -26,7 +26,7 @@ import Data.List
|  import DataCon
|  import Id
|  import CoreUtils	( exprIsHNF, exprType, exprIsTrivial )
| -import PprCore
| +-- import PprCore
|  import TyCon
|  import Type		( eqType )
|  -- import Pair
| @@ -536,12 +536,12 @@ dmdFix top_lvl env orig_pairs
|  		-- iteration of sigs.
| 
|        | n >= 10
| -      = pprTrace "dmdFix loop" (ppr n <+> (vcat
| -			[ text "Sigs:" <+> ppr [ (id,lookupVarEnv (sigEnv env)
| id,
| -                                                     lookupVarEnv
| (sigEnv env') id)
| -                                               | (id,_) <- pairs],
| -			  text "env:" <+> ppr env,
| -			  text "binds:" <+> pprCoreBinding (Rec pairs)]))
| +      = -- pprTrace "dmdFix loop" (ppr n <+> (vcat
| +        --                 [ text "Sigs:" <+> ppr [ (id,lookupVarEnv
| (sigEnv env) id,
| +        --                                              lookupVarEnv
| (sigEnv env') id)
| +        --                                          | (id,_) <- pairs],
| +        --                   text "env:" <+> ppr env,
| +        --                   text "binds:" <+> pprCoreBinding (Rec
| pairs)]))
|  	(env, lazy_fv, orig_pairs)	-- Safe output
|  		-- The lazy_fv part is really important!  orig_pairs has no
| strictness
|  		-- info, including nothing about free vars.  But if we have
| 
| 
| 
| _______________________________________________
| ghc-commits mailing list
| ghc-commits at haskell.org
| http://www.haskell.org/mailman/listinfo/ghc-commits