HEAD build fails on OS X

[Simon Marlow]

I heard from someone else that the patch fixed it, and I validated it 
here, so I went ahead and pushed it.  Sorry about the breakage folks.

Cheers,
	Simon

On 17/01/13 21:04, Johan Tibell wrote:
> I will do it.
>
> On Thu, Jan 17, 2013 at 12:12 PM, Simon Marlow <marlowsd at gmail.com> wrote:
>> Here's a patch, if someone could validate on OS X for me that would be
>> great.
>>
>> Cheers,
>>          Simon
>>
>>
>> On 17/01/13 19:18, Johan Tibell wrote:
>>>
>>> Reverting 520dc1d245fa5d965bdc7e97231e868de7c1dd9e fixes the problem
>>> on my machine. Simon M, what do you want to do?
>>>
>>> On Thu, Jan 17, 2013 at 11:08 AM, Johan Tibell <johan.tibell at gmail.com>
>>> wrote:
>>>>
>>>> I was wrong, it just take quite a bit longer to fail. Here's the trace
>>>> for a single-threaded build:
>>>>
>>>> cho rts/dist/ffi/*.o rts/dist/build/Adjustor.debug_o
>>>> rts/dist/build/Arena.debug_o rts/dist/build/Capability.debug_o
>>>> rts/dist/build/ClosureFlags.debug_o
>>>> rts/dist/build/Disassembler.debug_o rts/dist/build/FileLock.debug_o
>>>> rts/dist/build/FrontPanel.debug_o rts/dist/build/Globals.debug_o
>>>> rts/dist/build/Hash.debug_o rts/dist/build/Hpc.debug_o
>>>> rts/dist/build/HsFFI.debug_o rts/dist/build/Inlines.debug_o
>>>> rts/dist/build/Interpreter.debug_o rts/dist/build/LdvProfile.debug_o
>>>> rts/dist/build/Linker.debug_o rts/dist/build/Messages.debug_o
>>>> rts/dist/build/OldARMAtomic.debug_o rts/dist/build/Papi.debug_o
>>>> rts/dist/build/Printer.debug_o rts/dist/build/ProfHeap.debug_o
>>>> rts/dist/build/Profiling.debug_o rts/dist/build/Proftimer.debug_o
>>>> rts/dist/build/RaiseAsync.debug_o
>>>> rts/dist/build/RetainerProfile.debug_o
>>>> rts/dist/build/RetainerSet.debug_o rts/dist/build/RtsAPI.debug_o
>>>> rts/dist/build/RtsDllMain.debug_o rts/dist/build/RtsFlags.debug_o
>>>> rts/dist/build/RtsMain.debug_o rts/dist/build/RtsMessages.debug_o
>>>> rts/dist/build/RtsStartup.debug_o rts/dist/build/RtsUtils.debug_o
>>>> rts/dist/build/STM.debug_o rts/dist/build/Schedule.debug_o
>>>> rts/dist/build/Sparks.debug_o rts/dist/build/Stable.debug_o
>>>> rts/dist/build/Stats.debug_o rts/dist/build/StgCRun.debug_o
>>>> rts/dist/build/StgPrimFloat.debug_o rts/dist/build/Task.debug_o
>>>> rts/dist/build/ThreadLabels.debug_o
>>>> rts/dist/build/ThreadPaused.debug_o rts/dist/build/Threads.debug_o
>>>> rts/dist/build/Ticky.debug_o rts/dist/build/Timer.debug_o
>>>> rts/dist/build/Trace.debug_o rts/dist/build/WSDeque.debug_o
>>>> rts/dist/build/Weak.debug_o rts/dist/build/hooks/FlagDefaults.debug_o
>>>> rts/dist/build/hooks/MallocFail.debug_o
>>>> rts/dist/build/hooks/OnExit.debug_o
>>>> rts/dist/build/hooks/OutOfHeap.debug_o
>>>> rts/dist/build/hooks/StackOverflow.debug_o
>>>> rts/dist/build/parallel/0Hash.debug_o
>>>> rts/dist/build/parallel/0Unpack.debug_o
>>>> rts/dist/build/parallel/Dist.debug_o
>>>> rts/dist/build/parallel/Global.debug_o
>>>> rts/dist/build/parallel/GranSim.debug_o
>>>> rts/dist/build/parallel/HLComms.debug_o
>>>> rts/dist/build/parallel/LLComms.debug_o
>>>> rts/dist/build/parallel/Pack.debug_o
>>>> rts/dist/build/parallel/ParInit.debug_o
>>>> rts/dist/build/parallel/ParTicky.debug_o
>>>> rts/dist/build/parallel/Parallel.debug_o
>>>> rts/dist/build/parallel/ParallelDebug.debug_o
>>>> rts/dist/build/parallel/RBH.debug_o
>>>> rts/dist/build/sm/BlockAlloc.debug_o rts/dist/build/sm/Compact.debug_o
>>>> rts/dist/build/sm/Evac.debug_o rts/dist/build/sm/GC.debug_o
>>>> rts/dist/build/sm/GCAux.debug_o rts/dist/build/sm/GCUtils.debug_o
>>>> rts/dist/build/sm/MBlock.debug_o rts/dist/build/sm/MarkWeak.debug_o
>>>> rts/dist/build/sm/Sanity.debug_o rts/dist/build/sm/Scav.debug_o
>>>> rts/dist/build/sm/Storage.debug_o rts/dist/build/sm/Sweep.debug_o
>>>> rts/dist/build/eventlog/EventLog.debug_o
>>>> rts/dist/build/posix/GetEnv.debug_o
>>>> rts/dist/build/posix/GetTime.debug_o
>>>> rts/dist/build/posix/Itimer.debug_o rts/dist/build/posix/OSMem.debug_o
>>>> rts/dist/build/posix/OSThreads.debug_o
>>>> rts/dist/build/posix/Select.debug_o
>>>> rts/dist/build/posix/Signals.debug_o rts/dist/build/posix/TTY.debug_o
>>>>    rts/dist/build/Apply.debug_o rts/dist/build/Exception.debug_o
>>>> rts/dist/build/HeapStackCheck.debug_o rts/dist/build/PrimOps.debug_o
>>>> rts/dist/build/StgMiscClosures.debug_o
>>>> rts/dist/build/StgStartup.debug_o rts/dist/build/StgStdThunks.debug_o
>>>> rts/dist/build/Updates.debug_o rts/dist/build/AutoApply.debug_o  |
>>>> "xargs"  "/usr/bin/ar" clqs  rts/dist/build/libHSrts_debug.a
>>>> /usr/bin/ranlib: file: rts/dist/build/libHSrts_debug.a(darwin.o) has no
>>>> symbols
>>>> /usr/bin/ranlib: file: rts/dist/build/libHSrts_debug.a(ffi.o) has no
>>>> symbols
>>>> /usr/bin/ranlib: file:
>>>> rts/dist/build/libHSrts_debug.a(FrontPanel.debug_o) has no symbols
>>>> /usr/bin/ranlib: file:
>>>> rts/dist/build/libHSrts_debug.a(LdvProfile.debug_o) has no symbols
>>>> /usr/bin/ranlib: file:
>>>> rts/dist/build/libHSrts_debug.a(OldARMAtomic.debug_o) has no symbols
>>>> /usr/bin/ranlib: file: rts/dist/build/libHSrts_debug.a(Papi.debug_o)
>>>> has no symbols
>>>> /usr/bin/ranlib: file:
>>>> rts/dist/build/libHSrts_debug.a(Profiling.debug_o) has no symbols
>>>> /usr/bin/ranlib: file:
>>>> rts/dist/build/libHSrts_debug.a(RetainerProfile.debug_o) has no
>>>> symbols
>>>> /usr/bin/ranlib: file:
>>>> rts/dist/build/libHSrts_debug.a(RetainerSet.debug_o) has no symbols
>>>> /usr/bin/ranlib: file:
>>>> rts/dist/build/libHSrts_debug.a(RtsDllMain.debug_o) has no symbols
>>>> /usr/bin/ranlib: file: rts/dist/build/libHSrts_debug.a(0Hash.debug_o)
>>>> has no symbols
>>>> /usr/bin/ranlib: file:
>>>> rts/dist/build/libHSrts_debug.a(0Unpack.debug_o) has no symbols
>>>> /usr/bin/ranlib: file: rts/dist/build/libHSrts_debug.a(Dist.debug_o)
>>>> has no symbols
>>>> /usr/bin/ranlib: file: rts/dist/build/libHSrts_debug.a(Global.debug_o)
>>>> has no symbols
>>>> /usr/bin/ranlib: file:
>>>> rts/dist/build/libHSrts_debug.a(GranSim.debug_o) has no symbols
>>>> /usr/bin/ranlib: file:
>>>> rts/dist/build/libHSrts_debug.a(HLComms.debug_o) has no symbols
>>>> /usr/bin/ranlib: file:
>>>> rts/dist/build/libHSrts_debug.a(LLComms.debug_o) has no symbols
>>>> /usr/bin/ranlib: file: rts/dist/build/libHSrts_debug.a(Pack.debug_o)
>>>> has no symbols
>>>> /usr/bin/ranlib: file:
>>>> rts/dist/build/libHSrts_debug.a(ParInit.debug_o) has no symbols
>>>> /usr/bin/ranlib: file:
>>>> rts/dist/build/libHSrts_debug.a(ParTicky.debug_o) has no symbols
>>>> /usr/bin/ranlib: file:
>>>> rts/dist/build/libHSrts_debug.a(Parallel.debug_o) has no symbols
>>>> /usr/bin/ranlib: file:
>>>> rts/dist/build/libHSrts_debug.a(ParallelDebug.debug_o) has no symbols
>>>> /usr/bin/ranlib: file: rts/dist/build/libHSrts_debug.a(RBH.debug_o)
>>>> has no symbols
>>>>     rts_dist_HC rts/dist/build/sm/GC.thr_o
>>>>
>>>> In file included from rts/sm/GC.c:25:0:
>>>> rts/sm/GCUtils.h: In function ‘recordMutableGen_GC’:
>>>>
>>>> rts/sm/GCUtils.h:55:0:
>>>>        error: ‘gctKey’ undeclared (first use in this function)
>>>>
>>>> rts/sm/GCUtils.h:55:0:
>>>>        error: (Each undeclared identifier is reported only once
>>>>
>>>> rts/sm/GCUtils.h:55:0:  error: for each function it appears in.)
>>>> make[1]: *** [rts/dist/build/sm/GC.thr_o] Error 1
>>>> make: *** [all] Error 2
>>>>
>>>> On Thu, Jan 17, 2013 at 11:05 AM, Johan Tibell <johan.tibell at gmail.com>
>>>> wrote:
>>>>>
>>>>> Turning of parallel builds (i.e. not passing -j to make) seems to
>>>>> work, so this might be a race in the build system. Perhaps there's an
>>>>> untracked dependency?
>>>>>
>>>>> On Thu, Jan 17, 2013 at 10:55 AM, Johan Tibell <johan.tibell at gmail.com>
>>>>> wrote:
>>>>>>
>>>>>> Hi,
>>>>>>
>>>>>> I'm currently getting the following failure on OS X:
>>>>>>
>>>>>>     rts_dist_HC rts/dist/build/sm/GCAux.thr_o
>>>>>>
>>>>>> In file included from rts/sm/GC.c:25:0:
>>>>>> rts/sm/GCUtils.h: In function ‘recordMutableGen_GC’:
>>>>>>
>>>>>> rts/sm/GCUtils.h:55:0:
>>>>>>        error: ‘gctKey’ undeclared (first use in this function)
>>>>>>
>>>>>> rts/sm/GCUtils.h:55:0:
>>>>>>        error: (Each undeclared identifier is reported only once
>>>>>>
>>>>>> rts/sm/GCUtils.h:55:0:  error: for each function it appears in.)
>>>>>> make[1]: *** [rts/dist/build/sm/GC.thr_o] Error 1
>>>>>> make[1]: *** Waiting for unfinished jobs....
>>>>>> make: *** [all] Error 2
>>>>>>
>>>>>> I wonder if 520dc1d245fa5d965bdc7e97231e868de7c1dd9e, which moved
>>>>>> around some includes in that directory, is to blame.
>>>>>>
>>>>>> -- Johan
>>
>>