FW: [GHC] #8186: Parallel comprehensions not allowed in Template Haskell quotes

Simon Peyton-Jones simonpj at microsoft.com
Wed Aug 28 10:14:36 CEST 2013


With Gitolite, the Trac tickets now get messages like this:

Comment (by Richard Eisenberg <eir@…>):

 In [changeset:382f601406b11b7d4fdc72d773c6060372f1fbb3/ghc]:
 {{{
 #!CommitTicketReference repository="ghc"
 revision="382f601406b11b7d4fdc72d773c6060372f1fbb3"
 Fix Trac #8186.

 Parallel list comprehensions are now handled in DsMeta.
 }}}


But they used to get messages like this (like git log --stat)

commit ef017944600cf4e153aad686a6a78bfb48dea67a
Author: Simon Peyton Jones <simonpj at microsoft.com>
Date:   Tue Aug 27 15:48:02 2013 +0100

    Comments only, relating to #8166 fix

 compiler/codeGen/StgCmm.hs      |    7 ++-----
 compiler/codeGen/StgCmmExpr.hs  |    7 ++++---
 compiler/codeGen/StgCmmMonad.hs |   10 +++++++++-
 3 files changed, 15 insertions(+), 9 deletions(-)


I liked the old version: 
    the author is more explicit
    the modified files are listed
    if the patch is small you see it all

Might it be possible to revert?

Simon


More information about the ghc-devs mailing list