Disallow pushing of new trailing whitespace

Simon Marlow marlowsd at gmail.com
Thu Aug 22 09:33:41 CEST 2013


On 20/08/13 12:21, Geoffrey Mainland wrote:
> Would be nice to have. How about a third hook that disallows commits
> that include whitespace-only changes unless *all* changes are
> whitespace-only? ;)

The problem with these kind of commit-time checks is that you only find 
out the problem *after* you've validated your nicely polished commits. 
If we're going to add more checks on commits they should be done by 
validate (yes I know that's not at all trivial, but it's not impossible 
either).

Cheers,
	Simon



> Geoff
>
> On 08/20/2013 10:59 AM, Jan Stolarek wrote:
>> Right now we have a git hook that prevents pushing a file containing tabs, unless that file had them already (in other words: no new files with tabs in our repos). I propose to add similar hook for trailing whitespaces. Herbert says he can implement that. What do others think? Would you find that useful or problematic?
>>
>> Janek
>
> _______________________________________________
> ghc-devs mailing list
> ghc-devs at haskell.org
> http://www.haskell.org/mailman/listinfo/ghc-devs
>





More information about the ghc-devs mailing list