HEADS UP! was: Re: New Git-commit-message -> Trac-ticket interaction

Herbert Valerio Riedel hvr at gnu.org
Wed Aug 14 09:50:19 CEST 2013

On 2013-08-13 at 14:20:59 +0200, Simon Marlow wrote:


> I have updated
> http://ghc.haskell.org/trac/ghc/wiki/WorkingConventions/Git to mention
> this, but it could probably do with more complete docs since the
> standard Trac docs don't take into account our local settings.

> Herbert, could you expand that please?

I've just expanded that section; please review

I've added a reference to [1] (even though almost all commit
messages I've seen already follow that convention anyway).

I refrained from mentioning some of the additional syntax variants
recognized by the commit message parser (such as "closes issue 1234" as
alternative for "closes #1234") as it makes grepping through commit
messages more difficult.

While at it, I added "resolve{,s,ed}" to the list of verbs to mimic
GitHub's supported keywords[2]. Btw, if this is desired, we could make a
commit add a ticket comment as soon as the respective ticket-number
occurs (i.e. w/o any preceding verb). This would effectively make Trac
recognize a subset of GitHub's syntax. I could implement this together
with the mergefix-verb feature you proposed.

 [1]: http://tbaggery.com/2008/04/19/a-note-about-git-commit-messages.html
 [2]: https://help.github.com/articles/closing-issues-via-commit-messages


More information about the ghc-devs mailing list