[GHC DevOps Group] CircleCI job accounting question

[Ben Gamari]

Simon Marlow <marlowsd at gmail.com> writes:

> On 22 November 2017 at 19:15, Ben Gamari <ben at well-typed.com> wrote:
>
>> Please correct me if I'm forgetting something but I do not believe we
>> have even decided that we would start accepting PRs for larger patches.
>> I had said during ICFP that I was open to the idea, but experience
>> with GitHub's reviewing tools has since led me to view the proposal with
>> a bit more skepticism. Since this was prior to the creation of this
>> mailing list I summarised these concerns in a private email to Manuel; I
>> will forward this message to the list in a moment.
>>
>
> Right, we certainly haven't decided to move code reviewing to GitHub (and I
> also have deep concerns about that). I was thinking about the case where
> someone submits a PR via GitHub and we convert it into a Phabricator diff,
> squashing in the process, or if the PR doesn't require reviewing then we
> squash before pushing.
>
Right, I usually squash such PRs when I merge anyways. That being said,
I also generally merge them along with other work.

Cheers,

- Ben
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 487 bytes
Desc: not available
URL: <http://mail.haskell.org/pipermail/ghc-devops-group/attachments/20171123/d8e75bf2/attachment.sig>