[GHC DevOps Group] CircleCI job accounting question

Manuel M T Chakravarty manuel.chakravarty at tweag.io
Fri Dec 15 04:17:19 UTC 2017


> Ben Gamari <ben at well-typed.com>:
> 
> Manuel M T Chakravarty <manuel.chakravarty at tweag.io> writes:
>> The hold up seems to be that Phabricator creates an overhead, which
>> has prompted the use of the loophole (= direct push to master).
>> 
>> How about the following solution? Everything that is directly pushed
>> to master currently, is being pushed to GitHub and goes through a PR.
>> 
>> After all, the main criticism of GitHub PRs seems to be about code
>> reviews being nicer on Phabricator and we don’t want code review on
>> the direct pushes to master anyway. So, why not use GitHub for this?
>> 
> Historically GHC avoided this since GHC avoided merge commits as they
> complicate bisection. However, now since GitHub supports rebase-merging
> this is certainly a compelling option. It's certainly much simpler than
> the approach I outlined above yet provides the same benefits.
> 
> If no one objects I think this sounds like a great path forward.

Great!

Manuel


More information about the Ghc-devops-group mailing list