[GHC DevOps Group] CircleCI job accounting question
Simon Marlow
marlowsd at gmail.com
Thu Dec 14 08:34:50 UTC 2017
On 14 December 2017 at 02:20, Manuel M T Chakravarty <
manuel.chakravarty at tweag.io> wrote:
>
>
> The hold up seems to be that Phabricator creates an overhead, which has
> prompted the use of the loophole (= direct push to master).
>
> How about the following solution? Everything that is directly pushed to
> master currently, is being pushed to GitHub and goes through a PR.
>
> After all, the main criticism of GitHub PRs seems to be about code reviews
> being nicer on Phabricator and we don’t want code review on the direct
> pushes to master anyway. So, why not use GitHub for this?
>
Provided there's a way that we can bypass this for Phabricator and do 'arc
land', then it's fine with me. Otherwise we would have this convoluted
workflow:
* arc diff
* code review + CI validation on Phabricator
* push to your github fork
* create a PR on GitHub
* wait for CI again
* press the merge button
compared with:
* arc diff
* code review + CI validation on Phabricator
* arc land, or wait for Ben to merge
Cheers
Simon
Cheers,
> Manuel
>
> >> If the outstanding issue is that you combine multiple contributions
> >> from contributors and manually valid them to ensure they are not just
> >> individually sound, but also in combination, we might want to consider
> >>
> >> https://bors.tech <https://bors.tech/>
> >>
> >> which is exactly for that kind of thing (and apparently used by Rust).
> >
> > Indeed, I'm familiar with bors. Unfortunately it's quite GitHub-centric,
> > so at for the moment it's not a viable option.
> >
> > Cheers,
> >
> > - Ben
> > _______________________________________________
> > Ghc-devops-group mailing list
> > Ghc-devops-group at haskell.org
> > https://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devops-group
>
> _______________________________________________
> Ghc-devops-group mailing list
> Ghc-devops-group at haskell.org
> https://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devops-group
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.haskell.org/pipermail/ghc-devops-group/attachments/20171214/514f99f6/attachment-0001.html>
More information about the Ghc-devops-group
mailing list