[Git][ghc/ghc][wip/T25647] fix ordering

[Patrick (@soulomoon)]

Patrick pushed to branch wip/T25647 at Glasgow Haskell Compiler / GHC


Commits:
b390a34c by Patrick at 2025-03-15T23:00:02+08:00
fix ordering

- - - - -


2 changed files:

- compiler/GHC/Tc/TyCl.hs
- testsuite/tests/dependent/should_compile/T14066a.stderr


Changes:

=====================================
compiler/GHC/Tc/TyCl.hs
=====================================
@@ -259,13 +259,11 @@ quantifyFamInstLHSBinders tclvl skol_info outer_bndrs hs_outer_bndrs wcs lhs_ty
        -- See GHC.Tc.TyCl Note [Generalising in tcTyFamInstEqnGuts]
        -- See Note [Type variables in type families instance decl]
        ; (dvs, outer_wcs_imp_dvs) <- candidateQTyVarsWithBinders outer_exp_tvs (outer_imp_tvs ++ wcs) lhs_ty
-       ; (qtvs, outer_wcs_imp_qtvs') <- quantifyTyVarsWithBinders skol_info dvs outer_wcs_imp_dvs
+       ; (qtvs, outer_wcs_imp_qtvs) <- quantifyTyVarsWithBinders skol_info dvs outer_wcs_imp_dvs
                  -- Have to make a same defaulting choice for result kind here
                  -- and the `kindGeneralizeAll` in `tcConDecl`.
                  -- see (GT4) in
                  -- GHC.Tc.TyCl Note [Generalising in tcTyFamInstEqnGuts]
-       ; let outer_wcs_imp_qtvs_set = mkVarSet outer_wcs_imp_qtvs'
-       ; let outer_wcs_imp_qtvs = [v | v <- outer_wcs_imp_qtvs, v `elemVarSet` outer_wcs_imp_qtvs_set]
        ; let final_tvs = scopedSort (qtvs ++ outer_wcs_imp_qtvs ++ outer_exp_tvs)
              -- This scopedSort is important: the qtvs may be /interleaved/ with
              -- the outer_tvs.  See Note [Generalising in tcTyFamInstEqnGuts]


=====================================
testsuite/tests/dependent/should_compile/T14066a.stderr
=====================================
@@ -1,5 +1,5 @@
-
 T14066a.hs:13:3: warning: [GHC-28129] [-Winaccessible-code (in -Wdefault)]
     Type family instance equation is overlapped:
-      forall {c} {x :: c} {d} {y :: d}.
+      forall {c} {d} {x :: c} {y :: d}.
         Bar x y = Bool -- Defined at T14066a.hs:13:3
+



View it on GitLab: https://gitlab.haskell.org/ghc/ghc/-/commit/b390a34ca53ea7d7a74fcdc52c8ebd6cd4878112

-- 
View it on GitLab: https://gitlab.haskell.org/ghc/ghc/-/commit/b390a34ca53ea7d7a74fcdc52c8ebd6cd4878112
You're receiving this email because of your account on gitlab.haskell.org.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.haskell.org/pipermail/ghc-commits/attachments/20250315/47f72d96/attachment-0001.html>