[Git][ghc/ghc][wip/T25647] 94 commits: interfaces: Ensure that forceModIface deeply forces a ModIface

Patrick (@soulomoon) gitlab at gitlab.haskell.org
Thu Mar 13 17:09:51 UTC 2025 


Patrick pushed to branch wip/T25647 at Glasgow Haskell Compiler / GHC


Commits:
915a6781 by Matthew Pickering at 2025-03-13T01:46:41-04:00
interfaces: Ensure that forceModIface deeply forces a ModIface

A ModIface is the result of compilation that we keep for a long time in
memory. Therefore, it's very important to manage what we are going to
retain and remove any external references to things which we might have
captured compilation.

If storing your ModIface in memory uses too much space, then store
less things or make it use a more efficient representation.

In the past there have been many space leak bugs by not sufficiently
forcing a ModIface (#15111)

This patch adds all the missing NFData instances for all the places I
could find where we weren't deeply forcing the structure.

- - - - -
24d373a6 by Matthew Craven at 2025-03-13T01:47:18-04:00
Add interface-stability test for ghc-prim

- - - - -
751143c4 by Simon Peyton Jones at 2025-03-13T17:09:45+00:00
WIP towards #25267

- - - - -
9d4fe45d by Simon Peyton Jones at 2025-03-13T17:09:45+00:00
Wibbles

- - - - -
4e9009e5 by Simon Peyton Jones at 2025-03-13T17:09:45+00:00
Default tyvars in data/newtype insnstances

This is what fixes #25647

- - - - -
0c6cd562 by Simon Peyton Jones at 2025-03-13T17:09:45+00:00
wibbles

Including fix for #25725

- - - - -
235f0cdf by Simon Peyton Jones at 2025-03-13T17:09:45+00:00
Wibble

- - - - -
ae48bb27 by Patrick at 2025-03-13T17:09:45+00:00
add more tests

- - - - -
82e39f18 by Patrick at 2025-03-13T17:09:45+00:00
Fix up T25611d with explicit kind annotation

- - - - -
b8bbf46c by Patrick at 2025-03-13T17:09:45+00:00
fix up T25647_fail

- - - - -
0cb6ab60 by Patrick at 2025-03-13T17:09:45+00:00
cleanup whitespace

- - - - -
3f4c40bd by Patrick at 2025-03-13T17:09:45+00:00
fix up T23512a

- - - - -
f4fc3983 by Patrick at 2025-03-13T17:09:45+00:00
add more examples to T25647b

- - - - -
5185cbc4 by Patrick at 2025-03-13T17:09:45+00:00
add Dix6 to T25647_fail

- - - - -
13f84d7e by Patrick at 2025-03-13T17:09:45+00:00
add Dix7 for T25647a

- - - - -
b330762c by Patrick at 2025-03-13T17:09:45+00:00
change DefaultingStrategy of tcTyFamInstEqnGuts as well

- - - - -
c0a6467d by Patrick at 2025-03-13T17:09:45+00:00
align wildcard with named typevar on wether it is skolem

- - - - -
d4de3198 by Patrick at 2025-03-13T17:09:45+00:00
fix T17536c

- - - - -
76f10899 by Patrick at 2025-03-13T17:09:45+00:00
Fix T9357

- - - - -
1f2080b7 by Patrick at 2025-03-13T17:09:45+00:00
remove wildcard usage

- - - - -
6ff9f18c by Patrick at 2025-03-13T17:09:45+00:00
Revert "align wildcard with named typevar on wether it is skolem"

This reverts commit d1f61858328cc190de9b34c9a24e8d6b28ee5fa9.

- - - - -
bd4c36d0 by Patrick at 2025-03-13T17:09:45+00:00
add WildCardTv to forbid wildcard from defaulting

- - - - -
72ffe798 by Patrick at 2025-03-13T17:09:45+00:00
Fix wildcard related tests

- - - - -
984159ad by Patrick at 2025-03-13T17:09:45+00:00
add wildcards testcase for T25647a

- - - - -
78f422a3 by Patrick at 2025-03-13T17:09:45+00:00
Fix T25647a

- - - - -
2a7d2af1 by Patrick at 2025-03-13T17:09:45+00:00
Revert "Fix wildcard related tests"

This reverts commit 8756ab87f4e3d74968d3937f84f811f78a861852.

- - - - -
2f60a017 by Patrick at 2025-03-13T17:09:45+00:00
limit WildCardTv to only HM_FamPat

- - - - -
14707bcc by Patrick at 2025-03-13T17:09:45+00:00
fix

- - - - -
f3aaa8e3 by Patrick at 2025-03-13T17:09:45+00:00
Revert "remove wildcard usage"

This reverts commit ccc9152f23177ab7a542852ffedf626edcdcef95.

- - - - -
9f10b0ac by Patrick at 2025-03-13T17:09:45+00:00
rename WildCardTv to NoDefTauTv

- - - - -
fa4fc6a3 by Patrick at 2025-03-13T17:09:45+00:00
update note

- - - - -
ee6a594b by Patrick at 2025-03-13T17:09:45+00:00
rename isWildCardMetaTyVar to isNoDefTauMetaTyVar and fix defaultTyVarTcS

- - - - -
78e0363d by Patrick at 2025-03-13T17:09:45+00:00
fix comment

- - - - -
2990bc60 by Patrick at 2025-03-13T17:09:45+00:00
format

- - - - -
58aa2ede by Patrick at 2025-03-13T17:09:45+00:00
remove NonStandardDefaultingStrategy
and update Note [NoDefTauTv]

- - - - -
94c28d18 by Patrick at 2025-03-13T17:09:45+00:00
add DixC10 to T25647a

- - - - -
023a92d3 by Patrick at 2025-03-13T17:09:45+00:00
use TyVarTv for wildcard in HM_FamPat

- - - - -
b3103ae9 by Patrick at 2025-03-13T17:09:45+00:00
Revert "use TyVarTv for wildcard in HM_FamPat"

This reverts commit 638d6763d0b972f3c9a0e2c4218d8c7ce34dc800.

- - - - -
4362b189 by Patrick at 2025-03-13T17:09:45+00:00
Add FamArgType to in AssocInstInfo
to guide the create of tv for wildcard

- - - - -
e496bc9b by Patrick at 2025-03-13T17:09:45+00:00
Fix mode args passing down

- - - - -
f106a6b0 by Patrick at 2025-03-13T17:09:45+00:00
Fix under application for data fam

- - - - -
07376691 by Patrick at 2025-03-13T17:09:45+00:00
use HM_Sig for (a :: _) in type family

- - - - -
74eb5258 by Patrick at 2025-03-13T17:09:45+00:00
add and use HM_FamSig for (a :: _) in type family

- - - - -
7880a8a8 by Patrick at 2025-03-13T17:09:45+00:00
use TyVarTv instead of SkolemTv for freeArg `_`, since we also do not default TyVarTv in defaultTyVar and defaultTyVarTcS

- - - - -
5d8926ff by Patrick at 2025-03-13T17:09:45+00:00
Revert "add and use HM_FamSig for (a :: _) in type family"
and use ClassArg for _ in (a :: _) in type family

This reverts commit 9ab780da39c2afbce2411c2b96fef4108d6b8b70.

- - - - -
05e61b0b by Patrick at 2025-03-13T17:09:45+00:00
fix

- - - - -
1b707a67 by Patrick at 2025-03-13T17:09:45+00:00
remove unused updateHoleMode function from TcTyMode

- - - - -
ab7a299f by Patrick at 2025-03-13T17:09:45+00:00
flip the classVar to TyVarTv to observe any breakage

- - - - -
bcd5d7ef by Patrick at 2025-03-13T17:09:45+00:00
fix

- - - - -
2e49071a by Patrick at 2025-03-13T17:09:45+00:00
disable DixC10 from T25647a

- - - - -
5d07dd5b by Patrick at 2025-03-13T17:09:45+00:00
update ExplicitForAllFams4b

- - - - -
edb4f27f by Patrick at 2025-03-13T17:09:45+00:00
cleanup NoDefTauTv

- - - - -
6ec3a0a6 by Patrick at 2025-03-13T17:09:45+00:00
move [FamArgFlavour] to tyCon

- - - - -
e8608994 by Patrick at 2025-03-13T17:09:45+00:00
add note

- - - - -
46426008 by Patrick at 2025-03-13T17:09:45+00:00
refactor documentation for FamArgFlavour and clean up comments

- - - - -
5d5b3920 by Patrick at 2025-03-13T17:09:45+00:00
enhance trace logging in tcConArg and cloneAnonMetaTyVar for better debugging

- - - - -
fc4404a6 by Patrick at 2025-03-13T17:09:45+00:00
Ensure wildcard behave correctly

- - - - -
d9f5a912 by Patrick at 2025-03-13T17:09:45+00:00
Revert "update ExplicitForAllFams4b"

This reverts commit 90a2858278668bc6ad66ef43a5651808d8f24a0f.

- - - - -
fbdc08bb by Patrick at 2025-03-13T17:09:45+00:00
Add detailed notes on wildcard handling in type families and refine related documentation

- - - - -
68d192e4 by Patrick at 2025-03-13T17:09:45+00:00
Refine documentation on wildcard handling in type families and clarify design choices for FamArgFlavour

- - - - -
4b7a4859 by Patrick at 2025-03-13T17:09:45+00:00
Fix typos in documentation regarding wildcards in type families and clarify references

- - - - -
7834a051 by Patrick at 2025-03-13T17:09:45+00:00
Clarify wildcard handling in type families documentation and improve explanations for FamArgFlavour

- - - - -
fa199c2c by Patrick at 2025-03-13T17:09:45+00:00
Enhance documentation on FamArgFlavour handling in type families and clarify implementation details in TyCon and HsType modules

- - - - -
7a100fa4 by Patrick at 2025-03-13T17:09:45+00:00
format

- - - - -
1fac9206 by Patrick at 2025-03-13T17:09:45+00:00
Refactor documentation on wildcards in type families and clarify implementation details in TyCon, Rename, and HsType modules

- - - - -
cdff711b by Patrick at 2025-03-13T17:09:45+00:00
Rename variable `famArgFlvs` to `fam_arg_flvs` for consistency in type inference functions

- - - - -
4ba3cb01 by Patrick at 2025-03-13T17:09:45+00:00
Improve documentation on wildcard interpretation in type families, clarifying the relationship with class arguments and enhancing the explanation of FamArgFlavour categories.

- - - - -
edc6fa54 by Patrick at 2025-03-13T17:09:45+00:00
Add comment to clarify implementation details for wildcards in family instances

- - - - -
d1c22761 by Patrick at 2025-03-13T17:09:45+00:00
Refactor HsOuterTyVarBndrs to include implicit variable bindings and update related functions for consistency

- - - - -
21833683 by Patrick at 2025-03-13T17:09:45+00:00
Enhance HsOuterTyVarBndrs to support implicit variable bindings and update related functions for consistency

- - - - -
fbcdcb2f by Patrick at 2025-03-13T17:09:45+00:00
Add new test case T25647d

- - - - -
c1b550fd by Patrick at 2025-03-13T17:09:45+00:00
Remove unused implicit variable bindings from HsOuterExplicit in addHsOuterSigTyVarBinds function

- - - - -
4945f89d by Patrick at 2025-03-13T17:09:45+00:00
Add forall quantifiers to MultMul type family for clarity

- - - - -
9bf59ca6 by Patrick at 2025-03-13T17:09:45+00:00
Refactor bindHsOuterTyVarBndrs'

- - - - -
0e669622 by Patrick at 2025-03-13T17:09:45+00:00
Add empty implicit variable bindings to HsOuterExplicit in mkEmptySigType

- - - - -
c72b5a8c by Patrick at 2025-03-13T17:09:45+00:00
Add empty implicit variable bindings to HsOuterExplicit in synifyDataCon

- - - - -
1eebc04d by Patrick at 2025-03-13T17:09:45+00:00
Add missing implicit variable bindings to HsOuterExplicit in ExactPrint instance

- - - - -
82f361fd by Patrick at 2025-03-13T17:09:45+00:00
Add implicit variable bindings to HsOuterExplicit in various instances

- - - - -
adc10e19 by Patrick at 2025-03-13T17:09:45+00:00
Add forall quantifier to D Int newtype instance

- - - - -
344bf147 by Patrick at 2025-03-13T17:09:45+00:00
zonk_quant outer binders for families

- - - - -
2760c0bf by Patrick at 2025-03-13T17:09:45+00:00
revert to old behaviour

- - - - -
cf7f35b5 by Patrick at 2025-03-13T17:09:45+00:00
add note and comment

- - - - -
11b34f02 by Patrick at 2025-03-13T17:09:45+00:00
refactor

- - - - -
06b3a53e by Patrick at 2025-03-13T17:09:45+00:00
fix test T25647d

- - - - -
2d18216b by Patrick at 2025-03-13T17:09:45+00:00
handle [Naughty quantification candidates]

- - - - -
d170be5f by Patrick at 2025-03-13T17:09:45+00:00
handle explicit implicit binders seperately

- - - - -
db42a12e by Patrick at 2025-03-13T17:09:45+00:00
handle explicit implicit binders seperately fix

- - - - -
14ae3718 by Patrick at 2025-03-13T17:09:45+00:00
fix lint

- - - - -
ce9a64a0 by Patrick at 2025-03-13T17:09:45+00:00
some renaming

- - - - -
4de3195f by Patrick at 2025-03-13T17:09:45+00:00
update tests to reflect changes in error messages

- - - - -
be0b9311 by Patrick at 2025-03-13T17:09:45+00:00
improve zonking logic for tcFamInstLHSBinders

- - - - -
cd13a999 by Patrick at 2025-03-13T17:09:45+00:00
clean up trace statements and remove unused function

- - - - -
8e59f942 by Patrick at 2025-03-13T17:09:45+00:00
fix ppr

- - - - -
96d82e31 by Patrick at 2025-03-13T17:09:45+00:00
clear up candidateQTyVarsWithBinders

- - - - -


68 changed files:

- compiler/GHC/Core.hs
- compiler/GHC/Core/Coercion/Axiom.hs
- compiler/GHC/Core/DataCon.hs
- compiler/GHC/Core/TyCo/Rep.hs
- compiler/GHC/Core/TyCon.hs
- compiler/GHC/Data/Strict.hs
- compiler/GHC/Driver/Flags.hs
- compiler/GHC/Iface/Recomp/Types.hs
- compiler/GHC/Iface/Syntax.hs
- compiler/GHC/Iface/Type.hs
- compiler/GHC/Rename/Module.hs
- compiler/GHC/Tc/Gen/HsType.hs
- compiler/GHC/Tc/Gen/Rule.hs
- compiler/GHC/Tc/Gen/Splice.hs
- compiler/GHC/Tc/Solver.hs
- compiler/GHC/Tc/TyCl.hs
- compiler/GHC/Tc/TyCl/Instance.hs
- compiler/GHC/Tc/Types/LclEnv.hs
- compiler/GHC/Tc/Utils/Monad.hs
- compiler/GHC/Tc/Utils/TcMType.hs
- compiler/GHC/Tc/Zonk/TcType.hs
- compiler/GHC/Types/Annotations.hs
- compiler/GHC/Types/Basic.hs
- compiler/GHC/Types/CostCentre.hs
- compiler/GHC/Types/CostCentre/State.hs
- compiler/GHC/Types/ForeignCall.hs
- compiler/GHC/Types/GREInfo.hs
- compiler/GHC/Types/Literal.hs
- compiler/GHC/Types/SourceFile.hs
- compiler/GHC/Types/SrcLoc.hs
- compiler/GHC/Types/Var.hs
- compiler/GHC/Unit/Module/Deps.hs
- compiler/GHC/Unit/Module/ModIface.hs
- compiler/GHC/Unit/Types.hs
- compiler/Language/Haskell/Syntax/Basic.hs
- compiler/Language/Haskell/Syntax/Decls.hs
- compiler/Language/Haskell/Syntax/Type.hs
- compiler/Language/Haskell/Syntax/Type.hs-boot
- libraries/ghc-boot/GHC/Serialized.hs
- + testsuite/tests/indexed-types/should_compile/T11450a.hs
- testsuite/tests/indexed-types/should_compile/T25611d.hs
- testsuite/tests/indexed-types/should_compile/all.T
- testsuite/tests/indexed-types/should_fail/SimpleFail2a.hs
- testsuite/tests/indexed-types/should_fail/SimpleFail2a.stderr
- testsuite/tests/indexed-types/should_fail/SimpleFail9.hs
- testsuite/tests/indexed-types/should_fail/SimpleFail9.stderr
- testsuite/tests/indexed-types/should_fail/T14230a.hs
- testsuite/tests/indexed-types/should_fail/T14230a.stderr
- testsuite/tests/indexed-types/should_fail/T14246.stderr
- testsuite/tests/indexed-types/should_fail/T9357.stderr
- testsuite/tests/interface-stability/README.mkd
- testsuite/tests/interface-stability/all.T
- + testsuite/tests/interface-stability/ghc-prim-exports.stdout
- + testsuite/tests/interface-stability/ghc-prim-exports.stdout-mingw32
- testsuite/tests/rename/should_fail/T23512a.stderr
- + testsuite/tests/typecheck/should_compile/T25647_fail.hs
- + testsuite/tests/typecheck/should_compile/T25647_fail.stderr
- + testsuite/tests/typecheck/should_compile/T25647a.hs
- + testsuite/tests/typecheck/should_compile/T25647b.hs
- + testsuite/tests/typecheck/should_compile/T25647c.hs
- + testsuite/tests/typecheck/should_compile/T25647d.hs
- + testsuite/tests/typecheck/should_compile/T25647d_fail.hs
- + testsuite/tests/typecheck/should_compile/T25647d_fail.stderr
- + testsuite/tests/typecheck/should_compile/T25725.hs
- testsuite/tests/typecheck/should_compile/all.T
- testsuite/tests/typecheck/should_fail/T18640b.stderr
- utils/dump-decls/Main.hs
- utils/haddock/haddock-api/src/Haddock/Types.hs


The diff was not included because it is too large.


View it on GitLab: https://gitlab.haskell.org/ghc/ghc/-/compare/002e69f975752208c082b02c9c990ed985ba11d1...96d82e31961178022de2fd88972413f34f1de27f

-- 
View it on GitLab: https://gitlab.haskell.org/ghc/ghc/-/compare/002e69f975752208c082b02c9c990ed985ba11d1...96d82e31961178022de2fd88972413f34f1de27f
You're receiving this email because of your account on gitlab.haskell.org.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.haskell.org/pipermail/ghc-commits/attachments/20250313/ef8afc84/attachment-0001.html>

More information about the ghc-commits mailing list