[Git][ghc/ghc][wip/T25647] 93 commits: We can't UNPACK multi-constructor GADTs

Patrick (@soulomoon) gitlab at gitlab.haskell.org
Wed Mar 12 18:13:25 UTC 2025 


Patrick pushed to branch wip/T25647 at Glasgow Haskell Compiler / GHC


Commits:
b6d5b091 by Simon Peyton Jones at 2025-03-11T22:39:23-04:00
We can't UNPACK multi-constructor GADTs

This MR fixes #25672

See Note [Unpacking GADTs and existentials] in GHC.Types.Id.Make

- - - - -
8eae151d by Teo Camarasu at 2025-03-11T22:40:00-04:00
template-haskell: Add explicit exports lists to all remaining modules

- - - - -
db621b58 by Teo Camarasu at 2025-03-11T22:40:00-04:00
template-haskell: fix haddocks

It seems that we need a direct dependency on ghc-internal, otherwise
Haddock cannot find our haddocks

The bug seems to be caused by Hadrian because if I rebuild with
cabal-install (without this extra dependency) then I get accurate
Haddocks.

Resolves #25705

- - - - -
64ea68d9 by Ben Gamari at 2025-03-12T07:11:51-04:00
mk-ghcup-metadata: Clean up and add type annotations

Getting this file right has historically been quite painful as it is a
dynamically-typed script running only late in the release pipeline.

- - - - -
b3f80b07 by Ben Gamari at 2025-03-12T07:12:27-04:00
rts: Drop imports of pthreads functions in cmm sources

These are no longer used. I noticed these while looking for uses of
__PIC__ in Cmm sources.

- - - - -
1a388aa3 by Simon Peyton Jones at 2025-03-12T18:13:19+00:00
WIP towards #25267

- - - - -
18c38e00 by Simon Peyton Jones at 2025-03-12T18:13:19+00:00
Wibbles

- - - - -
7cff62c4 by Simon Peyton Jones at 2025-03-12T18:13:19+00:00
Default tyvars in data/newtype insnstances

This is what fixes #25647

- - - - -
a259fffa by Simon Peyton Jones at 2025-03-12T18:13:19+00:00
wibbles

Including fix for #25725

- - - - -
a0f9b55d by Simon Peyton Jones at 2025-03-12T18:13:19+00:00
Wibble

- - - - -
6aa36f4d by Patrick at 2025-03-12T18:13:19+00:00
add more tests

- - - - -
e11c10d2 by Patrick at 2025-03-12T18:13:19+00:00
Fix up T25611d with explicit kind annotation

- - - - -
f7cba233 by Patrick at 2025-03-12T18:13:19+00:00
fix up T25647_fail

- - - - -
87c78c2c by Patrick at 2025-03-12T18:13:19+00:00
cleanup whitespace

- - - - -
a370480b by Patrick at 2025-03-12T18:13:19+00:00
fix up T23512a

- - - - -
5d80f02e by Patrick at 2025-03-12T18:13:19+00:00
add more examples to T25647b

- - - - -
6cc88c6d by Patrick at 2025-03-12T18:13:19+00:00
add Dix6 to T25647_fail

- - - - -
0fc151c1 by Patrick at 2025-03-12T18:13:19+00:00
add Dix7 for T25647a

- - - - -
7ce260f7 by Patrick at 2025-03-12T18:13:19+00:00
change DefaultingStrategy of tcTyFamInstEqnGuts as well

- - - - -
8f74eaa5 by Patrick at 2025-03-12T18:13:19+00:00
align wildcard with named typevar on wether it is skolem

- - - - -
71ca02f9 by Patrick at 2025-03-12T18:13:19+00:00
fix T17536c

- - - - -
cd3b902e by Patrick at 2025-03-12T18:13:19+00:00
Fix T9357

- - - - -
91d84010 by Patrick at 2025-03-12T18:13:19+00:00
remove wildcard usage

- - - - -
bc5abed3 by Patrick at 2025-03-12T18:13:19+00:00
Revert "align wildcard with named typevar on wether it is skolem"

This reverts commit d1f61858328cc190de9b34c9a24e8d6b28ee5fa9.

- - - - -
b9008121 by Patrick at 2025-03-12T18:13:19+00:00
add WildCardTv to forbid wildcard from defaulting

- - - - -
c685430c by Patrick at 2025-03-12T18:13:19+00:00
Fix wildcard related tests

- - - - -
2e31b0c6 by Patrick at 2025-03-12T18:13:19+00:00
add wildcards testcase for T25647a

- - - - -
e4b7538e by Patrick at 2025-03-12T18:13:19+00:00
Fix T25647a

- - - - -
b967ea8c by Patrick at 2025-03-12T18:13:19+00:00
Revert "Fix wildcard related tests"

This reverts commit 8756ab87f4e3d74968d3937f84f811f78a861852.

- - - - -
6d2a5b26 by Patrick at 2025-03-12T18:13:19+00:00
limit WildCardTv to only HM_FamPat

- - - - -
7b89f733 by Patrick at 2025-03-12T18:13:19+00:00
fix

- - - - -
00fe5f3a by Patrick at 2025-03-12T18:13:19+00:00
Revert "remove wildcard usage"

This reverts commit ccc9152f23177ab7a542852ffedf626edcdcef95.

- - - - -
85491f9f by Patrick at 2025-03-12T18:13:19+00:00
rename WildCardTv to NoDefTauTv

- - - - -
b5eb1433 by Patrick at 2025-03-12T18:13:19+00:00
update note

- - - - -
d21ed79f by Patrick at 2025-03-12T18:13:19+00:00
rename isWildCardMetaTyVar to isNoDefTauMetaTyVar and fix defaultTyVarTcS

- - - - -
5d747c7e by Patrick at 2025-03-12T18:13:19+00:00
fix comment

- - - - -
687360ca by Patrick at 2025-03-12T18:13:19+00:00
format

- - - - -
0330db9d by Patrick at 2025-03-12T18:13:19+00:00
remove NonStandardDefaultingStrategy
and update Note [NoDefTauTv]

- - - - -
a969a09e by Patrick at 2025-03-12T18:13:19+00:00
add DixC10 to T25647a

- - - - -
d699ddd7 by Patrick at 2025-03-12T18:13:19+00:00
use TyVarTv for wildcard in HM_FamPat

- - - - -
1a080142 by Patrick at 2025-03-12T18:13:19+00:00
Revert "use TyVarTv for wildcard in HM_FamPat"

This reverts commit 638d6763d0b972f3c9a0e2c4218d8c7ce34dc800.

- - - - -
3818f0fe by Patrick at 2025-03-12T18:13:19+00:00
Add FamArgType to in AssocInstInfo
to guide the create of tv for wildcard

- - - - -
005a18d6 by Patrick at 2025-03-12T18:13:19+00:00
Fix mode args passing down

- - - - -
2f0f03c2 by Patrick at 2025-03-12T18:13:19+00:00
Fix under application for data fam

- - - - -
b72bb167 by Patrick at 2025-03-12T18:13:19+00:00
use HM_Sig for (a :: _) in type family

- - - - -
d1add315 by Patrick at 2025-03-12T18:13:19+00:00
add and use HM_FamSig for (a :: _) in type family

- - - - -
0cb0d60b by Patrick at 2025-03-12T18:13:19+00:00
use TyVarTv instead of SkolemTv for freeArg `_`, since we also do not default TyVarTv in defaultTyVar and defaultTyVarTcS

- - - - -
0e0a3220 by Patrick at 2025-03-12T18:13:19+00:00
Revert "add and use HM_FamSig for (a :: _) in type family"
and use ClassArg for _ in (a :: _) in type family

This reverts commit 9ab780da39c2afbce2411c2b96fef4108d6b8b70.

- - - - -
e71a52cb by Patrick at 2025-03-12T18:13:19+00:00
fix

- - - - -
2ca7ff8b by Patrick at 2025-03-12T18:13:19+00:00
remove unused updateHoleMode function from TcTyMode

- - - - -
dadd2e01 by Patrick at 2025-03-12T18:13:19+00:00
flip the classVar to TyVarTv to observe any breakage

- - - - -
64a2098e by Patrick at 2025-03-12T18:13:19+00:00
fix

- - - - -
ea1f3b87 by Patrick at 2025-03-12T18:13:19+00:00
disable DixC10 from T25647a

- - - - -
ef110541 by Patrick at 2025-03-12T18:13:19+00:00
update ExplicitForAllFams4b

- - - - -
43a2c5ee by Patrick at 2025-03-12T18:13:19+00:00
cleanup NoDefTauTv

- - - - -
d304aa90 by Patrick at 2025-03-12T18:13:19+00:00
move [FamArgFlavour] to tyCon

- - - - -
5700dda5 by Patrick at 2025-03-12T18:13:19+00:00
add note

- - - - -
c97aba56 by Patrick at 2025-03-12T18:13:19+00:00
refactor documentation for FamArgFlavour and clean up comments

- - - - -
8567b3b9 by Patrick at 2025-03-12T18:13:19+00:00
enhance trace logging in tcConArg and cloneAnonMetaTyVar for better debugging

- - - - -
bc42743d by Patrick at 2025-03-12T18:13:19+00:00
Ensure wildcard behave correctly

- - - - -
3082f8e3 by Patrick at 2025-03-12T18:13:19+00:00
Revert "update ExplicitForAllFams4b"

This reverts commit 90a2858278668bc6ad66ef43a5651808d8f24a0f.

- - - - -
657e2cb8 by Patrick at 2025-03-12T18:13:19+00:00
Add detailed notes on wildcard handling in type families and refine related documentation

- - - - -
43b8a26c by Patrick at 2025-03-12T18:13:19+00:00
Refine documentation on wildcard handling in type families and clarify design choices for FamArgFlavour

- - - - -
97c0fc9c by Patrick at 2025-03-12T18:13:19+00:00
Fix typos in documentation regarding wildcards in type families and clarify references

- - - - -
9dd00d82 by Patrick at 2025-03-12T18:13:19+00:00
Clarify wildcard handling in type families documentation and improve explanations for FamArgFlavour

- - - - -
6109b368 by Patrick at 2025-03-12T18:13:19+00:00
Enhance documentation on FamArgFlavour handling in type families and clarify implementation details in TyCon and HsType modules

- - - - -
3846ea1e by Patrick at 2025-03-12T18:13:19+00:00
format

- - - - -
2c0049d3 by Patrick at 2025-03-12T18:13:19+00:00
Refactor documentation on wildcards in type families and clarify implementation details in TyCon, Rename, and HsType modules

- - - - -
0c40cdc7 by Patrick at 2025-03-12T18:13:19+00:00
Rename variable `famArgFlvs` to `fam_arg_flvs` for consistency in type inference functions

- - - - -
e5790c0a by Patrick at 2025-03-12T18:13:19+00:00
Improve documentation on wildcard interpretation in type families, clarifying the relationship with class arguments and enhancing the explanation of FamArgFlavour categories.

- - - - -
1047047e by Patrick at 2025-03-12T18:13:19+00:00
Add comment to clarify implementation details for wildcards in family instances

- - - - -
e1669f68 by Patrick at 2025-03-12T18:13:19+00:00
Refactor HsOuterTyVarBndrs to include implicit variable bindings and update related functions for consistency

- - - - -
a7b21545 by Patrick at 2025-03-12T18:13:19+00:00
Enhance HsOuterTyVarBndrs to support implicit variable bindings and update related functions for consistency

- - - - -
ea505683 by Patrick at 2025-03-12T18:13:19+00:00
Add new test case T25647d

- - - - -
3820368b by Patrick at 2025-03-12T18:13:19+00:00
Remove unused implicit variable bindings from HsOuterExplicit in addHsOuterSigTyVarBinds function

- - - - -
23efde26 by Patrick at 2025-03-12T18:13:19+00:00
Add forall quantifiers to MultMul type family for clarity

- - - - -
74a54653 by Patrick at 2025-03-12T18:13:19+00:00
Refactor bindHsOuterTyVarBndrs'

- - - - -
84207ab1 by Patrick at 2025-03-12T18:13:19+00:00
Add empty implicit variable bindings to HsOuterExplicit in mkEmptySigType

- - - - -
844484cd by Patrick at 2025-03-12T18:13:19+00:00
Add empty implicit variable bindings to HsOuterExplicit in synifyDataCon

- - - - -
5afa406f by Patrick at 2025-03-12T18:13:19+00:00
Add missing implicit variable bindings to HsOuterExplicit in ExactPrint instance

- - - - -
6c2835e8 by Patrick at 2025-03-12T18:13:19+00:00
Add implicit variable bindings to HsOuterExplicit in various instances

- - - - -
2b037a4d by Patrick at 2025-03-12T18:13:19+00:00
Add forall quantifier to D Int newtype instance

- - - - -
330151a1 by Patrick at 2025-03-12T18:13:19+00:00
zonk_quant outer binders for families

- - - - -
1f4d5454 by Patrick at 2025-03-12T18:13:19+00:00
revert to old behaviour

- - - - -
39077466 by Patrick at 2025-03-12T18:13:19+00:00
add note and comment

- - - - -
170a5d89 by Patrick at 2025-03-12T18:13:19+00:00
refactor

- - - - -
9a749c3e by Patrick at 2025-03-12T18:13:19+00:00
fix test T25647d

- - - - -
07316009 by Patrick at 2025-03-12T18:13:19+00:00
handle [Naughty quantification candidates]

- - - - -
0f2dae68 by Patrick at 2025-03-12T18:13:19+00:00
handle explicit implicit binders seperately

- - - - -
687ab1ef by Patrick at 2025-03-12T18:13:19+00:00
handle explicit implicit binders seperately fix

- - - - -
475c3026 by Patrick at 2025-03-12T18:13:19+00:00
fix lint

- - - - -
af9ae387 by Patrick at 2025-03-12T18:13:19+00:00
some renaming

- - - - -
566edcef by Patrick at 2025-03-12T18:13:19+00:00
update tests to reflect changes in error messages

- - - - -


50 changed files:

- .gitlab/rel_eng/mk-ghcup-metadata/mk_ghcup_metadata.py
- compiler/GHC/Core/DataCon.hs
- compiler/GHC/Rename/Module.hs
- compiler/GHC/Tc/Gen/HsType.hs
- compiler/GHC/Tc/Gen/Rule.hs
- compiler/GHC/Tc/Solver.hs
- compiler/GHC/Tc/TyCl.hs
- compiler/GHC/Tc/TyCl/Instance.hs
- compiler/GHC/Tc/Types/LclEnv.hs
- compiler/GHC/Tc/Utils/Monad.hs
- compiler/GHC/Tc/Utils/TcMType.hs
- compiler/GHC/Tc/Zonk/TcType.hs
- compiler/GHC/Types/Basic.hs
- compiler/GHC/Types/Id/Make.hs
- compiler/Language/Haskell/Syntax/Decls.hs
- libraries/template-haskell/Language/Haskell/TH/Ppr.hs
- libraries/template-haskell/Language/Haskell/TH/PprLib.hs
- libraries/template-haskell/Language/Haskell/TH/Syntax.hs
- libraries/template-haskell/template-haskell.cabal.in
- rts/HeapStackCheck.cmm
- rts/PrimOps.cmm
- + testsuite/tests/indexed-types/should_compile/T11450a.hs
- testsuite/tests/indexed-types/should_compile/T25611d.hs
- testsuite/tests/indexed-types/should_compile/all.T
- testsuite/tests/indexed-types/should_fail/SimpleFail2a.hs
- testsuite/tests/indexed-types/should_fail/SimpleFail2a.stderr
- testsuite/tests/indexed-types/should_fail/SimpleFail9.hs
- testsuite/tests/indexed-types/should_fail/SimpleFail9.stderr
- testsuite/tests/indexed-types/should_fail/T14230a.hs
- testsuite/tests/indexed-types/should_fail/T14230a.stderr
- testsuite/tests/indexed-types/should_fail/T14246.stderr
- testsuite/tests/indexed-types/should_fail/T9357.stderr
- testsuite/tests/rename/should_fail/T23512a.stderr
- + testsuite/tests/simplCore/should_fail/T25672.hs
- + testsuite/tests/simplCore/should_fail/T25672.stderr
- testsuite/tests/simplCore/should_fail/all.T
- + testsuite/tests/typecheck/should_compile/T25647_fail.hs
- + testsuite/tests/typecheck/should_compile/T25647_fail.stderr
- + testsuite/tests/typecheck/should_compile/T25647a.hs
- + testsuite/tests/typecheck/should_compile/T25647b.hs
- + testsuite/tests/typecheck/should_compile/T25647c.hs
- + testsuite/tests/typecheck/should_compile/T25647d.hs
- + testsuite/tests/typecheck/should_compile/T25647d_fail.hs
- + testsuite/tests/typecheck/should_compile/T25647d_fail.stderr
- + testsuite/tests/typecheck/should_compile/T25725.hs
- testsuite/tests/typecheck/should_compile/all.T
- testsuite/tests/typecheck/should_fail/T18640b.stderr
- utils/haddock/html-test/ref/QuasiExpr.html
- utils/haddock/html-test/ref/TH.html
- utils/haddock/html-test/ref/Threaded_TH.html


The diff was not included because it is too large.


View it on GitLab: https://gitlab.haskell.org/ghc/ghc/-/compare/a3b1fedd205356f9e8006148c1c62b0f49927a38...566edcef30a738576b1f71cbceca405a0d681681

-- 
View it on GitLab: https://gitlab.haskell.org/ghc/ghc/-/compare/a3b1fedd205356f9e8006148c1c62b0f49927a38...566edcef30a738576b1f71cbceca405a0d681681
You're receiving this email because of your account on gitlab.haskell.org.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.haskell.org/pipermail/ghc-commits/attachments/20250312/91b8a865/attachment-0001.html>

More information about the ghc-commits mailing list