[Git][ghc/ghc][wip/soulomoon/suggest-UnliftedNewtypes-unlifted-data-family-25593] update note

Patrick (@soulomoon) gitlab at gitlab.haskell.org
Thu Jan 9 06:51:11 UTC 2025



Patrick pushed to branch wip/soulomoon/suggest-UnliftedNewtypes-unlifted-data-family-25593 at Glasgow Haskell Compiler / GHC


Commits:
e9ca2183 by Patrick at 2025-01-09T14:51:01+08:00
update note

- - - - -


1 changed file:

- compiler/GHC/Tc/TyCl/Instance.hs


Changes:

=====================================
compiler/GHC/Tc/TyCl/Instance.hs
=====================================
@@ -1011,7 +1011,7 @@ tcDataFamInstHeader mb_clsinfo skol_info fam_tc hs_outer_bndrs fixity
 
     -- See Note [Implementation of UnliftedNewtypes] in GHC.Tc.TyCl, families (2),
     -- , Note [Implementation of UnliftedDatatypes]
-    -- and Note [Defaulting newtype/data family instance].
+    -- and Note [Defaulting kind of newtype/data family instance].
     tc_kind_sig Nothing
       = do { unlifted_newtypes  <- xoptM LangExt.UnliftedNewtypes
            ; unlifted_datatypes <- xoptM LangExt.UnliftedDatatypes
@@ -1039,7 +1039,7 @@ we actually have a place to put the regeneralised variables.
 Thus: skolemise away. cf. GHC.Tc.Utils.Unify.tcTopSkolemise
 Examples in indexed-types/should_compile/T12369
 
-Note [Defaulting newtype/data family instance]
+Note [Defaulting kind of newtype/data family instance]
 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
 It is tempting to let `tc_kind_sig` just return `newOpenTypeKind`
 even without `-XUnliftedNewtypes`, but we rely on `tc_kind_sig` to



View it on GitLab: https://gitlab.haskell.org/ghc/ghc/-/commit/e9ca218328efdad63b77da4b324664e9e4806898

-- 
View it on GitLab: https://gitlab.haskell.org/ghc/ghc/-/commit/e9ca218328efdad63b77da4b324664e9e4806898
You're receiving this email because of your account on gitlab.haskell.org.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.haskell.org/pipermail/ghc-commits/attachments/20250109/d433b442/attachment-0001.html>


More information about the ghc-commits mailing list