[Git][ghc/ghc][wip/romes/graph-compact-easy] Landmine after pruning

Rodrigo Mesquita (@alt-romes) gitlab at gitlab.haskell.org
Mon Jan 6 17:58:06 UTC 2025



Rodrigo Mesquita pushed to branch wip/romes/graph-compact-easy at Glasgow Haskell Compiler / GHC


Commits:
5f6dcccd by Rodrigo Mesquita at 2025-01-06T17:57:07+00:00
Landmine after pruning

- - - - -


1 changed file:

- compiler/GHC/Driver/Make.hs


Changes:

=====================================
compiler/GHC/Driver/Make.hs
=====================================
@@ -774,8 +774,7 @@ load' mhmi_cache how_much diag_wrapper mHscMessage mod_graph = do
     -- write an empty HPT to allow the old HPT to be GC'd.
 
     let pruneHomeUnitEnv hme = do
-          emptyHPT <- liftIO emptyHomePackageTable
-          pure $! hme{ homeUnitEnv_hpt = emptyHPT }
+          pure $! hme{ homeUnitEnv_hpt = panic "after pruning home unit env, the hpt should never ever again be referenced." }
     hug' <- traverse pruneHomeUnitEnv (ue_home_unit_graph $ hsc_unit_env hsc_env)
     let ue' = (hsc_unit_env hsc_env){ ue_home_unit_graph = hug' }
     setSession $ discardIC hsc_env{hsc_unit_env = ue' }



View it on GitLab: https://gitlab.haskell.org/ghc/ghc/-/commit/5f6dcccd5f29de1838ee0046648a5ff6b4936f49

-- 
View it on GitLab: https://gitlab.haskell.org/ghc/ghc/-/commit/5f6dcccd5f29de1838ee0046648a5ff6b4936f49
You're receiving this email because of your account on gitlab.haskell.org.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.haskell.org/pipermail/ghc-commits/attachments/20250106/750b87e8/attachment-0001.html>


More information about the ghc-commits mailing list