[Git][ghc/ghc][wip/andreask/bitcast_panic] cmmMachOpFoldM: Add missing pattern matches for bitcasts.

[Andreas Klebinger (@AndreasK)]

Andreas Klebinger pushed to branch wip/andreask/bitcast_panic at Glasgow Haskell Compiler / GHC


Commits:
e2a43d53 by Andreas Klebinger at 2025-02-27T21:08:24+01:00
cmmMachOpFoldM: Add missing pattern matches for bitcasts.

- - - - -


1 changed file:

- compiler/GHC/Cmm/Opt.hs


Changes:

=====================================
compiler/GHC/Cmm/Opt.hs
=====================================
@@ -63,18 +63,23 @@ cmmMachOpFoldM _ (MO_VF_Broadcast lg _w) exprs =
     [CmmLit l] -> Just $! CmmLit (CmmVec $ replicate lg l)
     _ -> Nothing
 cmmMachOpFoldM _ op [CmmLit (CmmInt x rep)]
-  = Just $! case op of
-      MO_S_Neg _ -> CmmLit (CmmInt (narrowS rep (-x)) rep)
-      MO_Not _   -> CmmLit (CmmInt (complement x) rep)
+  = case op of
+      MO_S_Neg _ -> Just $! CmmLit (CmmInt (narrowS rep (-x)) rep)
+      MO_Not _   -> Just $! CmmLit (CmmInt (complement x) rep)
 
         -- these are interesting: we must first narrow to the
         -- "from" type, in order to truncate to the correct size.
         -- The final narrow/widen to the destination type
         -- is implicit in the CmmLit.
-      MO_SF_Round _frm to -> CmmLit (CmmFloat (fromInteger x) to)
-      MO_SS_Conv  from to -> CmmLit (CmmInt (narrowS from x) to)
-      MO_UU_Conv  from to -> CmmLit (CmmInt (narrowU from x) to)
-      MO_XX_Conv  from to -> CmmLit (CmmInt (narrowS from x) to)
+      MO_SF_Round _frm to -> Just $! CmmLit (CmmFloat (fromInteger x) to)
+      MO_SS_Conv  from to -> Just $! CmmLit (CmmInt (narrowS from x) to)
+      MO_UU_Conv  from to -> Just $! CmmLit (CmmInt (narrowU from x) to)
+      MO_XX_Conv  from to -> Just $! CmmLit (CmmInt (narrowS from x) to)
+
+      -- Not as simply as it seems, since CmmFloat uses Rational, so skipping those
+      -- for now ...
+      MO_WF_Bitcast _w -> Nothing
+      MO_FW_Bitcast _w -> Nothing
       _ -> panic $ "cmmMachOpFoldM: unknown unary op: " ++ show op
 
 -- Eliminate shifts that are wider than the shiftee



View it on GitLab: https://gitlab.haskell.org/ghc/ghc/-/commit/e2a43d53680fe3247426e70f00d506c711be53ab

-- 
View it on GitLab: https://gitlab.haskell.org/ghc/ghc/-/commit/e2a43d53680fe3247426e70f00d506c711be53ab
You're receiving this email because of your account on gitlab.haskell.org.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.haskell.org/pipermail/ghc-commits/attachments/20250227/2a87e825/attachment-0001.html>