[Git][ghc/ghc][master] Tidy up error messages for TypeAbstractions
Marge Bot (@marge-bot)
gitlab at gitlab.haskell.org
Wed Feb 26 16:04:59 UTC 2025
Marge Bot pushed to branch master at Glasgow Haskell Compiler / GHC
Commits:
6acaff2b by Vladislav Zavialov at 2025-02-26T11:04:15-05:00
Tidy up error messages for TypeAbstractions
1. Print the '@' symbol before invisible patterns and improve phrasing:
T24557c.hs:8:4: error: [GHC-11983]
- Invisible type pattern pat is not allowed here
+ Illegal invisible type pattern: @pat
+ An invisible type pattern must occur in an argument position.
2. Use a single error code for all type abstractions deemed illegal
due to the TypeAbstractions extension being disabled.
Before this change:
* [GHC-78249] was used in function equations, lambdas
* [GHC-17916] was used in constructor patterns
After this change:
* [GHC-78249] is used to report all illegal type abstractions
* [GHC-17916] is no longer used
There was no reason for both error codes to exist and this distinction
was a source of complexity in GHC/Tc/Errors/* and GHC/Rename/Pat.hs
3. Group the different "invisible type pattern" error constructors
under a single parent constructor, TcRnIllegalInvisibleTypePattern
containing BadInvisPatReason
- - - - -
21 changed files:
- compiler/GHC/Rename/Pat.hs
- compiler/GHC/Rename/Utils.hs
- compiler/GHC/Tc/Errors/Ppr.hs
- compiler/GHC/Tc/Errors/Types.hs
- compiler/GHC/Tc/Gen/Pat.hs
- compiler/GHC/Types/Error/Codes.hs
- testsuite/tests/rename/should_fail/T17594b.hs
- testsuite/tests/rename/should_fail/T17594b.stderr
- + testsuite/tests/rename/should_fail/T17594b_th.hs
- + testsuite/tests/rename/should_fail/T17594b_th.stderr
- testsuite/tests/rename/should_fail/T22478e.stderr
- testsuite/tests/rename/should_fail/all.T
- testsuite/tests/th/T24557a.stderr
- testsuite/tests/th/T24557b.stderr
- testsuite/tests/th/T24557c.stderr
- testsuite/tests/th/T24557d.stderr
- testsuite/tests/typecheck/should_fail/T17594c.stderr
- testsuite/tests/typecheck/should_fail/T17594d.stderr
- testsuite/tests/typecheck/should_fail/T17594g.stderr
- testsuite/tests/typecheck/should_fail/T19109.stderr
- testsuite/tests/typecheck/should_fail/T23776.stderr
Changes:
=====================================
compiler/GHC/Rename/Pat.hs
=====================================
@@ -91,7 +91,6 @@ import Data.Foldable
import Data.Function ( on )
import Data.Functor.Identity ( Identity (..) )
import qualified Data.List.NonEmpty as NE
-import Data.Maybe
import Data.Ratio
import Control.Monad.Trans.Writer.CPS
import Control.Monad.Trans.Class
@@ -509,9 +508,9 @@ rnLArgPatAndThen :: NameMaker -> LocatedA (Pat GhcPs) -> CpsRn (LocatedA (Pat Gh
rnLArgPatAndThen mk = wrapSrcSpanCps rnArgPatAndThen where
rnArgPatAndThen (InvisPat (_, spec) tp) = do
- liftCps $ unlessXOptM LangExt.TypeAbstractions $
- addErr (TcRnIllegalInvisibleTypePattern tp)
tp' <- rnHsTyPat HsTypePatCtx tp
+ liftCps $ unlessXOptM LangExt.TypeAbstractions $
+ addErr (TcRnIllegalInvisibleTypePattern tp' InvisPatWithoutFlag)
pure (InvisPat spec tp')
rnArgPatAndThen p = rnPatAndThen mk p
@@ -679,10 +678,10 @@ rnPatAndThen _ (EmbTyPat _ tp)
= do { tp' <- rnHsTyPat HsTypePatCtx tp
; return (EmbTyPat noExtField tp') }
rnPatAndThen _ (InvisPat (_, spec) tp)
- = do { liftCps $ addErr (TcRnMisplacedInvisPat tp)
- -- Invisible patterns are handled in `rnLArgPatAndThen`
+ = do { -- Invisible patterns are handled in `rnLArgPatAndThen`
-- so unconditionally emit error here
; tp' <- rnHsTyPat HsTypePatCtx tp
+ ; liftCps $ addErr (TcRnIllegalInvisibleTypePattern tp' InvisPatMisplaced)
; return (InvisPat spec tp')
}
@@ -694,7 +693,6 @@ rnConPatAndThen :: NameMaker
rnConPatAndThen mk con (PrefixCon tyargs pats)
= do { con' <- lookupConCps con
- ; liftCps check_lang_exts
; tyargs' <- mapM rnConPatTyArg tyargs
; pats' <- rnLPatsAndThen mk pats
; return $ ConPat
@@ -704,16 +702,11 @@ rnConPatAndThen mk con (PrefixCon tyargs pats)
}
}
where
- check_lang_exts :: RnM ()
- check_lang_exts =
- for_ (listToMaybe tyargs) $ \ arg ->
- unlessXOptM LangExt.TypeAbstractions $
- addErrTc $
- TcRnTypeApplicationsDisabled (TypeApplicationInPattern arg)
-
- rnConPatTyArg (HsConPatTyArg _ t) = do
- t' <- rnHsTyPat HsTypePatCtx t
- return (HsConPatTyArg noExtField t')
+ rnConPatTyArg (HsConPatTyArg _ tp) = do
+ tp' <- rnHsTyPat HsTypePatCtx tp
+ liftCps $ unlessXOptM LangExt.TypeAbstractions $
+ addErr (TcRnIllegalInvisibleTypePattern tp' InvisPatWithoutFlag)
+ return (HsConPatTyArg noExtField tp')
rnConPatAndThen mk con (InfixCon pat1 pat2)
= do { con' <- lookupConCps con
=====================================
compiler/GHC/Rename/Utils.hs
=====================================
@@ -672,7 +672,7 @@ badQualBndrErr :: RdrName -> TcRnMessage
badQualBndrErr rdr_name = TcRnQualifiedBinder rdr_name
typeAppErr :: TypeOrKind -> LHsType GhcPs -> TcRnMessage
-typeAppErr what (L _ k) = TcRnTypeApplicationsDisabled (TypeApplication k what)
+typeAppErr what (L _ k) = TcRnTypeApplicationsDisabled k what
badFieldConErr :: Name -> FieldLabelString -> TcRnMessage
badFieldConErr con field = TcRnInvalidRecordField con field
=====================================
compiler/GHC/Tc/Errors/Ppr.hs
=====================================
@@ -1811,23 +1811,15 @@ instance Diagnostic TcRnMessage where
TcRnQualifiedBinder rdr_name
-> mkSimpleDecorated $
text "Qualified name in binding position:" <+> ppr rdr_name
- TcRnTypeApplicationsDisabled ty_app
+ TcRnTypeApplicationsDisabled ty ty_or_ki
-> mkSimpleDecorated $
- text "Illegal visible" <+> what <+> text "application" <+> ctx <> colon
+ text "Illegal visible" <+> what <+> text "application" <> colon
<+> ppr arg
where
- arg = case ty_app of
- TypeApplication ty _ -> char '@' <> ppr ty
- TypeApplicationInPattern ty_app -> ppr ty_app
- what = case ty_app of
- TypeApplication _ ty_or_ki ->
- case ty_or_ki of
- TypeLevel -> text "type"
- KindLevel -> text "kind"
- TypeApplicationInPattern _ -> text "type"
- ctx = case ty_app of
- TypeApplicationInPattern _ -> text "in a pattern"
- _ -> empty
+ arg = char '@' <> ppr ty
+ what = case ty_or_ki of
+ TypeLevel -> text "type"
+ KindLevel -> text "kind"
TcRnInvalidRecordField con field
-> mkSimpleDecorated $
hsep [text "Constructor" <+> quotes (ppr con),
@@ -1972,11 +1964,14 @@ instance Diagnostic TcRnMessage where
WarningTxt{} -> text "WARNING"
DeprecatedTxt{} -> text "DEPRECATED"
- TcRnIllegalInvisibleTypePattern tp -> mkSimpleDecorated $
- text "Illegal invisible type pattern:" <+> ppr tp
-
- TcRnInvisPatWithNoForAll tp -> mkSimpleDecorated $
- text "Invisible type pattern" <+> ppr tp <+> text "has no associated forall"
+ TcRnIllegalInvisibleTypePattern tp reason -> mkSimpleDecorated $
+ vcat [ hang (text "Illegal invisible type pattern:")
+ 2 (char '@' <> ppr tp)
+ , case reason of
+ InvisPatWithoutFlag -> empty
+ InvisPatNoForall -> text "An invisible type pattern must be checked against a forall."
+ InvisPatMisplaced -> text "An invisible type pattern must occur in an argument position."
+ ]
TcRnNamespacedFixitySigWithoutFlag sig@(FixitySig kw _ _) -> mkSimpleDecorated $
vcat [ text "Illegal use of the" <+> quotes (ppr kw) <+> text "keyword:"
@@ -1996,9 +1991,6 @@ instance Diagnostic TcRnMessage where
at_bndr = char '@' <> ppr tv_name
forall_bndr = text "forall" <+> ppr tv_name <> text "."
- TcRnMisplacedInvisPat tp -> mkSimpleDecorated $
- text "Invisible type pattern" <+> ppr tp <+> text "is not allowed here"
-
TcRnUnexpectedTypeSyntaxInTerms syntax -> mkSimpleDecorated $
text "Unexpected" <+> pprTypeSyntaxName syntax
@@ -2640,14 +2632,10 @@ instance Diagnostic TcRnMessage where
-> ErrorWithoutFlag
TcRnIllegalInvisibleTypePattern{}
-> ErrorWithoutFlag
- TcRnInvisPatWithNoForAll{}
- -> ErrorWithoutFlag
TcRnNamespacedFixitySigWithoutFlag{}
-> ErrorWithoutFlag
TcRnOutOfArityTyVar{}
-> ErrorWithoutFlag
- TcRnMisplacedInvisPat{}
- -> ErrorWithoutFlag
TcRnUnexpectedTypeSyntaxInTerms{}
-> ErrorWithoutFlag
@@ -3269,12 +3257,8 @@ instance Diagnostic TcRnMessage where
-> noHints
TcRnQualifiedBinder{}
-> noHints
- TcRnTypeApplicationsDisabled ty_app
- -> case ty_app of
- TypeApplication {}
- -> [suggestExtension LangExt.TypeApplications]
- TypeApplicationInPattern {}
- -> [suggestExtension LangExt.TypeAbstractions]
+ TcRnTypeApplicationsDisabled{}
+ -> [suggestExtension LangExt.TypeApplications]
TcRnInvalidRecordField{}
-> noHints
TcRnTupleTooLarge{}
@@ -3325,16 +3309,15 @@ instance Diagnostic TcRnMessage where
-> noHints
TcRnNamespacedWarningPragmaWithoutFlag{}
-> [suggestExtension LangExt.ExplicitNamespaces]
- TcRnIllegalInvisibleTypePattern{}
- -> [suggestExtension LangExt.TypeAbstractions]
- TcRnInvisPatWithNoForAll{}
- -> noHints
+ TcRnIllegalInvisibleTypePattern _ reason
+ -> case reason of
+ InvisPatWithoutFlag -> [suggestExtension LangExt.TypeAbstractions]
+ InvisPatNoForall -> noHints
+ InvisPatMisplaced -> noHints
TcRnNamespacedFixitySigWithoutFlag{}
-> [suggestExtension LangExt.ExplicitNamespaces]
TcRnOutOfArityTyVar{}
-> noHints
- TcRnMisplacedInvisPat{}
- -> noHints
TcRnUnexpectedTypeSyntaxInTerms syntax
-> [suggestExtension (typeSyntaxExtension syntax)]
=====================================
compiler/GHC/Tc/Errors/Types.hs
=====================================
@@ -102,7 +102,7 @@ module GHC.Tc.Errors.Types (
, RoleValidationFailedReason(..)
, DisabledClassExtension(..)
, TyFamsDisabledReason(..)
- , TypeApplication(..)
+ , BadInvisPatReason(..)
, HsTypeOrSigType(..)
, HsTyVarBndrExistentialFlag(..)
, TySynCycleTyCons
@@ -4013,7 +4013,8 @@ data TcRnMessage where
Test cases:
T12411, T12446, T15527, T16133, T18251c
-}
- TcRnTypeApplicationsDisabled :: !TypeApplication -- ^ what kind of type application is it?
+ TcRnTypeApplicationsDisabled :: !(HsType GhcPs)
+ -> !TypeOrKind
-> TcRnMessage
{-| TcRnInvalidRecordField is an error indicating that a record field was
@@ -4303,10 +4304,16 @@ data TcRnMessage where
-}
TcRnNamespacedWarningPragmaWithoutFlag :: WarnDecl GhcPs -> TcRnMessage
- {-| TcRnInvisPatWithNoForAll is an error raised when invisible type pattern
- is used without associated `forall` in types
+ {-| TcRnIllegalInvisibleTypePattern is an error raised when an invisible
+ type pattern, i.e. a pattern of the form `@p`, is rejected.
- Examples:
+ Example for InvisPatWithoutFlag:
+
+ {-# LANGUAGE NoTypeAbstractions #-}
+ id :: a -> a
+ id @t x = x
+
+ Examples for InvisPatNoForall:
f :: Int
f @t = 5
@@ -4314,22 +4321,27 @@ data TcRnMessage where
g :: [a -> a]
g = [\ @t x -> x :: t]
- Test cases: T17694c T17594d
- -}
- TcRnInvisPatWithNoForAll :: HsTyPat GhcRn -> TcRnMessage
-
- {-| TcRnIllegalInvisibleTypePattern is an error raised when invisible type pattern
- is used without the TypeAbstractions extension enabled
+ Examples for InvisPatMisplaced:
- Example:
+ f (smth, $(invisP (varT (newName "blah")))) = ...
- {-# LANGUAGE NoTypeAbstractions #-}
- id :: a -> a
- id @t x = x
+ g = do
+ $(invisP (varT (newName "blah"))) <- aciton1
+ ...
- Test cases: T17694b
- -}
- TcRnIllegalInvisibleTypePattern :: HsTyPat GhcPs -> TcRnMessage
+ Test cases:
+ T17694b -- InvisPatWithoutFlag
+ T17694c -- InvisPatNoForall
+ T17594d -- InvisPatNoForall
+ T24557a -- InvisPatMisplaced
+ T24557b -- InvisPatMisplaced
+ T24557c -- InvisPatMisplaced
+ T24557d -- InvisPatMisplaced
+ -}
+ TcRnIllegalInvisibleTypePattern
+ :: !(HsTyPat GhcRn) -- the rejected type pattern
+ -> !BadInvisPatReason -- the reason for rejection
+ -> TcRnMessage
{-| TcRnNamespacedFixitySigWithoutFlag is an error that occurs when
a namespace specifier is used in fixity signatures
@@ -4372,24 +4384,6 @@ data TcRnMessage where
-> Name -- ^ Type variable's name
-> TcRnMessage
- {- TcRnMisplacedInvisPat is an error raised when invisible @-pattern
- appears in invalid context (e.g. pattern in case of or in do-notation)
- or nested inside the pattern. Template Haskell seems to be the only
- source for this diagnostic.
-
- Examples:
-
- f (smth, $(invisP (varT (newName "blah")))) = ...
-
- g = do
- $(invisP (varT (newName "blah"))) <- aciton1
- ...
-
- Test cases: T24557a T24557b T24557c T24557d
-
- -}
- TcRnMisplacedInvisPat :: HsTyPat GhcPs -> TcRnMessage
-
{- TcRnUnexpectedTypeSyntaxInTerms is an error that occurs
when type syntax is used in terms without -XRequiredTypeArguments
extension enabled
@@ -6182,10 +6176,12 @@ data TyFamsDisabledReason
| TyFamsDisabledInstance !TyCon
deriving (Generic)
-data TypeApplication
- = TypeApplication !(HsType GhcPs) !TypeOrKind
- | TypeApplicationInPattern !(HsConPatTyArg GhcPs)
- deriving Generic
+-- | Why was an invisible pattern `@p` rejected?
+data BadInvisPatReason
+ = InvisPatWithoutFlag
+ | InvisPatNoForall
+ | InvisPatMisplaced
+ deriving (Generic)
-- | Either `HsType p` or `HsSigType p`.
--
=====================================
compiler/GHC/Tc/Gen/Pat.hs
=====================================
@@ -193,8 +193,9 @@ tcMatchPats match_ctxt pats pat_tys thing_inside
-- f @a t = ... -- loop (InvisPat{} : _) (ExpForAllPatTy (Bndr _ Required) : _)
-- 4. f :: forall {a}. Int
-- f @a t = ... -- loop (InvisPat{} : _) (ExpForAllPatTy (Bndr _ Inferred) : _)
- loop (L loc (InvisPat _ tp) : _) _ =
- failAt (locA loc) (TcRnInvisPatWithNoForAll tp)
+ loop (L loc (InvisPat _ tp) : _) _
+ = setSrcSpanA loc $
+ failWithTc (TcRnIllegalInvisibleTypePattern tp InvisPatNoForall)
-- ExpFunPatTy: expecting a value pattern
-- tc_lpat will error if it sees a @t type pattern
=====================================
compiler/GHC/Types/Error/Codes.hs
=====================================
@@ -681,20 +681,19 @@ type family GhcDiagnosticCode c = n | n -> c where
GhcDiagnosticCode "TcRnInvalidDefaultedTyVar" = 45625
GhcDiagnosticCode "TcRnIllegalTermLevelUse" = 01928
GhcDiagnosticCode "TcRnNamespacedWarningPragmaWithoutFlag" = 14995
- GhcDiagnosticCode "TcRnInvisPatWithNoForAll" = 14964
- GhcDiagnosticCode "TcRnIllegalInvisibleTypePattern" = 78249
GhcDiagnosticCode "TcRnNamespacedFixitySigWithoutFlag" = 78534
GhcDiagnosticCode "TcRnOutOfArityTyVar" = 84925
- GhcDiagnosticCode "TcRnMisplacedInvisPat" = 11983
GhcDiagnosticCode "TcRnIllformedTypePattern" = 88754
GhcDiagnosticCode "TcRnIllegalTypePattern" = 70206
GhcDiagnosticCode "TcRnIllformedTypeArgument" = 29092
GhcDiagnosticCode "TcRnIllegalTypeExpr" = 35499
GhcDiagnosticCode "TcRnUnexpectedTypeSyntaxInTerms" = 31244
+ GhcDiagnosticCode "TcRnTypeApplicationsDisabled" = 23482
- -- TcRnTypeApplicationsDisabled
- GhcDiagnosticCode "TypeApplication" = 23482
- GhcDiagnosticCode "TypeApplicationInPattern" = 17916
+ -- TcRnIllegalInvisibleTypePattern
+ GhcDiagnosticCode "InvisPatWithoutFlag" = 78249
+ GhcDiagnosticCode "InvisPatNoForall" = 14964
+ GhcDiagnosticCode "InvisPatMisplaced" = 11983
-- PatSynInvalidRhsReason
GhcDiagnosticCode "PatSynNotInvertible" = 69317
@@ -1001,6 +1000,7 @@ type family GhcDiagnosticCode c = n | n -> c where
GhcDiagnosticCode "TcRnHsigNoIface" = Outdated 93010
GhcDiagnosticCode "TcRnInterfaceLookupError" = Outdated 52243
GhcDiagnosticCode "TcRnForallIdentifier" = Outdated 64088
+ GhcDiagnosticCode "TypeApplicationInPattern" = Outdated 17916
{- *********************************************************************
* *
@@ -1078,7 +1078,7 @@ type family ConRecursInto con where
ConRecursInto "TcRnUnusedImport" = 'Just UnusedImportReason
ConRecursInto "TcRnNonCanonicalDefinition" = 'Just NonCanonicalDefinition
ConRecursInto "TcRnIllegalInstance" = 'Just IllegalInstanceReason
- ConRecursInto "TcRnTypeApplicationsDisabled" = 'Just TypeApplication
+ ConRecursInto "TcRnIllegalInvisibleTypePattern" = 'Just BadInvisPatReason
-- Illegal instance reasons
ConRecursInto "IllegalClassInstance" = 'Just IllegalClassInstanceReason
=====================================
testsuite/tests/rename/should_fail/T17594b.hs
=====================================
@@ -1,8 +1,6 @@
-{-# LANGUAGE ScopedTypeVariables, ImpredicativeTypes, TemplateHaskell, NoTypeAbstractions #-}
+{-# LANGUAGE ScopedTypeVariables, ImpredicativeTypes, NoTypeAbstractions #-}
module T17594b where
-import qualified Language.Haskell.TH as TH
-
id1 :: forall a. a -> a
id1 @t x = x
@@ -32,6 +30,3 @@ id8 = (\ @t x -> x, id1)
id9 :: [forall a. a -> a]
id9 = [\ @t x -> x, id1, id3, id5, id6, fst id8, snd id8]
-
-id10 :: a -> a
-id10 @($(TH.varT (TH.mkName "t"))) x = x :: t
=====================================
testsuite/tests/rename/should_fail/T17594b.stderr
=====================================
@@ -1,105 +1,100 @@
-
-T17594b.hs:7:5: error: [GHC-78249]
- Illegal invisible type pattern: t
+T17594b.hs:5:5: error: [GHC-78249]
+ Illegal invisible type pattern: @t
Suggested fix:
Perhaps you intended to use the ‘TypeAbstractions’ extension
-T17594b.hs:10:5: error: [GHC-78249]
- Illegal invisible type pattern: t
+T17594b.hs:8:5: error: [GHC-78249]
+ Illegal invisible type pattern: @t
Suggested fix:
Perhaps you intended to use the ‘TypeAbstractions’ extension
-T17594b.hs:14:5: error: [GHC-78249]
- Illegal invisible type pattern: t
+T17594b.hs:12:5: error: [GHC-78249]
+ Illegal invisible type pattern: @t
Suggested fix:
Perhaps you intended to use the ‘TypeAbstractions’ extension
-T17594b.hs:17:5: error: [GHC-78249]
- Illegal invisible type pattern: t1
+T17594b.hs:15:5: error: [GHC-78249]
+ Illegal invisible type pattern: @t1
Suggested fix:
Perhaps you intended to use the ‘TypeAbstractions’ extension
-T17594b.hs:17:9: error: [GHC-78249]
- Illegal invisible type pattern: t2
+T17594b.hs:15:9: error: [GHC-78249]
+ Illegal invisible type pattern: @t2
Suggested fix:
Perhaps you intended to use the ‘TypeAbstractions’ extension
-T17594b.hs:17:13: error: [GHC-78249]
- Illegal invisible type pattern: t3
+T17594b.hs:15:13: error: [GHC-78249]
+ Illegal invisible type pattern: @t3
Suggested fix:
Perhaps you intended to use the ‘TypeAbstractions’ extension
-T17594b.hs:17:26: error: [GHC-78249]
- Illegal invisible type pattern: t4
+T17594b.hs:15:26: error: [GHC-78249]
+ Illegal invisible type pattern: @t4
Suggested fix:
Perhaps you intended to use the ‘TypeAbstractions’ extension
-T17594b.hs:17:30: error: [GHC-78249]
- Illegal invisible type pattern: t5
+T17594b.hs:15:30: error: [GHC-78249]
+ Illegal invisible type pattern: @t5
Suggested fix:
Perhaps you intended to use the ‘TypeAbstractions’ extension
-T17594b.hs:17:34: error: [GHC-78249]
- Illegal invisible type pattern: t6
+T17594b.hs:15:34: error: [GHC-78249]
+ Illegal invisible type pattern: @t6
Suggested fix:
Perhaps you intended to use the ‘TypeAbstractions’ extension
-T17594b.hs:20:10: error: [GHC-78249]
- Illegal invisible type pattern: t
+T17594b.hs:18:10: error: [GHC-78249]
+ Illegal invisible type pattern: @t
Suggested fix:
Perhaps you intended to use the ‘TypeAbstractions’ extension
-T17594b.hs:22:19: error: [GHC-78249]
- Illegal invisible type pattern: t
+T17594b.hs:20:19: error: [GHC-78249]
+ Illegal invisible type pattern: @t
Suggested fix:
Perhaps you intended to use the ‘TypeAbstractions’ extension
-T17594b.hs:25:9: error: [GHC-78249]
- Illegal invisible type pattern: t
+T17594b.hs:23:9: error: [GHC-78249]
+ Illegal invisible type pattern: @t
Suggested fix:
Perhaps you intended to use the ‘TypeAbstractions’ extension
-T17594b.hs:28:5: error: [GHC-78249]
- Illegal invisible type pattern: t1
+T17594b.hs:26:5: error: [GHC-78249]
+ Illegal invisible type pattern: @t1
Suggested fix:
Perhaps you intended to use the ‘TypeAbstractions’ extension
-T17594b.hs:28:9: error: [GHC-78249]
- Illegal invisible type pattern: t2
+T17594b.hs:26:9: error: [GHC-78249]
+ Illegal invisible type pattern: @t2
Suggested fix:
Perhaps you intended to use the ‘TypeAbstractions’ extension
-T17594b.hs:28:31: error: [GHC-78249]
- Illegal invisible type pattern: t3
+T17594b.hs:26:31: error: [GHC-78249]
+ Illegal invisible type pattern: @t3
Suggested fix:
Perhaps you intended to use the ‘TypeAbstractions’ extension
-T17594b.hs:28:57: error: [GHC-78249]
- Illegal invisible type pattern: t4
+T17594b.hs:26:57: error: [GHC-78249]
+ Illegal invisible type pattern: @t4
Suggested fix:
Perhaps you intended to use the ‘TypeAbstractions’ extension
-T17594b.hs:28:61: error: [GHC-78249]
- Illegal invisible type pattern: t5
+T17594b.hs:26:61: error: [GHC-78249]
+ Illegal invisible type pattern: @t5
Suggested fix:
Perhaps you intended to use the ‘TypeAbstractions’ extension
-T17594b.hs:28:70: error: [GHC-78249]
- Illegal invisible type pattern: t6
+T17594b.hs:26:70: error: [GHC-78249]
+ Illegal invisible type pattern: @t6
Suggested fix:
Perhaps you intended to use the ‘TypeAbstractions’ extension
-T17594b.hs:31:10: error: [GHC-78249]
- Illegal invisible type pattern: t
+T17594b.hs:29:10: error: [GHC-78249]
+ Illegal invisible type pattern: @t
Suggested fix:
Perhaps you intended to use the ‘TypeAbstractions’ extension
-T17594b.hs:34:10: error: [GHC-78249]
- Illegal invisible type pattern: t
+T17594b.hs:32:10: error: [GHC-78249]
+ Illegal invisible type pattern: @t
Suggested fix:
Perhaps you intended to use the ‘TypeAbstractions’ extension
-T17594b.hs:37:6: error: [GHC-78249]
- Illegal invisible type pattern: ($(TH.varT (TH.mkName "t")))
- Suggested fix:
- Perhaps you intended to use the ‘TypeAbstractions’ extension
=====================================
testsuite/tests/rename/should_fail/T17594b_th.hs
=====================================
@@ -0,0 +1,9 @@
+{-# LANGUAGE ScopedTypeVariables, ImpredicativeTypes, NoTypeAbstractions #-}
+{-# LANGUAGE TemplateHaskell #-}
+
+module T17594b_th where
+
+import qualified Language.Haskell.TH as TH
+
+id10 :: a -> a
+id10 @($(TH.varT (TH.mkName "t"))) x = x :: t
=====================================
testsuite/tests/rename/should_fail/T17594b_th.stderr
=====================================
@@ -0,0 +1,5 @@
+T17594b_th.hs:9:6: error: [GHC-78249]
+ Illegal invisible type pattern: @(t)
+ Suggested fix:
+ Perhaps you intended to use the ‘TypeAbstractions’ extension
+
=====================================
testsuite/tests/rename/should_fail/T22478e.stderr
=====================================
@@ -1,11 +1,15 @@
+T22478e.hs:6:4: error: [GHC-78249]
+ Illegal invisible type pattern: @[a, b]
+ Suggested fix:
+ Perhaps you intended to use the ‘TypeAbstractions’ extension
T22478e.hs:6:4: error: [GHC-68567]
Illegal type: ‘[a, b]’
Suggested fix:
Perhaps you intended to use the ‘DataKinds’ extension (implied by ‘UnliftedDatatypes’)
-T22478e.hs:6:4: error: [GHC-17916]
- Illegal visible type application in a pattern: @[a, b]
+T22478e.hs:7:4: error: [GHC-78249]
+ Illegal invisible type pattern: @1
Suggested fix:
Perhaps you intended to use the ‘TypeAbstractions’ extension
@@ -14,8 +18,8 @@ T22478e.hs:7:4: error: [GHC-68567]
Suggested fix:
Perhaps you intended to use the ‘DataKinds’ extension (implied by ‘UnliftedDatatypes’)
-T22478e.hs:7:4: error: [GHC-17916]
- Illegal visible type application in a pattern: @1
+T22478e.hs:8:4: error: [GHC-78249]
+ Illegal invisible type pattern: @(t @k)
Suggested fix:
Perhaps you intended to use the ‘TypeAbstractions’ extension
@@ -24,13 +28,8 @@ T22478e.hs:8:4: error: [GHC-23482]
Suggested fix:
Perhaps you intended to use the ‘TypeApplications’ extension
-T22478e.hs:8:4: error: [GHC-17916]
- Illegal visible type application in a pattern: @(t @k)
- Suggested fix:
- Perhaps you intended to use the ‘TypeAbstractions’ extension
-
-T22478e.hs:9:4: error: [GHC-17916]
- Illegal visible type application in a pattern: @(t :: k)
+T22478e.hs:9:4: error: [GHC-78249]
+ Illegal invisible type pattern: @(t :: k)
Suggested fix:
Perhaps you intended to use the ‘TypeAbstractions’ extension
@@ -40,13 +39,18 @@ T22478e.hs:9:13: error: [GHC-49378]
Suggested fix:
Perhaps you intended to use the ‘KindSignatures’ extension (implied by ‘TypeFamilies’ and ‘PolyKinds’)
+T22478e.hs:10:4: error: [GHC-78249]
+ Illegal invisible type pattern: @('(a, b))
+ Suggested fix:
+ Perhaps you intended to use the ‘TypeAbstractions’ extension
+
T22478e.hs:10:4: error: [GHC-68567]
Illegal type: ‘'(a, b)’
Suggested fix:
Perhaps you intended to use the ‘DataKinds’ extension (implied by ‘UnliftedDatatypes’)
-T22478e.hs:10:4: error: [GHC-17916]
- Illegal visible type application in a pattern: @('(a, b))
+T22478e.hs:11:4: error: [GHC-78249]
+ Illegal invisible type pattern: @"str"
Suggested fix:
Perhaps you intended to use the ‘TypeAbstractions’ extension
@@ -55,8 +59,8 @@ T22478e.hs:11:4: error: [GHC-68567]
Suggested fix:
Perhaps you intended to use the ‘DataKinds’ extension (implied by ‘UnliftedDatatypes’)
-T22478e.hs:11:4: error: [GHC-17916]
- Illegal visible type application in a pattern: @"str"
+T22478e.hs:12:4: error: [GHC-78249]
+ Illegal invisible type pattern: @'c'
Suggested fix:
Perhaps you intended to use the ‘TypeAbstractions’ extension
@@ -65,8 +69,8 @@ T22478e.hs:12:4: error: [GHC-68567]
Suggested fix:
Perhaps you intended to use the ‘DataKinds’ extension (implied by ‘UnliftedDatatypes’)
-T22478e.hs:12:4: error: [GHC-17916]
- Illegal visible type application in a pattern: @'c'
+T22478e.hs:13:4: error: [GHC-78249]
+ Illegal invisible type pattern: @'True
Suggested fix:
Perhaps you intended to use the ‘TypeAbstractions’ extension
@@ -75,7 +79,3 @@ T22478e.hs:13:4: error: [GHC-68567]
Suggested fix:
Perhaps you intended to use the ‘DataKinds’ extension (implied by ‘UnliftedDatatypes’)
-T22478e.hs:13:4: error: [GHC-17916]
- Illegal visible type application in a pattern: @'True
- Suggested fix:
- Perhaps you intended to use the ‘TypeAbstractions’ extension
=====================================
testsuite/tests/rename/should_fail/all.T
=====================================
@@ -226,7 +226,8 @@ test('T25056', [extra_files(['T25056a.hs', 'T25056b.hs'])], multimod_compile_fai
test('Or3', normal, compile_fail, [''])
test('T23570', [extra_files(['T23570_aux.hs'])], multimod_compile_fail, ['T23570', '-v0'])
test('T23570b', [extra_files(['T23570_aux.hs'])], multimod_compile, ['T23570b', '-v0'])
-test('T17594b', req_th, compile_fail, [''])
+test('T17594b', normal, compile_fail, [''])
+test('T17594b_th', req_th, compile_fail, [''])
test('T14032c', normal, compile_fail, [''])
test('T14032f', normal, compile_fail, [''])
test('T23501_fail', normal, compile_fail, [''])
=====================================
testsuite/tests/th/T24557a.stderr
=====================================
@@ -1,3 +1,4 @@
-
T24557a.hs:7:2: error: [GHC-11983]
- Invisible type pattern pat is not allowed here
+ Illegal invisible type pattern: @pat
+ An invisible type pattern must occur in an argument position.
+
=====================================
testsuite/tests/th/T24557b.stderr
=====================================
@@ -1,3 +1,4 @@
-
T24557b.hs:7:11: error: [GHC-11983]
- Invisible type pattern pat is not allowed here
+ Illegal invisible type pattern: @pat
+ An invisible type pattern must occur in an argument position.
+
=====================================
testsuite/tests/th/T24557c.stderr
=====================================
@@ -1,3 +1,4 @@
-
T24557c.hs:8:4: error: [GHC-11983]
- Invisible type pattern pat is not allowed here
+ Illegal invisible type pattern: @pat
+ An invisible type pattern must occur in an argument position.
+
=====================================
testsuite/tests/th/T24557d.stderr
=====================================
@@ -1,3 +1,4 @@
-
T24557d.hs:12:4: error: [GHC-11983]
- Invisible type pattern t is not allowed here
+ Illegal invisible type pattern: @t
+ An invisible type pattern must occur in an argument position.
+
=====================================
testsuite/tests/typecheck/should_fail/T17594c.stderr
=====================================
@@ -1,6 +1,7 @@
-
T17594c.hs:5:10: error: [GHC-14964]
- • Invisible type pattern t has no associated forall
+ • Illegal invisible type pattern: @t
+ An invisible type pattern must be checked against a forall.
• In the expression: \ @t -> undefined :: t
In the expression: [\ @t -> undefined :: t]
In an equation for ‘id'’: id' = [\ @t -> undefined :: t]
+
=====================================
testsuite/tests/typecheck/should_fail/T17594d.stderr
=====================================
@@ -1,4 +1,5 @@
-
T17594d.hs:8:5: error: [GHC-14964]
- • Invisible type pattern t has no associated forall
+ • Illegal invisible type pattern: @t
+ An invisible type pattern must be checked against a forall.
• In an equation for ‘id'’: id' @t x = x :: t
+
=====================================
testsuite/tests/typecheck/should_fail/T17594g.stderr
=====================================
@@ -1,4 +1,5 @@
-
T17594g.hs:6:5: error: [GHC-14964]
- • Invisible type pattern a has no associated forall
+ • Illegal invisible type pattern: @a
+ An invisible type pattern must be checked against a forall.
• In an equation for ‘id'’: id' @a x = x
+
=====================================
testsuite/tests/typecheck/should_fail/T19109.stderr
=====================================
@@ -1,5 +1,5 @@
-
-T19109.hs:6:4: error: [GHC-17916]
- Illegal visible type application in a pattern: @Int
+T19109.hs:6:4: error: [GHC-78249]
+ Illegal invisible type pattern: @Int
Suggested fix:
Perhaps you intended to use the ‘TypeAbstractions’ extension
+
=====================================
testsuite/tests/typecheck/should_fail/T23776.stderr
=====================================
@@ -1,5 +1,5 @@
-T23776.hs:8:6: error: [GHC-17916]
- Illegal visible type application in a pattern: @b
+T23776.hs:8:6: error: [GHC-78249]
+ Illegal invisible type pattern: @b
Suggested fix:
Perhaps you intended to use the ‘TypeAbstractions’ extension
View it on GitLab: https://gitlab.haskell.org/ghc/ghc/-/commit/6acaff2b8094d20ff65d459dcc086f20fe0c0bc1
--
View it on GitLab: https://gitlab.haskell.org/ghc/ghc/-/commit/6acaff2b8094d20ff65d459dcc086f20fe0c0bc1
You're receiving this email because of your account on gitlab.haskell.org.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.haskell.org/pipermail/ghc-commits/attachments/20250226/780a39ca/attachment-0001.html>
More information about the ghc-commits
mailing list