[Git][ghc/ghc][wip/andreask/interpreter_primops] 2 commits: testsuite: Run foundation test in ghci and ghci-opt ways

[Matthew Pickering (@mpickering)]

Matthew Pickering pushed to branch wip/andreask/interpreter_primops at Glasgow Haskell Compiler / GHC


Commits:
ab8afc57 by Matthew Pickering at 2025-02-24T10:59:25+00:00
testsuite: Run foundation test in ghci and ghci-opt ways

Running this test using optimised core is a good test for implementing
numeric primops in the interpreter.

This test currently fails in `ghci-opt` way when breakpoints are
enabled so they are disabled for now.

- - - - -
029013a0 by Matthew Pickering at 2025-02-24T11:07:05+00:00
Unused variables

- - - - -


2 changed files:

- compiler/GHC/StgToByteCode.hs
- testsuite/tests/numeric/should_run/all.T


Changes:

=====================================
compiler/GHC/StgToByteCode.hs
=====================================
@@ -934,11 +934,11 @@ terribleNoOp
     -> BCInstr                  -- The operator
     -> [StgArg]                 -- Args, in *reverse* order (must be fully applied)
     -> BcM BCInstrList
-terribleNoOp orig_d _ p op_inst args = app_code
+terribleNoOp orig_d _ p _ args = app_code
   where
     app_code = do
         profile <- getProfile
-        let platform = profilePlatform profile
+        let --platform = profilePlatform profile
 
             non_voids =
                 addArgReps (assertNonVoidStgArgs args)
@@ -951,7 +951,7 @@ terribleNoOp orig_d _ p op_inst args = app_code
                     (FieldOff a _) -> pushConstrAtom d p (fromNonVoid a)
                 more_push_code <- do_pushery (d + arg_bytes) args
                 return (push `appOL` more_push_code)
-            do_pushery !d [] = do
+            do_pushery !_d [] = do
                 -- let !n_arg_words = bytesToWords platform (d - orig_d)
                 return (nilOL)
 
@@ -970,7 +970,7 @@ mkPrimOpCode orig_d _ p op_inst args = app_code
   where
     app_code = do
         profile <- getProfile
-        let platform = profilePlatform profile
+        let _platform = profilePlatform profile
 
             non_voids =
                 addArgReps (assertNonVoidStgArgs args)
@@ -983,7 +983,7 @@ mkPrimOpCode orig_d _ p op_inst args = app_code
                     (FieldOff a _) -> pushConstrAtom d p (fromNonVoid a)
                 more_push_code <- do_pushery (d + arg_bytes) args
                 return (push `appOL` more_push_code)
-            do_pushery !d [] = do
+            do_pushery !_d [] = do
                 -- let !n_arg_words = bytesToWords platform (d - orig_d)
                 return (unitOL op_inst)
 


=====================================
testsuite/tests/numeric/should_run/all.T
=====================================
@@ -82,7 +82,7 @@ test('IntegerToFloat', normal, compile_and_run, [''])
 test('T20291', normal, compile_and_run, [''])
 test('T22282', normal, compile_and_run, [''])
 test('T22671', js_fragile(24259), compile_and_run, [''])
-test('foundation', [when(js_arch(), run_timeout_multiplier(2)), js_fragile(24259)], compile_and_run, ['-O -package transformers'])
+test('foundation', [when(js_arch(), run_timeout_multiplier(2)), js_fragile(24259), extra_ways(['optasm','ghci','ghci-opt'])], compile_and_run, ['-package transformers -fno-break-points'])
 test('T24066', normal, compile_and_run, [''])
 test('div01', normal, compile_and_run, [''])
 test('T24245', normal, compile_and_run, [''])



View it on GitLab: https://gitlab.haskell.org/ghc/ghc/-/compare/64939899a0042662d1059953fa61a33377674d8f...029013a01719f0562cfab8c15ff5cd5ae63f878a

-- 
View it on GitLab: https://gitlab.haskell.org/ghc/ghc/-/compare/64939899a0042662d1059953fa61a33377674d8f...029013a01719f0562cfab8c15ff5cd5ae63f878a
You're receiving this email because of your account on gitlab.haskell.org.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.haskell.org/pipermail/ghc-commits/attachments/20250224/a395ed4c/attachment-0001.html>