[Git][ghc/ghc][wip/wasm-perf-notes] ci: Push perf notes from wasm jobs

Matthew Pickering (@mpickering) gitlab at gitlab.haskell.org
Thu Sep 26 19:58:53 UTC 2024



Matthew Pickering pushed to branch wip/wasm-perf-notes at Glasgow Haskell Compiler / GHC


Commits:
c63f910e by Matthew Pickering at 2024-09-26T20:58:45+01:00
ci: Push perf notes from wasm jobs

It was observed in #25299 that we were failing to push performance
numbers from the wasm jobs.

In future we might want to remove this ad-hoc check but for now it's
easier to add another special case.

Towards #25299

- - - - -


1 changed file:

- .gitlab/ci.sh


Changes:

=====================================
.gitlab/ci.sh
=====================================
@@ -431,7 +431,9 @@ function push_perf_notes() {
     return
   fi
 
-  if [ -n "${CROSS_TARGET:-}" ] && [ "${CROSS_EMULATOR:-}" != "js-emulator" ]; then
+  # TODO: Remove this check, see #25299
+  # It is easy to forget to update this when testing a new cross platform
+  if [[ -n "${CROSS_TARGET:-}" ]] && [[ "${CROSS_TARGET:-}" != *"javascript"* ]] && [[ "${CROSS_TARGET:-}" != *"wasm"* ]]; then
     info "Can't test cross-compiled build."
     return
   fi



View it on GitLab: https://gitlab.haskell.org/ghc/ghc/-/commit/c63f910e966a4b5211bcb3a5f59b00379ba4c415

-- 
View it on GitLab: https://gitlab.haskell.org/ghc/ghc/-/commit/c63f910e966a4b5211bcb3a5f59b00379ba4c415
You're receiving this email because of your account on gitlab.haskell.org.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.haskell.org/pipermail/ghc-commits/attachments/20240926/35141ffb/attachment.html>


More information about the ghc-commits mailing list