[Git][ghc/ghc][wip/jade/ast] Apply 2 suggestion(s) to 2 file(s)

[Hassan Al-Awwadi (@hassan.awwadi)]

Hassan Al-Awwadi pushed to branch wip/jade/ast at Glasgow Haskell Compiler / GHC


Commits:
52065624 by Hassan Al-Awwadi at 2024-09-25T16:19:11+00:00
Apply 2 suggestion(s) to 2 file(s)

Co-authored-by: Rodrigo Mesquita <rodrigo.m.mesquita at gmail.com>
- - - - -


2 changed files:

- compiler/GHC/Rename/Pat.hs
- compiler/Language/Haskell/Syntax/Type.hs


Changes:

=====================================
compiler/GHC/Rename/Pat.hs
=====================================
@@ -259,42 +259,6 @@ newPatName (LetMk is_top fix_env) rdr_name
                        NotTopLevel -> newLocalBndrRn rdr_name
                        TopLevel    -> newTopSrcBinder rdr_name
            ; bindLocalNames [name] $
-                 -- Do *not* use bindLocalNameFV here;
-                 -- Do *not* use bindLocalNameFV here;
-                 -- Do *not* use bindLocalNameFV here;
-                 -- Do *not* use bindLocalNameFV here;
-                 --   see Note [View pattern usage]
-                 --   see Note [View pattern usage]
-                 --   see Note [View pattern usage]
-                 --   see Note [View pattern usage]
-                 -- For the TopLevel case
-                 -- For the TopLevel case
-                 -- For the TopLevel case
-                 -- For the TopLevel case
-                 --   see Note [bindLocalNames for an External name]
-                 --   see Note [bindLocalNames for an External name]
-                 --   see Note [bindLocalNames for an External name]
-                 --   see Note [bindLocalNames for an External name]
-
-                 -- Do *not* use bindLocalNameFV here;
-
-                 -- Do *not* use bindLocalNameFV here;
-                 --   see Note [View pattern usage]
-                 --   see Note [View pattern usage]
-                 -- For the TopLevel case
-                 -- For the TopLevel case
-                 --   see Note [bindLocalNames for an External name]
-                 --   see Note [bindLocalNames for an External nam
-
-                 -- Do *not* use bindLocalNameFV here;
-                 -- Do *not* use bindLocalNameFV here;
-                 --   see Note [View pattern usage]
-                 --   see Note [View pattern usage]
-                 -- For the TopLevel case
-                 -- For the TopLevel case
-                 --   see Note [bindLocalNames for an External name]
-                 --   see Note [bindLocalNames for an External name]
-
                  -- Do *not* use bindLocalNameFV here;
                  --   see Note [View pattern usage]
                  -- For the TopLevel case


=====================================
compiler/Language/Haskell/Syntax/Type.hs
=====================================
@@ -1266,8 +1266,14 @@ The SrcSpan is the span of the original HsPar
 *                                                                      *
 ************************************************************************
 -}
+-- | Located Update Field Occurrence
 type LUpdFieldOcc pass = XRec pass (UpdFieldOcc pass)
 
+-- | An update field occurrence is a field occurrence that
+-- occurs in an update position (such as @x{field=...}@).
+--
+-- We differentiate between the two since there may be additional information concerning the update field.
+-- In particular, in GHC, an update field occurrence *may* be ambiguous, unlike other field occurrences.
 data UpdFieldOcc pass
   = UpdFieldOcc {
     ufoExt   :: XCUpdFieldOcc pass,



View it on GitLab: https://gitlab.haskell.org/ghc/ghc/-/commit/52065624c9d98a23bb5500ca361413b109aae9a3

-- 
View it on GitLab: https://gitlab.haskell.org/ghc/ghc/-/commit/52065624c9d98a23bb5500ca361413b109aae9a3
You're receiving this email because of your account on gitlab.haskell.org.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.haskell.org/pipermail/ghc-commits/attachments/20240925/e65d7de5/attachment-0001.html>