[Git][ghc/ghc][wip/T24807] base: Propagate `error` CallStack to thrown exception

Rodrigo Mesquita (@alt-romes) gitlab at gitlab.haskell.org
Thu Sep 19 10:00:23 UTC 2024



Rodrigo Mesquita pushed to branch wip/T24807 at Glasgow Haskell Compiler / GHC


Commits:
5963b8c2 by Ben Gamari at 2024-09-19T11:00:10+01:00
base: Propagate `error` CallStack to thrown exception

Previously `errorCallWithCallStackException` failed to propagate its
`CallStack` argument, which represents the call-chain of the preceding
`error` call, to the exception that it returned. Consequently, the
call-stack of `error` calls were quite useless.

Unfortunately, this is the second time that I have fixed this but it
seems the first must have been lost in rebasing.

Fixes #24807.

- - - - -


30 changed files:

- libraries/base/tests/T19288.stderr
- + libraries/base/tests/T24807.hs
- + libraries/base/tests/T24807.stderr
- libraries/base/tests/all.T
- libraries/ghc-internal/src/GHC/Internal/Exception.hs
- testsuite/tests/arityanal/should_run/T21694a.stderr
- testsuite/tests/arityanal/should_run/T24296.stderr
- testsuite/tests/codeGen/should_run/T16846.stderr
- testsuite/tests/codeGen/should_run/T5626.stderr
- testsuite/tests/codeGen/should_run/cgrun025.stderr
- testsuite/tests/codeGen/should_run/cgrun045.stderr
- testsuite/tests/codeGen/should_run/cgrun051.stderr
- testsuite/tests/codeGen/should_run/cgrun059.stderr
- testsuite/tests/concurrent/should_run/T13330.stderr
- testsuite/tests/concurrent/should_run/conc021.stderr
- testsuite/tests/deSugar/should_run/Or5.stderr
- testsuite/tests/deSugar/should_run/T11193.stderr
- testsuite/tests/deSugar/should_run/T11572.stderr
- testsuite/tests/deSugar/should_run/T11601.stderr
- testsuite/tests/dmdanal/should_run/T12368.stderr
- testsuite/tests/dmdanal/should_run/T12368a.stderr
- testsuite/tests/dmdanal/should_run/T23208.stderr
- testsuite/tests/dmdanal/should_run/strun002.stderr
- testsuite/tests/driver/multipleHomeUnits/multipleHomeUnits_callstack.stderr
- testsuite/tests/ffi/should_run/ffi008.stderr
- testsuite/tests/hpc/simple/tixs/T10529a.stderr
- testsuite/tests/hpc/simple/tixs/T10529b.stderr
- testsuite/tests/hpc/simple/tixs/T10529c.stderr
- testsuite/tests/rebindable/RebindableFailA.stderr
- testsuite/tests/safeHaskell/safeLanguage/SafeLang09.stderr


The diff was not included because it is too large.


View it on GitLab: https://gitlab.haskell.org/ghc/ghc/-/commit/5963b8c2de54d397f1c860e011951109f9c95163

-- 
View it on GitLab: https://gitlab.haskell.org/ghc/ghc/-/commit/5963b8c2de54d397f1c860e011951109f9c95163
You're receiving this email because of your account on gitlab.haskell.org.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.haskell.org/pipermail/ghc-commits/attachments/20240919/b156ea98/attachment.html>


More information about the ghc-commits mailing list