[Git][ghc/ghc][wip/supersven/ghc-master-riscv-ncg] Apply typo/grammar suggestions
Sven Tennie (@supersven)
gitlab at gitlab.haskell.org
Thu Sep 5 10:31:56 UTC 2024
Sven Tennie pushed to branch wip/supersven/ghc-master-riscv-ncg at Glasgow Haskell Compiler / GHC
Commits:
5856aa6e by Sven Tennie at 2024-09-05T10:31:53+00:00
Apply typo/grammar suggestions
- - - - -
3 changed files:
- compiler/GHC/CmmToAsm/RV64/CodeGen.hs
- compiler/GHC/CmmToAsm/RV64/Instr.hs
- compiler/GHC/CmmToAsm/RV64/Ppr.hs
Changes:
=====================================
compiler/GHC/CmmToAsm/RV64/CodeGen.hs
=====================================
@@ -163,7 +163,7 @@ ann doc instr {- debugIsOn -} = ANN doc instr
-- going back to the exact CmmExpr representation can be laborious and adds
-- indirections to find the matches that lead to the assembly.
--
--- An improvement oculd be to have
+-- An improvement could be to have
--
-- (pprExpr genericPlatform e) <> parens (text. show e)
--
=====================================
compiler/GHC/CmmToAsm/RV64/Instr.hs
=====================================
@@ -267,7 +267,7 @@ patchJumpInstr instr patchF =
-- single load/store instruction. There are offsets to sp (not to be confused
-- with STG's SP!) which need a register to be calculated.
--
--- Using sp to compute the offset will violate assumptions about the stack pointer
+-- Using sp to compute the offset would violate assumptions about the stack pointer
-- pointing to the top of the stack during signal handling. As we can't force
-- every signal to use its own stack, we have to ensure that the stack pointer
-- always points to the top of the stack, and we can't use it for computation.
=====================================
compiler/GHC/CmmToAsm/RV64/Ppr.hs
=====================================
@@ -222,7 +222,7 @@ pprGloblDecl platform lbl
-- (PLT)s, and thus the lookup wouldn't point to the function, but into the
-- jump table.
--
--- Fun fact: The LLVMMangler exists to patch this issue su on the LLVM side as
+-- Fun fact: The LLVMMangler exists to patch this issue on the LLVM side as
-- well.
pprLabelType' :: (IsLine doc) => Platform -> CLabel -> doc
pprLabelType' platform lbl =
View it on GitLab: https://gitlab.haskell.org/ghc/ghc/-/commit/5856aa6ec7f5673f227558d4378aecba1b692dd0
--
View it on GitLab: https://gitlab.haskell.org/ghc/ghc/-/commit/5856aa6ec7f5673f227558d4378aecba1b692dd0
You're receiving this email because of your account on gitlab.haskell.org.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.haskell.org/pipermail/ghc-commits/attachments/20240905/2df69320/attachment-0001.html>
More information about the ghc-commits
mailing list