[Git][ghc/ghc][wip/marge_bot_batch_merge_job] 2 commits: Changed import from Ghc. module to L.H.S module

Marge Bot (@marge-bot) gitlab at gitlab.haskell.org
Tue Oct 15 18:54:29 UTC 2024



Marge Bot pushed to branch wip/marge_bot_batch_merge_job at Glasgow Haskell Compiler / GHC


Commits:
e59fe5c6 by Hassan Al-Awwadi at 2024-10-15T08:25:33+00:00
Changed import from Ghc.  module to L.H.S module

Progresses #21592

For some reason we still imported GHC.Types.Fixity when the definitino of Fixity and LexicalFixity have already been moved to Language.Haskell.Syntax.Basic. This fixes that for

- - - - -
1b9f398a by Simon Peyton Jones at 2024-10-15T14:54:18-04:00
Add a release-notes entry for -Wincomplete-record-selectors

- - - - -


3 changed files:

- compiler/Language/Haskell/Syntax/Binds.hs
- compiler/Language/Haskell/Syntax/Decls.hs
- docs/users_guide/9.14.1-notes.rst


Changes:

=====================================
compiler/Language/Haskell/Syntax/Binds.hs
=====================================
@@ -31,10 +31,9 @@ import {-# SOURCE #-} Language.Haskell.Syntax.Pat
 
 import Language.Haskell.Syntax.Extension
 import Language.Haskell.Syntax.Type
+import Language.Haskell.Syntax.Basic ( Fixity )
 
-import GHC.Types.Fixity (Fixity)
 import GHC.Types.Basic (InlinePragma)
-
 import GHC.Data.BooleanFormula (LBooleanFormula)
 import GHC.Types.SourceText (StringLiteral)
 


=====================================
compiler/Language/Haskell/Syntax/Decls.hs
=====================================
@@ -94,13 +94,12 @@ import {-# SOURCE #-} Language.Haskell.Syntax.Expr
 import Language.Haskell.Syntax.Binds
 import Language.Haskell.Syntax.Extension
 import Language.Haskell.Syntax.Type
-import Language.Haskell.Syntax.Basic (Role)
+import Language.Haskell.Syntax.Basic (Role, LexicalFixity)
 import Language.Haskell.Syntax.Specificity (Specificity)
 
 import GHC.Types.Basic (TopLevelFlag, OverlapMode, RuleName, Activation
                        ,TyConFlavour(..), TypeOrData(..))
 import GHC.Types.ForeignCall (CType, CCallConv, Safety, Header, CLabelString, CCallTarget, CExportSpec)
-import GHC.Types.Fixity (LexicalFixity)
 
 import GHC.Unit.Module.Warnings (WarningTxt)
 


=====================================
docs/users_guide/9.14.1-notes.rst
=====================================
@@ -11,6 +11,15 @@ for specific guidance on migrating programs to this release.
 Language
 ~~~~~~~~
 
+* ``-Wincomplete-record-selectors`` is now part of `-Wall`, as specified
+  by `GHC Proposal 516: add warning for incomplete record selectors <https://github.com/ghc-proposals/ghc-proposals/blob/master/proposals/0516-incomplete-record-selectors.rst>_`.
+  Hence, if a library is compiled with ``-Werror``, compilation may now fail. Solution: fix the library.
+  Workaround: add ``-Werror=no-incomplete-record-selectors``.
+
+  Note that this warning is at least
+  as serious as a warning about missing patterns from a function definition, perhaps even
+  more so, since it is invisible in the source program.
+
 Compiler
 ~~~~~~~~
 



View it on GitLab: https://gitlab.haskell.org/ghc/ghc/-/compare/d045238bf74edfb4fabd2ca4f8086f56e44ffd8a...1b9f398ae94206d0cda2e644729a88e835db1ef7

-- 
View it on GitLab: https://gitlab.haskell.org/ghc/ghc/-/compare/d045238bf74edfb4fabd2ca4f8086f56e44ffd8a...1b9f398ae94206d0cda2e644729a88e835db1ef7
You're receiving this email because of your account on gitlab.haskell.org.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.haskell.org/pipermail/ghc-commits/attachments/20241015/19469c48/attachment-0001.html>


More information about the ghc-commits mailing list