[Git][ghc/ghc][wip/T25281] Add -Werror=-Wno-error=incomplete-record-selectors to hadrian-multi

Simon Peyton Jones (@simonpj) gitlab at gitlab.haskell.org
Sun Oct 13 21:09:38 UTC 2024



Simon Peyton Jones pushed to branch wip/T25281 at Glasgow Haskell Compiler / GHC


Commits:
9acd713c by Simon Peyton Jones at 2024-10-13T22:09:02+01:00
Add -Werror=-Wno-error=incomplete-record-selectors to hadrian-multi

In the main MR, -Wall now includes -Wincomplete-record-selectors.
However `hadrian-multi` has many, many warnings about incomplete
record selectors, so this patch stops those warnings being treated
as errors.  (See discussion on !13308.)

A better fix would be to remove the use of incomplete record
selectors, since each of them represents a potential crash.

- - - - -


1 changed file:

- .gitlab-ci.yml


Changes:

=====================================
.gitlab-ci.yml
=====================================
@@ -435,7 +435,12 @@ hadrian-multi:
     # workaround for docker permissions
     - sudo chown ghc:ghc -R .
   variables:
-    GHC_FLAGS: "-Werror -Wwarn=deprecations"
+    GHC_FLAGS: "-Werror=-Wno-error=incomplete-record-selectors -Wwarn=deprecations"
+       # -Wno-error=incomplete-record-selectors is present because -Wall now
+       # includes -Wincomplete-record-selectors, and hadrian-multi has many, many
+       # warnings about incomplete record selectors.  A better fix would be to
+       # remove the use of incomplete record selectors, since each of them represents
+       # a potential crash.
     CONFIGURE_ARGS: --enable-bootstrap-with-devel-snapshot
   tags:
     - x86_64-linux



View it on GitLab: https://gitlab.haskell.org/ghc/ghc/-/commit/9acd713c8f452ac4196906db8edcc7452f71054e

-- 
View it on GitLab: https://gitlab.haskell.org/ghc/ghc/-/commit/9acd713c8f452ac4196906db8edcc7452f71054e
You're receiving this email because of your account on gitlab.haskell.org.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.haskell.org/pipermail/ghc-commits/attachments/20241013/73a1b5ea/attachment-0001.html>


More information about the ghc-commits mailing list