[Git][ghc/ghc][master] testsuite: Don't consider untracked files in dirtiness check

[Marge Bot (@marge-bot)]

Marge Bot pushed to branch master at Glasgow Haskell Compiler / GHC


Commits:
c2c562e0 by Ben Gamari at 2024-11-14T19:08:01-05:00
testsuite: Don't consider untracked files in dirtiness check

Considering trees containing untracked files as dirty is a bridge too
far. The chance of an untracked file significantly affecting measured
performanced metrics is quite small whereas not collecting measurements
is quite inconvenient for some workflows. We now ignore untracked files
in the dirtiness check.

Fixes #25471.

- - - - -


1 changed file:

- testsuite/driver/perf_notes.py


Changes:

=====================================
testsuite/driver/perf_notes.py
=====================================
@@ -43,7 +43,7 @@ def inside_git_repo() -> bool:
 
 # Check if the worktree is dirty.
 def is_worktree_dirty() -> bool:
-    return subprocess.check_output(['git', 'status', '--porcelain']) != b''
+    return subprocess.check_output(['git', 'status', '--porcelain', '--untracked-files=no']) != b''
 
 # Get length of abbreviated git commit hash
 def get_abbrev_hash_length() -> int:



View it on GitLab: https://gitlab.haskell.org/ghc/ghc/-/commit/c2c562e04b44079f622cf7748b0e21af443b6a49

-- 
View it on GitLab: https://gitlab.haskell.org/ghc/ghc/-/commit/c2c562e04b44079f622cf7748b0e21af443b6a49
You're receiving this email because of your account on gitlab.haskell.org.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.haskell.org/pipermail/ghc-commits/attachments/20241114/cb9e931a/attachment.html>