[Git][ghc/ghc][master] Improve test labels for binary interface file size tests

Marge Bot (@marge-bot) gitlab at gitlab.haskell.org
Fri May 24 16:17:54 UTC 2024



Marge Bot pushed to branch master at Glasgow Haskell Compiler / GHC


Commits:
4a7f4713 by Fendor at 2024-05-24T12:17:19-04:00
Improve test labels for binary interface file size tests

Test labels for binary interface file sizes are hard to read and overly
verbose at the same time. Extend the name for the metric title, but
shorten it in the actual comparison table.

- - - - -


2 changed files:

- testsuite/driver/testutil.py
- testsuite/tests/iface/all.T


Changes:

=====================================
testsuite/driver/testutil.py
=====================================
@@ -160,5 +160,8 @@ def shorten_metric_name(name: str) -> str:
         "compile_time/bytes allocated": "ghc/alloc",
         "compile_time/peak_megabytes_allocated": "ghc/peak",
         "compile_time/max_bytes_used": "ghc/max",
+        "binary_size/if_compression(1)": "size/1",
+        "binary_size/if_compression(2)": "size/2",
+        "binary_size/if_compression(3)": "size/3",
     }
     return dic.get(name, name)


=====================================
testsuite/tests/iface/all.T
=====================================
@@ -1,23 +1,23 @@
 test( 'if_faststring'
-    , [ stat_from_file('if_compression(1)', 5, 'NORMALSIZE')
-      , stat_from_file('if_compression(2)', 5, 'MEDIUMSIZE')
-      , stat_from_file('if_compression(3)', 5, 'FULLSIZE')
+    , [ stat_from_file('binary_size/if_compression(1)', 5, 'NORMALSIZE')
+      , stat_from_file('binary_size/if_compression(2)', 5, 'MEDIUMSIZE')
+      , stat_from_file('binary_size/if_compression(3)', 5, 'FULLSIZE')
       , extra_files(["Lib.hs"])]
     , compile_and_run
     , ['-package ghc'])
 
 test( 'if_name'
-    , [ stat_from_file('if_compression(1)', 5, 'NORMALSIZE')
-      , stat_from_file('if_compression(2)', 5, 'MEDIUMSIZE')
-      , stat_from_file('if_compression(3)', 5, 'FULLSIZE')
+    , [ stat_from_file('binary_size/if_compression(1)', 5, 'NORMALSIZE')
+      , stat_from_file('binary_size/if_compression(2)', 5, 'MEDIUMSIZE')
+      , stat_from_file('binary_size/if_compression(3)', 5, 'FULLSIZE')
       , extra_files(["Lib.hs", "IfaceSharingName.hs"])]
     , compile_and_run
     , ['-package ghc'])
 
 test( 'if_ifacetype'
-    , [ stat_from_file('if_compression(1)', 5, 'NORMALSIZE')
-      , stat_from_file('if_compression(2)', 5, 'MEDIUMSIZE')
-      , stat_from_file('if_compression(3)', 5, 'FULLSIZE')
+    , [ stat_from_file('binary_size/if_compression(1)', 5, 'NORMALSIZE')
+      , stat_from_file('binary_size/if_compression(2)', 5, 'MEDIUMSIZE')
+      , stat_from_file('binary_size/if_compression(3)', 5, 'FULLSIZE')
       , extra_files(["Lib.hs", "IfaceSharingIfaceType.hs"])]
     , compile_and_run
     , ['-package ghc'])



View it on GitLab: https://gitlab.haskell.org/ghc/ghc/-/commit/4a7f47138efd3dfa417caf526e384c3468b62525

-- 
View it on GitLab: https://gitlab.haskell.org/ghc/ghc/-/commit/4a7f47138efd3dfa417caf526e384c3468b62525
You're receiving this email because of your account on gitlab.haskell.org.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.haskell.org/pipermail/ghc-commits/attachments/20240524/fce21541/attachment-0001.html>


More information about the ghc-commits mailing list