[Git][ghc/ghc][master] 2 commits: tests: Widen acceptance window for dir and so size tests

Marge Bot (@marge-bot) gitlab at gitlab.haskell.org
Sat May 4 10:03:34 UTC 2024



Marge Bot pushed to branch master at Glasgow Haskell Compiler / GHC


Commits:
c49493f2 by Matthew Pickering at 2024-05-04T06:02:57-04:00
tests: Widen acceptance window for dir and so size tests

These are testing things which are sometimes out the control of a GHC
developer. Therefore we shouldn't fail CI if something about these
dependencies change because we can't do anything about it.

It is still useful to have these statistics for visualisation in grafana
though.

Ticket #24759

- - - - -
9562808d by Matthew Pickering at 2024-05-04T06:02:57-04:00
Disable rts_so test

It has already manifested large fluctuations and destabilising CI

Fixes #24762

- - - - -


1 changed file:

- testsuite/tests/perf/size/all.T


Changes:

=====================================
testsuite/tests/perf/size/all.T
=====================================
@@ -3,77 +3,80 @@ test('size_hello_obj', [collect_size(5, 'size_hello_obj.o')], compile, [''])
 test('size_hello_artifact', [collect_size(5, 'size_hello_artifact' + exe_extension())],
                              compile_artifact, [''])
 
-test('array_dir'           ,[collect_size_ghc_pkg(5 , 'array')]           , static_stats , [] )
-test('base_dir'            ,[collect_size_ghc_pkg(5 , 'base')]            , static_stats , [] )
-test('binary_dir'          ,[collect_size_ghc_pkg(5 , 'binary')]          , static_stats , [] )
-test('bytestring_dir'      ,[collect_size_ghc_pkg(5 , 'bytestring')]      , static_stats , [] )
-test('cabal_dir'           ,[collect_size_ghc_pkg(5 , 'Cabal')]           , static_stats , [] )
-test('cabal_syntax_dir'    ,[collect_size_ghc_pkg(5 , 'Cabal-syntax')]    , static_stats , [] )
-test('containers_dir'      ,[collect_size_ghc_pkg(5 , 'containers')]      , static_stats , [] )
-test('deepseq_dir'         ,[collect_size_ghc_pkg(5 , 'deepseq')]         , static_stats , [] )
-test('directory_dir'       ,[collect_size_ghc_pkg(5 , 'directory')]       , static_stats , [] )
-test('exceptions_dir'      ,[collect_size_ghc_pkg(5 , 'exceptions')]      , static_stats , [] )
-test('ghc_bignum_dir'      ,[collect_size_ghc_pkg(5 , 'ghc-bignum')]      , static_stats , [] )
-test('ghc_boot_dir'        ,[collect_size_ghc_pkg(5 , 'ghc-boot')]        , static_stats , [] )
-test('ghc_boot_th_dir'     ,[collect_size_ghc_pkg(5 , 'ghc-boot-th')]     , static_stats , [] )
-test('ghc_compact_dir'     ,[collect_size_ghc_pkg(5 , 'ghc-compact')]     , static_stats , [] )
-test('ghc_dir'             ,[collect_size_ghc_pkg(5 , 'ghc')]             , static_stats , [] )
-test('ghc_experimental_dir',[collect_size_ghc_pkg(5 , 'ghc-experimental')], static_stats , [] )
-test('ghc_heap_dir'        ,[collect_size_ghc_pkg(5 , 'ghc-heap')]        , static_stats , [] )
-test('ghc_internal_dir'    ,[collect_size_ghc_pkg(5 , 'ghc-internal')]    , static_stats , [] )
-test('ghc_platform_dir'    ,[collect_size_ghc_pkg(5 , 'ghc-platform')]    , static_stats , [] )
-test('ghc_prim_dir'        ,[collect_size_ghc_pkg(5 , 'ghc-prim')]        , static_stats , [] )
-test('ghc_toolchain_dir'   ,[collect_size_ghc_pkg(5 , 'ghc-toolchain')]   , static_stats , [] )
-test('haskeline_dir'       ,[collect_size_ghc_pkg(5 , 'haskeline')]       , static_stats , [] )
-test('hpc_dir'             ,[collect_size_ghc_pkg(5 , 'hpc')]             , static_stats , [] )
-test('integer_gmp_dir'     ,[collect_size_ghc_pkg(5 , 'integer-gmp')]     , static_stats , [] )
-test('mtl_dir'             ,[collect_size_ghc_pkg(5 , 'mtl')]             , static_stats , [] )
-test('os_string_dir'       ,[collect_size_ghc_pkg(5 , 'os-string')]       , static_stats , [] )
-test('parsec_dir'          ,[collect_size_ghc_pkg(5 , 'parsec')]          , static_stats , [] )
-test('pretty_dir'          ,[collect_size_ghc_pkg(5 , 'pretty')]          , static_stats , [] )
-test('process_dir'         ,[collect_size_ghc_pkg(5 , 'process')]         , static_stats , [] )
-test('time_dir'            ,[collect_size_ghc_pkg(5 , 'time')]            , static_stats , [] )
-test('xhtml_dir'           ,[collect_size_ghc_pkg(5 , 'xhtml')]           , static_stats , [] )
+size_acceptance_threshold = 100
+
+test('array_dir'           ,[collect_size_ghc_pkg(size_acceptance_threshold , 'array')]           , static_stats , [] )
+test('base_dir'            ,[collect_size_ghc_pkg(size_acceptance_threshold , 'base')]            , static_stats , [] )
+test('binary_dir'          ,[collect_size_ghc_pkg(size_acceptance_threshold , 'binary')]          , static_stats , [] )
+test('bytestring_dir'      ,[collect_size_ghc_pkg(size_acceptance_threshold , 'bytestring')]      , static_stats , [] )
+test('cabal_dir'           ,[collect_size_ghc_pkg(size_acceptance_threshold , 'Cabal')]           , static_stats , [] )
+test('cabal_syntax_dir'    ,[collect_size_ghc_pkg(size_acceptance_threshold , 'Cabal-syntax')]    , static_stats , [] )
+test('containers_dir'      ,[collect_size_ghc_pkg(size_acceptance_threshold , 'containers')]      , static_stats , [] )
+test('deepseq_dir'         ,[collect_size_ghc_pkg(size_acceptance_threshold , 'deepseq')]         , static_stats , [] )
+test('directory_dir'       ,[collect_size_ghc_pkg(size_acceptance_threshold , 'directory')]       , static_stats , [] )
+test('exceptions_dir'      ,[collect_size_ghc_pkg(size_acceptance_threshold , 'exceptions')]      , static_stats , [] )
+test('ghc_bignum_dir'      ,[collect_size_ghc_pkg(size_acceptance_threshold , 'ghc-bignum')]      , static_stats , [] )
+test('ghc_boot_dir'        ,[collect_size_ghc_pkg(size_acceptance_threshold , 'ghc-boot')]        , static_stats , [] )
+test('ghc_boot_th_dir'     ,[collect_size_ghc_pkg(size_acceptance_threshold , 'ghc-boot-th')]     , static_stats , [] )
+test('ghc_compact_dir'     ,[collect_size_ghc_pkg(size_acceptance_threshold , 'ghc-compact')]     , static_stats , [] )
+test('ghc_dir'             ,[collect_size_ghc_pkg(size_acceptance_threshold , 'ghc')]             , static_stats , [] )
+test('ghc_experimental_dir',[collect_size_ghc_pkg(size_acceptance_threshold , 'ghc-experimental')], static_stats , [] )
+test('ghc_heap_dir'        ,[collect_size_ghc_pkg(size_acceptance_threshold , 'ghc-heap')]        , static_stats , [] )
+test('ghc_internal_dir'    ,[collect_size_ghc_pkg(size_acceptance_threshold , 'ghc-internal')]    , static_stats , [] )
+test('ghc_platform_dir'    ,[collect_size_ghc_pkg(size_acceptance_threshold , 'ghc-platform')]    , static_stats , [] )
+test('ghc_prim_dir'        ,[collect_size_ghc_pkg(size_acceptance_threshold , 'ghc-prim')]        , static_stats , [] )
+test('ghc_toolchain_dir'   ,[collect_size_ghc_pkg(size_acceptance_threshold , 'ghc-toolchain')]   , static_stats , [] )
+test('haskeline_dir'       ,[collect_size_ghc_pkg(size_acceptance_threshold , 'haskeline')]       , static_stats , [] )
+test('hpc_dir'             ,[collect_size_ghc_pkg(size_acceptance_threshold , 'hpc')]             , static_stats , [] )
+test('integer_gmp_dir'     ,[collect_size_ghc_pkg(size_acceptance_threshold , 'integer-gmp')]     , static_stats , [] )
+test('mtl_dir'             ,[collect_size_ghc_pkg(size_acceptance_threshold , 'mtl')]             , static_stats , [] )
+test('os_string_dir'       ,[collect_size_ghc_pkg(size_acceptance_threshold , 'os-string')]       , static_stats , [] )
+test('parsec_dir'          ,[collect_size_ghc_pkg(size_acceptance_threshold , 'parsec')]          , static_stats , [] )
+test('pretty_dir'          ,[collect_size_ghc_pkg(size_acceptance_threshold , 'pretty')]          , static_stats , [] )
+test('process_dir'         ,[collect_size_ghc_pkg(size_acceptance_threshold , 'process')]         , static_stats , [] )
+test('time_dir'            ,[collect_size_ghc_pkg(size_acceptance_threshold , 'time')]            , static_stats , [] )
+test('xhtml_dir'           ,[collect_size_ghc_pkg(size_acceptance_threshold , 'xhtml')]           , static_stats , [] )
 
 # size of the entire libdir
 test('libdir'              ,[collect_size_dir(10, config.libdir)]                       , static_stats , [] )
 
 # skip these on windows
-test('unix_dir'     ,[windows_skip, collect_size_ghc_pkg(5, 'unix')]    , static_stats, [] )
-test('terminfo_dir' ,[windows_skip, js_skip, collect_size_ghc_pkg(5, 'terminfo')], static_stats, [] )
+test('unix_dir'     ,[windows_skip, collect_size_ghc_pkg(size_acceptance_threshold, 'unix')]    , static_stats, [] )
+test('terminfo_dir' ,[windows_skip, js_skip, collect_size_ghc_pkg(size_acceptance_threshold, 'terminfo')], static_stats, [] )
 
 # skip the shared object file tests on windows
-test('array_so'           ,[req_dynamic_ghc, js_skip, windows_skip, collect_object_size(5, "array")]            , static_stats, [] )
-test('base_so'            ,[req_dynamic_ghc, js_skip, windows_skip, collect_object_size(5, "base")]             , static_stats, [] )
-test('binary_so'          ,[req_dynamic_ghc, js_skip, windows_skip, collect_object_size(5, "binary")]           , static_stats, [] )
-test('bytestring_so'      ,[req_dynamic_ghc, js_skip, windows_skip, collect_object_size(5, "bytestring")]       , static_stats, [] )
-test('cabal_so'           ,[req_dynamic_ghc, js_skip, windows_skip, collect_object_size(5, "Cabal")]            , static_stats, [] )
-test('cabal_syntax_so'    ,[req_dynamic_ghc, js_skip, windows_skip, collect_object_size(5, "Cabal-syntax")]     , static_stats, [] )
-test('containers_so'      ,[req_dynamic_ghc, js_skip, windows_skip, collect_object_size(5, "containers")]       , static_stats, [] )
-test('deepseq_so'         ,[req_dynamic_ghc, js_skip, windows_skip, collect_object_size(5, "deepseq")]          , static_stats, [] )
-test('directory_so'       ,[req_dynamic_ghc, js_skip, windows_skip, collect_object_size(5, "directory")]        , static_stats, [] )
-test('exceptions_so'      ,[req_dynamic_ghc, js_skip, windows_skip, collect_object_size(5, "exceptions")]       , static_stats, [] )
-test('filepath_so'        ,[req_dynamic_ghc, js_skip, windows_skip, collect_object_size(5, "filepath")]         , static_stats, [] )
-test('ghc_bignum_so'      ,[req_dynamic_ghc, js_skip, windows_skip, collect_object_size(5, "ghc-bignum")]       , static_stats, [] )
-test('ghc_boot_so'        ,[req_dynamic_ghc, js_skip, windows_skip, collect_object_size(5, "ghc-boot")]         , static_stats, [] )
-test('ghc_boot_th_so'     ,[req_dynamic_ghc, js_skip, windows_skip, collect_object_size(5, "ghc-boot-th")]      , static_stats, [] )
-test('ghc_experimental_so',[req_dynamic_ghc, js_skip, windows_skip, collect_object_size(5, "ghc-experimental")] , static_stats, [] )
-test('ghc_heap_so'        ,[req_dynamic_ghc, js_skip, windows_skip, collect_object_size(5, "ghc-heap")]         , static_stats, [] )
-test('ghc_platform_so'    ,[req_dynamic_ghc, js_skip, windows_skip, collect_object_size(5, "ghc-platform")]     , static_stats, [] )
-test('ghc_prim_so'        ,[req_dynamic_ghc, js_skip, windows_skip, collect_object_size(5, "ghc-prim")]         , static_stats, [] )
-test('ghc_so'             ,[req_dynamic_ghc, js_skip, windows_skip, collect_object_size(5, "ghc")]              , static_stats, [] )
-test('ghc_toolchain_so'   ,[req_dynamic_ghc, js_skip, windows_skip, collect_object_size(5, "ghc-toolchain")]    , static_stats, [] )
-test('ghci_so'            ,[req_dynamic_ghc, js_skip, windows_skip, collect_object_size(5, "ghci")]             , static_stats, [] )
-test('haskeline_so'       ,[req_dynamic_ghc, js_skip, windows_skip, collect_object_size(5, "haskeline")]        , static_stats, [] )
-test('hpc_so'             ,[req_dynamic_ghc, js_skip, windows_skip, collect_object_size(5, "hpc")]              , static_stats, [] )
-test('mtl_so'             ,[req_dynamic_ghc, js_skip, windows_skip, collect_object_size(5, "mtl")]              , static_stats, [] )
-test('os_string_so'       ,[req_dynamic_ghc, js_skip, windows_skip, collect_object_size(5, "os-string")]        , static_stats, [] )
-test('parsec_so'          ,[req_dynamic_ghc, js_skip, windows_skip, collect_object_size(5, "parsec")]           , static_stats, [] )
-test('process_so'         ,[req_dynamic_ghc, js_skip, windows_skip, collect_object_size(5, "process")]          , static_stats, [] )
-test('rts_so'             ,[req_dynamic_ghc, js_skip, windows_skip, collect_object_size(5, "rts", True)]              , static_stats, [] )
-test('template_haskell_so',[req_dynamic_ghc, js_skip, windows_skip, collect_object_size(5, "template-haskell")] , static_stats, [] )
-test('terminfo_so'        ,[req_dynamic_ghc, js_skip, windows_skip, collect_object_size(5, "terminfo")]         , static_stats, [] )
-test('text_so'            ,[req_dynamic_ghc, js_skip, windows_skip, collect_object_size(5, "text")]             , static_stats, [] )
-test('time_so'            ,[req_dynamic_ghc, js_skip, windows_skip, collect_object_size(5, "time")]             , static_stats, [] )
-test('transformers_so'    ,[req_dynamic_ghc, js_skip, windows_skip, collect_object_size(5, "transformers")]     , static_stats, [] )
-test('xhtml_so'           ,[req_dynamic_ghc, js_skip, windows_skip, collect_object_size(5, "xhtml")]            , static_stats, [] )
+test('array_so'           ,[req_dynamic_ghc, js_skip, windows_skip, collect_object_size(size_acceptance_threshold, "array")]            , static_stats, [] )
+test('base_so'            ,[req_dynamic_ghc, js_skip, windows_skip, collect_object_size(size_acceptance_threshold, "base")]             , static_stats, [] )
+test('binary_so'          ,[req_dynamic_ghc, js_skip, windows_skip, collect_object_size(size_acceptance_threshold, "binary")]           , static_stats, [] )
+test('bytestring_so'      ,[req_dynamic_ghc, js_skip, windows_skip, collect_object_size(size_acceptance_threshold, "bytestring")]       , static_stats, [] )
+test('cabal_so'           ,[req_dynamic_ghc, js_skip, windows_skip, collect_object_size(size_acceptance_threshold, "Cabal")]            , static_stats, [] )
+test('cabal_syntax_so'    ,[req_dynamic_ghc, js_skip, windows_skip, collect_object_size(size_acceptance_threshold, "Cabal-syntax")]     , static_stats, [] )
+test('containers_so'      ,[req_dynamic_ghc, js_skip, windows_skip, collect_object_size(size_acceptance_threshold, "containers")]       , static_stats, [] )
+test('deepseq_so'         ,[req_dynamic_ghc, js_skip, windows_skip, collect_object_size(size_acceptance_threshold, "deepseq")]          , static_stats, [] )
+test('directory_so'       ,[req_dynamic_ghc, js_skip, windows_skip, collect_object_size(size_acceptance_threshold, "directory")]        , static_stats, [] )
+test('exceptions_so'      ,[req_dynamic_ghc, js_skip, windows_skip, collect_object_size(size_acceptance_threshold, "exceptions")]       , static_stats, [] )
+test('filepath_so'        ,[req_dynamic_ghc, js_skip, windows_skip, collect_object_size(size_acceptance_threshold, "filepath")]         , static_stats, [] )
+test('ghc_bignum_so'      ,[req_dynamic_ghc, js_skip, windows_skip, collect_object_size(size_acceptance_threshold, "ghc-bignum")]       , static_stats, [] )
+test('ghc_boot_so'        ,[req_dynamic_ghc, js_skip, windows_skip, collect_object_size(size_acceptance_threshold, "ghc-boot")]         , static_stats, [] )
+test('ghc_boot_th_so'     ,[req_dynamic_ghc, js_skip, windows_skip, collect_object_size(size_acceptance_threshold, "ghc-boot-th")]      , static_stats, [] )
+test('ghc_experimental_so',[req_dynamic_ghc, js_skip, windows_skip, collect_object_size(size_acceptance_threshold, "ghc-experimental")] , static_stats, [] )
+test('ghc_heap_so'        ,[req_dynamic_ghc, js_skip, windows_skip, collect_object_size(size_acceptance_threshold, "ghc-heap")]         , static_stats, [] )
+test('ghc_platform_so'    ,[req_dynamic_ghc, js_skip, windows_skip, collect_object_size(size_acceptance_threshold, "ghc-platform")]     , static_stats, [] )
+test('ghc_prim_so'        ,[req_dynamic_ghc, js_skip, windows_skip, collect_object_size(size_acceptance_threshold, "ghc-prim")]         , static_stats, [] )
+test('ghc_so'             ,[req_dynamic_ghc, js_skip, windows_skip, collect_object_size(size_acceptance_threshold, "ghc")]              , static_stats, [] )
+test('ghc_toolchain_so'   ,[req_dynamic_ghc, js_skip, windows_skip, collect_object_size(size_acceptance_threshold, "ghc-toolchain")]    , static_stats, [] )
+test('ghci_so'            ,[req_dynamic_ghc, js_skip, windows_skip, collect_object_size(size_acceptance_threshold, "ghci")]             , static_stats, [] )
+test('haskeline_so'       ,[req_dynamic_ghc, js_skip, windows_skip, collect_object_size(size_acceptance_threshold, "haskeline")]        , static_stats, [] )
+test('hpc_so'             ,[req_dynamic_ghc, js_skip, windows_skip, collect_object_size(size_acceptance_threshold, "hpc")]              , static_stats, [] )
+test('mtl_so'             ,[req_dynamic_ghc, js_skip, windows_skip, collect_object_size(size_acceptance_threshold, "mtl")]              , static_stats, [] )
+test('os_string_so'       ,[req_dynamic_ghc, js_skip, windows_skip, collect_object_size(size_acceptance_threshold, "os-string")]        , static_stats, [] )
+test('parsec_so'          ,[req_dynamic_ghc, js_skip, windows_skip, collect_object_size(size_acceptance_threshold, "parsec")]           , static_stats, [] )
+test('process_so'         ,[req_dynamic_ghc, js_skip, windows_skip, collect_object_size(size_acceptance_threshold, "process")]          , static_stats, [] )
+# Disabled as extremely unstable
+#test('rts_so'             ,[req_dynamic_ghc, js_skip, windows_skip, collect_object_size(size_acceptance_threshold, "rts", True)]              , static_stats, [] )
+test('template_haskell_so',[req_dynamic_ghc, js_skip, windows_skip, collect_object_size(size_acceptance_threshold, "template-haskell")] , static_stats, [] )
+test('terminfo_so'        ,[req_dynamic_ghc, js_skip, windows_skip, collect_object_size(size_acceptance_threshold, "terminfo")]         , static_stats, [] )
+test('text_so'            ,[req_dynamic_ghc, js_skip, windows_skip, collect_object_size(size_acceptance_threshold, "text")]             , static_stats, [] )
+test('time_so'            ,[req_dynamic_ghc, js_skip, windows_skip, collect_object_size(size_acceptance_threshold, "time")]             , static_stats, [] )
+test('transformers_so'    ,[req_dynamic_ghc, js_skip, windows_skip, collect_object_size(size_acceptance_threshold, "transformers")]     , static_stats, [] )
+test('xhtml_so'           ,[req_dynamic_ghc, js_skip, windows_skip, collect_object_size(size_acceptance_threshold, "xhtml")]            , static_stats, [] )



View it on GitLab: https://gitlab.haskell.org/ghc/ghc/-/compare/bf3d4db0894233ec72f092a4a34bce9ed4ff4e21...9562808d02db67838844d874c632f18af904949c

-- 
View it on GitLab: https://gitlab.haskell.org/ghc/ghc/-/compare/bf3d4db0894233ec72f092a4a34bce9ed4ff4e21...9562808d02db67838844d874c632f18af904949c
You're receiving this email because of your account on gitlab.haskell.org.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.haskell.org/pipermail/ghc-commits/attachments/20240504/159388c0/attachment-0001.html>


More information about the ghc-commits mailing list