[Git][ghc/ghc][wip/build-ordering] base: Ensure that ghc-bignum builds before GHC.IO.Encoding.Iconv

Ben Gamari (@bgamari) gitlab at gitlab.haskell.org
Sat Mar 9 18:00:37 UTC 2024



Ben Gamari pushed to branch wip/build-ordering at Glasgow Haskell Compiler / GHC


Commits:
244a1c32 by Ben Gamari at 2024-03-09T13:00:32-05:00
base: Ensure that ghc-bignum builds before GHC.IO.Encoding.Iconv

On Windows `GHC.IO.Encoding.Iconv` is empty and has no dependencies.
Consequently, we must add dummy build ordering imports to ensure that,
e.g., `GHC.Types` and `GHC.BigNum.Nat` are built before
`GHC.IO.Encoding.Iconv`.

- - - - -


1 changed file:

- libraries/base/src/GHC/IO/Encoding/Iconv.hs


Changes:

=====================================
libraries/base/src/GHC/IO/Encoding/Iconv.hs
=====================================
@@ -15,8 +15,8 @@
 -- This module provides text encoding/decoding using iconv
 --
 
-module GHC.IO.Encoding.Iconv
 #if !defined(mingw32_HOST_OS)
+module GHC.IO.Encoding.Iconv
     (iconvEncoding,
      mkIconvEncoding,
      localeEncodingName
@@ -25,6 +25,8 @@ module GHC.IO.Encoding.Iconv
 import GHC.Internal.IO.Encoding.Iconv
 
 #else
-    ( ) where
+module GHC.IO.Encoding.Iconv ( ) where
+
+import GHC.Internal.Base () -- For build ordering
 
 #endif



View it on GitLab: https://gitlab.haskell.org/ghc/ghc/-/commit/244a1c323e469f9b3b20ccebe6ceb58f4c6946d9

-- 
View it on GitLab: https://gitlab.haskell.org/ghc/ghc/-/commit/244a1c323e469f9b3b20ccebe6ceb58f4c6946d9
You're receiving this email because of your account on gitlab.haskell.org.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.haskell.org/pipermail/ghc-commits/attachments/20240309/bf20f118/attachment-0001.html>


More information about the ghc-commits mailing list