[Git][ghc/ghc][wip/T25009] Wibble notes

Simon Peyton Jones (@simonpj) gitlab at gitlab.haskell.org
Fri Jul 5 14:12:31 UTC 2024



Simon Peyton Jones pushed to branch wip/T25009 at Glasgow Haskell Compiler / GHC


Commits:
d10be80d by Simon Peyton Jones at 2024-07-05T15:12:12+01:00
Wibble notes

- - - - -


1 changed file:

- compiler/GHC/Core/Type.hs


Changes:

=====================================
compiler/GHC/Core/Type.hs
=====================================
@@ -2327,7 +2327,7 @@ buildSynTyCon name binders res_kind roles rhs
     is_forgetful = not (all ((`elemVarSet` rhs_tyvars) . binderVar) binders) ||
                    uniqSetAny isForgetfulSynTyCon rhs_tycons
          -- NB: is_forgetful is allowed to be conservative, returning True more often
-         -- than it should. See Note [Forgetful type synonums] in GHC.Core.TyCon
+         -- than it should. See Note [Forgetful type synonyms] in GHC.Core.TyCon
 
     rhs_tycons = tyConsOfType   rhs
     rhs_tyvars = tyCoVarsOfType rhs
@@ -3275,8 +3275,9 @@ efficient. Specifically, we strive to
 Goal (b) is particularly useful as it makes traversals (e.g. free variable
 traversal, substitution, and comparison) more efficient.
 Comparison in particular takes special advantage of nullary type synonym
-applications (e.g. things like @TyConApp typeTyCon []@), Note [Comparing
-nullary type synonyms] in "GHC.Core.Type".
+applications (e.g. things like @TyConApp typeTyCon []@). See
+* Note [Comparing type synonyms] in "GHC.Core.TyCo.Compare"
+* Note [Unifying type synonyms] in "GHC.Core.Unify"
 
 To accomplish these we use a number of tricks, implemented by mkTyConApp.
 



View it on GitLab: https://gitlab.haskell.org/ghc/ghc/-/commit/d10be80d28236df81234acbd9bfb52b79d93ff30

-- 
This project does not include diff previews in email notifications.
View it on GitLab: https://gitlab.haskell.org/ghc/ghc/-/commit/d10be80d28236df81234acbd9bfb52b79d93ff30
You're receiving this email because of your account on gitlab.haskell.org.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.haskell.org/pipermail/ghc-commits/attachments/20240705/705752e6/attachment-0001.html>


More information about the ghc-commits mailing list