[Git][ghc/ghc][master] hadrian: Reduce Cabal verbosity

Marge Bot (@marge-bot) gitlab at gitlab.haskell.org
Tue Jan 16 20:42:46 UTC 2024



Marge Bot pushed to branch master at Glasgow Haskell Compiler / GHC


Commits:
65da79b3 by Matthew Pickering at 2024-01-16T15:41:54-05:00
hadrian: Reduce Cabal verbosity

The comment claims that `simpleUserHooks` decrease verbosity, and it
does, but only for the `postConf` phase. The other phases are too
verbose with `-V`.

At the moment > 5000 lines of the build log are devoted to output from
`cabal copy`.

So I take the simple approach and just decrease the verbosity level
again.

If the output of `postConf` is essential then it would be better to
implement our own `UserHooks` which doesn't decrease the verbosity for
`postConf`.

Fixes #24338

- - - - -


1 changed file:

- hadrian/src/Hadrian/Haskell/Cabal/Parse.hs


Changes:

=====================================
hadrian/src/Hadrian/Haskell/Cabal/Parse.hs
=====================================
@@ -194,11 +194,10 @@ copyPackage context at Context {..} = do
         C.defaultMainWithHooksNoReadArgs C.autoconfUserHooks gpd
             [ "copy", "--builddir", ctxPath, "--target-package-db", pkgDbPath, v ]
 
--- | Increase by 1 by because 'simpleUserHooks' calls 'lessVerbose'
 shakeVerbosityToCabalFlag :: Verbosity -> String
 shakeVerbosityToCabalFlag = \case
-    Diagnostic -> "-v3"
-    Verbose -> "-v2"
+    Diagnostic -> "-v2"
+    Verbose -> "-v1"
     -- Normal levels should not produce output to stdout
     Silent -> "-v0"
     _ -> "-v1"



View it on GitLab: https://gitlab.haskell.org/ghc/ghc/-/commit/65da79b39d040092f42c6a1f6bbe3c13f7d0bb99

-- 
View it on GitLab: https://gitlab.haskell.org/ghc/ghc/-/commit/65da79b39d040092f42c6a1f6bbe3c13f7d0bb99
You're receiving this email because of your account on gitlab.haskell.org.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.haskell.org/pipermail/ghc-commits/attachments/20240116/a2d58966/attachment.html>


More information about the ghc-commits mailing list