[Git][ghc/ghc][master] Fix searching for errors in sphinx build

Marge Bot (@marge-bot) gitlab at gitlab.haskell.org
Mon Feb 19 12:14:38 UTC 2024



Marge Bot pushed to branch master at Glasgow Haskell Compiler / GHC


Commits:
35b0ad90 by Brandon Chinn at 2024-02-19T07:13:25-05:00
Fix searching for errors in sphinx build

- - - - -


1 changed file:

- hadrian/src/Rules/Documentation.hs


Changes:

=====================================
hadrian/src/Rules/Documentation.hs
=====================================
@@ -171,8 +171,14 @@ checkSphinxWarnings out = do
     when ("undefined label:" `isInfixOf` log)
       $ fail "Undefined labels found in Sphinx log."
 
-    when ("ERROR:" `isInfixOf` log)
+    when (any hasError (lines log))
       $ fail "Errors found in the Sphinx log."
+    where
+        hasError line =
+            case words line of
+                _ : "ERROR:" : _ -> True
+                _ : "CRITICAL:" : _ -> True
+                _ -> False
 
 -- | Check that all GHC flags are documented in the users guide.
 checkUserGuideFlags :: FilePath -> Action ()



View it on GitLab: https://gitlab.haskell.org/ghc/ghc/-/commit/35b0ad901b51dbfeba3af987c68321cc902a6af5

-- 
View it on GitLab: https://gitlab.haskell.org/ghc/ghc/-/commit/35b0ad901b51dbfeba3af987c68321cc902a6af5
You're receiving this email because of your account on gitlab.haskell.org.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.haskell.org/pipermail/ghc-commits/attachments/20240219/8ab0de80/attachment-0001.html>


More information about the ghc-commits mailing list