[Git][ghc/ghc][wip/marge_bot_batch_merge_job] 4 commits: Unify the hpc testsuites

Marge Bot (@marge-bot) gitlab at gitlab.haskell.org
Fri Nov 24 10:29:10 UTC 2023



Marge Bot pushed to branch wip/marge_bot_batch_merge_job at Glasgow Haskell Compiler / GHC


Commits:
121c9ab7 by David Binder at 2023-11-22T21:12:29-05:00
Unify the hpc testsuites

The hpc testsuite was split between testsuite/tests/hpc
and the submodule libraries/hpc/test. This commit unifies
the two testsuites in the GHC repository in the directory
testsuite/tests/hpc.

- - - - -
d2733a05 by Alan Zimmerman at 2023-11-22T21:13:05-05:00
EPA: empty tup_tail has noAnn

In Parser.y, the tup_tail rule had the following option
          | {- empty -} %shift   { return [Left noAnn] }

Once this works through PostProcess.hs, it means we add an extra
Missing constructor if the last item was a comma.

Change the annotation type to a Bool to indicate this, and use the
EpAnn Anchor for the print location for the others.

- - - - -
bf162c07 by Andreas Klebinger at 2023-11-24T05:29:06-05:00
Fix FMA primops generating broken assembly on x86.

`genFMA3Code` assumed that we had to take extra precations to avoid overwriting
the result of `getNonClobberedReg`. One of these special cases caused a bug resulting
in broken assembly.

I believe we don't need to hadle these cases specially at all, which means this MR simply
deletes the special cases to fix the bug.

Fixes #24160

- - - - -
fb39b94a by Alan Zimmerman at 2023-11-24T05:29:07-05:00
EPA: Remove parenthesizeHsType

This is called from PostProcess.hs, and adds spurious parens.
With the looser version of exact printing we had before we could
tolerate this, as they would be swallowed by the original at the same
place.

But with the next change (remove EpAnnNotUsed) they result in
duplicates in the output.

For Darwin build:

Metric Increase:
    MultiLayerModulesTH_OneShot

- - - - -


30 changed files:

- compiler/GHC/CmmToAsm/X86/CodeGen.hs
- compiler/GHC/CmmToAsm/X86/Instr.hs
- compiler/GHC/Driver/Pipeline/Execute.hs
- compiler/GHC/Hs/Expr.hs
- compiler/GHC/Hs/Type.hs
- compiler/GHC/Hs/Utils.hs
- compiler/GHC/Parser.y
- compiler/GHC/Parser/PostProcess.hs
- compiler/GHC/Parser/Types.hs
- libraries/hpc
- + testsuite/tests/hpc/.gitignore
- + testsuite/tests/hpc/fork/Makefile
- + testsuite/tests/hpc/fork/hpc_fork.hs
- + testsuite/tests/hpc/fork/hpc_fork.stdout
- + testsuite/tests/hpc/fork/test.T
- + testsuite/tests/hpc/function/Makefile
- + testsuite/tests/hpc/function/test.T
- + testsuite/tests/hpc/function/tough.hs
- + testsuite/tests/hpc/function/tough.stdout
- + testsuite/tests/hpc/function2/Makefile
- + testsuite/tests/hpc/function2/subdir/tough2.lhs
- + testsuite/tests/hpc/function2/test.T
- + testsuite/tests/hpc/function2/tough2.stdout
- + testsuite/tests/hpc/ghc_ghci/A.hs
- + testsuite/tests/hpc/ghc_ghci/B.hs
- + testsuite/tests/hpc/ghc_ghci/Makefile
- + testsuite/tests/hpc/ghc_ghci/hpc_ghc_ghci.stdout
- + testsuite/tests/hpc/ghc_ghci/test.T
- + testsuite/tests/hpc/hpc.ovr
- + testsuite/tests/hpc/hpcrun.pl


The diff was not included because it is too large.


View it on GitLab: https://gitlab.haskell.org/ghc/ghc/-/compare/d4e26b605af4f74e7e3980e20139430c20083c99...fb39b94acf904bee4826b17757423a5e31657cf0

-- 
View it on GitLab: https://gitlab.haskell.org/ghc/ghc/-/compare/d4e26b605af4f74e7e3980e20139430c20083c99...fb39b94acf904bee4826b17757423a5e31657cf0
You're receiving this email because of your account on gitlab.haskell.org.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.haskell.org/pipermail/ghc-commits/attachments/20231124/07eb15cc/attachment.html>


More information about the ghc-commits mailing list