[Git][ghc/ghc][wip/az/locateda-epa-improve-2023-07-15] 21 commits: Add laws relating between Foldable/Traversable with their Bi- superclasses

Tue Nov 7 22:23:00 UTC 2023

Alan Zimmerman pushed to branch wip/az/locateda-epa-improve-2023-07-15 at Glasgow Haskell Compiler / GHC

Commits:
30baac7a by Tobias Haslop at 2023-11-06T10:50:32+00:00
Add laws relating between Foldable/Traversable with their Bi- superclasses

See https://github.com/haskell/core-libraries-committee/issues/205 for
discussion.

This commit also documents that the tuple instances only satisfy the
laws up to lazyness, similar to the documentation added in !9512.

- - - - -
df626f00 by Tobias Haslop at 2023-11-07T02:20:37-05:00
Elaborate on the quantified superclass of Bifunctor

This was requested in the comment
https://github.com/haskell/core-libraries-committee/issues/93#issuecomment-1597271700
for when Traversable becomes a superclass of Bitraversable, but similarly
applies to Functor/Bifunctor, which already are in a superclass relationship.

- - - - -
8217acb8 by Alan Zimmerman at 2023-11-07T02:21:12-05:00
EPA: get rid of l2l and friends

Replace them with

  l2l to convert the location
  la2la to convert a GenLocated thing

Updates haddock submodule

- - - - -
dd88a260 by Luite Stegeman at 2023-11-07T02:21:53-05:00
JS: remove broken newIdents from JStg Monad

GHC.JS.JStg.Monad.newIdents was broken, resulting in duplicate
identifiers being generated in h$c1, h$c2, ... .

This change removes the broken newIdents.

- - - - -
f088d21b by Alan Zimmerman at 2023-11-07T19:45:29+00:00
EPA: get rid of glRR and friends

With the HasLoc and HasAnnotation classes, we can replace a
number of type-specific helper functions in the parser with
polymorphic ones instead

- - - - -
4a5ee777 by Alan Zimmerman at 2023-11-07T20:32:06+00:00
EPA: harmonise acsa and acsA

[2023-10-01 Sun]
Failing tests
  HsDocTy

- - - - -
3d5501f2 by Alan Zimmerman at 2023-11-07T21:27:07+00:00
EPA: Replace Anchor with EpaLocation

[2023-09-21 Thu]
Only test failing is
   HsDocTy

- - - - -
7c59c801 by Alan Zimmerman at 2023-11-07T21:27:08+00:00
EPA: get rid of AnchorOperation

[2023-09-21 Thu]
Only error is
  HsDocTy

- - - - -
2546626f by Alan Zimmerman at 2023-11-07T21:27:08+00:00
EPA: splitLHsForAllTyInvis no ann returned

- - - - -
3c5bef2a by Alan Zimmerman at 2023-11-07T21:27:08+00:00
EPA: Replace Monoid with NoAnn

[2023-08-19 Sat]
AddClassMethod fails

- - - - -
53b59e99 by Alan Zimmerman at 2023-11-07T21:27:08+00:00
EPA: Use SrcSpan in EpaSpan

[2023-09-04 Mon]
No errors or warnings in check-exact

[2023-09-21 Thu]
Test failures
   HsDocTy

- - - - -
c03d21f2 by Alan Zimmerman at 2023-11-07T21:27:08+00:00
EPA: Present no longer has annotation

- - - - -
8c3eca13 by Alan Zimmerman at 2023-11-07T21:27:08+00:00
EPA: empty tup_tail has no ann

Parser.y: tup_tail rule was
          | {- empty -} %shift   { return [Left noAnn] }

This means we add an extra Missing constructor if the last item was a comma.

Change the annotation type to a Bool to indicate this, and use the
EpAnn Anchor for the print location for the others.

- - - - -
6d560a6d by Alan Zimmerman at 2023-11-07T21:27:09+00:00
EPA: Remove parenthesizeHsType

- - - - -
629e6cc7 by Alan Zimmerman at 2023-11-07T21:27:09+00:00
EPA: Remove EpAnnNotUsed

[2023-10-01 Sun]
Failures
  HsDocTy
  T15242

- - - - -
2b9825fa by Alan Zimmerman at 2023-11-07T21:27:09+00:00
EPA: Remove SrcSpanAnn

[2023-10-12 Thu]
  Failures
    HsDocTy
    T15242

- - - - -
7a95bdbb by Alan Zimmerman at 2023-11-07T21:27:09+00:00
EPA: Remove SrcSpanAnn completely

- - - - -
d7c92ebf by Alan Zimmerman at 2023-11-07T21:27:09+00:00
Clean up mkScope

- - - - -
05cbec0f by Alan Zimmerman at 2023-11-07T21:27:10+00:00
EPA: Clean up TC Monad Utils

- - - - -
392a4371 by Alan Zimmerman at 2023-11-07T21:27:10+00:00
EPA: EpaDelta for comment has no comments

[2023-09-23 Sat]
Current failures
   HsDocTy
   T15242

- - - - -
e94b94df by Alan Zimmerman at 2023-11-07T21:27:10+00:00
Semigroup instances for AnnList and AnnContext

- - - - -

30 changed files:

- compiler/GHC/Hs.hs
- compiler/GHC/Hs/Binds.hs
- compiler/GHC/Hs/Decls.hs
- compiler/GHC/Hs/Dump.hs
- compiler/GHC/Hs/Expr.hs
- compiler/GHC/Hs/Extension.hs
- compiler/GHC/Hs/ImpExp.hs
- compiler/GHC/Hs/Pat.hs
- compiler/GHC/Hs/Type.hs
- compiler/GHC/Hs/Utils.hs
- compiler/GHC/HsToCore/Arrows.hs
- compiler/GHC/HsToCore/Docs.hs
- compiler/GHC/HsToCore/Monad.hs
- compiler/GHC/Iface/Ext/Ast.hs
- compiler/GHC/Iface/Ext/Utils.hs
- compiler/GHC/JS/JStg/Monad.hs
- compiler/GHC/JS/Make.hs
- compiler/GHC/Parser.y
- compiler/GHC/Parser/Annotation.hs
- compiler/GHC/Parser/Lexer.x
- compiler/GHC/Parser/PostProcess.hs
- compiler/GHC/Parser/PostProcess/Haddock.hs
- compiler/GHC/Parser/Types.hs
- compiler/GHC/Rename/Bind.hs
- compiler/GHC/Rename/Env.hs
- compiler/GHC/Rename/Expr.hs
- compiler/GHC/Rename/Module.hs
- compiler/GHC/Rename/Names.hs
- compiler/GHC/Rename/Pat.hs
- compiler/GHC/Rename/Splice.hs

The diff was not included because it is too large.

View it on GitLab: https://gitlab.haskell.org/ghc/ghc/-/compare/fd4d3911ad2c88a8f07bc5158b703d4d15942bd2...e94b94dfc15619d32f54af8e4ebe22d2b183ee28

-- 
View it on GitLab: https://gitlab.haskell.org/ghc/ghc/-/compare/fd4d3911ad2c88a8f07bc5158b703d4d15942bd2...e94b94dfc15619d32f54af8e4ebe22d2b183ee28
You're receiving this email because of your account on gitlab.haskell.org.

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.haskell.org/pipermail/ghc-commits/attachments/20231107/5dc2a7ee/attachment-0001.html>