[Git][ghc/ghc][wip/toolchain-selection] Add comment from check for gold t22266

[Rodrigo Mesquita (@alt-romes)]

Rodrigo Mesquita pushed to branch wip/toolchain-selection at Glasgow Haskell Compiler / GHC


Commits:
7c4735ec by Rodrigo Mesquita at 2023-05-29T17:26:51+01:00
Add comment from check for gold t22266

- - - - -


1 changed file:

- utils/ghc-toolchain/src/GHC/Toolchain/Tools/MergeObjs.hs


Changes:

=====================================
utils/ghc-toolchain/src/GHC/Toolchain/Tools/MergeObjs.hs
=====================================
@@ -40,6 +40,10 @@ checkMergingWorks cc nm mergeObjs =
         let ok = all (`isInfixOf` out) ["funA", "funB"]
         unless ok $ throwE "merged objects is missing symbols"
 
+-- Test for binutils #22266. This bug manifested as GHC bug #14328 (see also:
+-- #14675, #14291).
+-- Uses test from
+-- https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=033bfb739b525703bfe23f151d09e9beee3a2afe
 checkForGoldT22266 :: Cc -> CcLink -> MergeObjs -> M ()
 checkForGoldT22266 cc ccLink mergeObjs = do
     version <- checking "for ld.gold object merging bug (binutils #22266)" $



View it on GitLab: https://gitlab.haskell.org/ghc/ghc/-/commit/7c4735ecde54cf2f6106a52613d1d3388e91ca3b

-- 
View it on GitLab: https://gitlab.haskell.org/ghc/ghc/-/commit/7c4735ecde54cf2f6106a52613d1d3388e91ca3b
You're receiving this email because of your account on gitlab.haskell.org.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.haskell.org/pipermail/ghc-commits/attachments/20230529/2a3b73ec/attachment.html>