[Git][ghc/ghc][wip/warns-to-drivermessages] Apply 3 suggestion(s) to 3 file(s)

[Oleg Grenrus (@phadej)]

Oleg Grenrus pushed to branch wip/warns-to-drivermessages at Glasgow Haskell Compiler / GHC


Commits:
48b5c933 by Matthew Pickering at 2023-05-19T08:49:41+00:00
Apply 3 suggestion(s) to 3 file(s)
- - - - -


3 changed files:

- compiler/GHC/Driver/CmdLine.hs
- compiler/GHC/Driver/Errors/Types.hs
- compiler/GHC/Driver/Session.hs


Changes:

=====================================
compiler/GHC/Driver/CmdLine.hs
=====================================
@@ -19,7 +19,7 @@ module GHC.Driver.CmdLine
 
       Err(..), Warn, warnsToMessages,
 
-      EwM, runEwM, addErr, addWarn, addFlagWarn, getArg, getCurLoc, liftEwM,
+      EwM, runEwM, addErr, addWarn, addFlagWarn, getArg, getCurLoc, liftEwM
     ) where
 
 import GHC.Prelude


=====================================
compiler/GHC/Driver/Errors/Types.hs
=====================================
@@ -373,6 +373,7 @@ data DriverMessage where
 
   DriverInterfaceError :: !IfaceMessage -> DriverMessage
 
+  -- TODO: Add structure messages rather than a String
   DriverInconsistentDynFlags :: String -> DriverMessage
 
   DriverSafeHaskellIgnoredExtension :: !LangExt.Extension -> DriverMessage


=====================================
compiler/GHC/Driver/Session.hs
=====================================
@@ -805,7 +805,6 @@ processCmdLineP activeFlags s0 args =
     getCmdLineP :: CmdLineP s a -> StateT s m a
     getCmdLineP (CmdLineP k) = k
 
-
 -- | Parses the dynamically set flags for GHC. This is the most general form of
 -- the dynamic flag parser that the other methods simply wrap. It allows
 -- saying which flags are valid flags and indicating if we are parsing



View it on GitLab: https://gitlab.haskell.org/ghc/ghc/-/commit/48b5c9338f28e6cc34a85c636ee81863a9e6134d

-- 
View it on GitLab: https://gitlab.haskell.org/ghc/ghc/-/commit/48b5c9338f28e6cc34a85c636ee81863a9e6134d
You're receiving this email because of your account on gitlab.haskell.org.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.haskell.org/pipermail/ghc-commits/attachments/20230519/6f7de61a/attachment-0001.html>