[Git][ghc/ghc][master] 2 commits: MR Review Template: Mention "Blocked on Review" label
Marge Bot (@marge-bot)
gitlab at gitlab.haskell.org
Mon Jun 26 17:16:26 UTC 2023
Marge Bot pushed to branch master at Glasgow Haskell Compiler / GHC
Commits:
5578bbad by Matthew Pickering at 2023-06-26T13:15:43-04:00
MR Review Template: Mention "Blocked on Review" label
In order to improve our MR review processes we now have the label
"Blocked on Review" which allows people to signal that a MR is waiting
on a review to happen.
See: https://mail.haskell.org/pipermail/ghc-devs/2023-June/021255.html
- - - - -
4427e9cf by Matthew Pickering at 2023-06-26T13:15:43-04:00
Move MR template to Default.md
This makes it more obvious what you have to modify to affect the default
template rather than looking in the project settings.
- - - - -
1 changed file:
- .gitlab/merge_request_templates/merge-request.md → .gitlab/merge_request_templates/Default.md
Changes:
=====================================
.gitlab/merge_request_templates/merge-request.md → .gitlab/merge_request_templates/Default.md
=====================================
@@ -25,9 +25,9 @@ If you have any questions don't hesitate to open your merge request and inquire
in a comment. If your patch isn't quite done yet please do add prefix your MR
title with `WIP:`.
-Once your change is ready please remove the `WIP:` tag and wait for review. If
+Once your change is ready please remove the `WIP:` tag and wait for review. If
no one has offerred review in a few days then please leave a comment mentioning
- at triagers.
+ at triagers and apply the ~"Blocked on Review" label.
[notes]: https://gitlab.haskell.org/ghc/ghc/wikis/commentary/coding-style#comments-in-the-source-code
[adding test]: https://gitlab.haskell.org/ghc/ghc/wikis/building/running-tests/adding
View it on GitLab: https://gitlab.haskell.org/ghc/ghc/-/compare/8d6574bc68cbbcabbf7c0e5700571c4746127fb8...4427e9cfaeab5ea50796b0923960ab846216972a
--
View it on GitLab: https://gitlab.haskell.org/ghc/ghc/-/compare/8d6574bc68cbbcabbf7c0e5700571c4746127fb8...4427e9cfaeab5ea50796b0923960ab846216972a
You're receiving this email because of your account on gitlab.haskell.org.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.haskell.org/pipermail/ghc-commits/attachments/20230626/8672dbcd/attachment.html>
More information about the ghc-commits
mailing list