[Git][ghc/ghc][wip/tsan/fixes-2] codeGen: More precise barriers for eager blackholing

Ben Gamari (@bgamari) gitlab at gitlab.haskell.org
Fri Jun 23 15:38:20 UTC 2023



Ben Gamari pushed to branch wip/tsan/fixes-2 at Glasgow Haskell Compiler / GHC


Commits:
e10dfa47 by Ben Gamari at 2023-06-22T19:04:44-04:00
codeGen: More precise barriers for eager blackholing

- - - - -


1 changed file:

- compiler/GHC/StgToCmm/Bind.hs


Changes:

=====================================
compiler/GHC/StgToCmm/Bind.hs
=====================================
@@ -702,11 +702,11 @@ emitBlackHoleCode node = do
 
   when eager_blackholing $ do
     whenUpdRemSetEnabled $ emitUpdRemSetPushThunk node
-    emitAtomicStore platform MemOrderSeqCst
+    emitAtomicStore platform MemOrderRelease
         (cmmOffsetW platform node (fixedHdrSizeW profile))
         (currentTSOExpr platform)
     -- See Note [Heap memory barriers] in SMP.h.
-    emitAtomicStore platform MemOrderRelaxed
+    emitAtomicStore platform MemOrderRelease
         node
         (CmmReg (CmmGlobal $ GlobalRegUse EagerBlackholeInfo $ bWord platform))
 



View it on GitLab: https://gitlab.haskell.org/ghc/ghc/-/commit/e10dfa4737d446b6cace5af9e0eefef689c4ca99

-- 
View it on GitLab: https://gitlab.haskell.org/ghc/ghc/-/commit/e10dfa4737d446b6cace5af9e0eefef689c4ca99
You're receiving this email because of your account on gitlab.haskell.org.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.haskell.org/pipermail/ghc-commits/attachments/20230623/05d5124d/attachment-0001.html>


More information about the ghc-commits mailing list