[Git][ghc/ghc][wip/marge_bot_batch_merge_job] 10 commits: Change WarningWithFlag to plural WarningWithFlags

Tue Jun 13 06:12:00 UTC 2023

Marge Bot pushed to branch wip/marge_bot_batch_merge_job at Glasgow Haskell Compiler / GHC

Commits:
dad1616a by Oleg Grenrus at 2023-06-13T02:11:22-04:00
Change WarningWithFlag to plural WarningWithFlags

Resolves #22825

Now each diagnostic can name multiple different warning flags for its reason.

There is currently one use case: missing signatures.
Currently we need to check which warning flags are enabled when
generating the diagnostic, which is against the declarative nature of
the diagnostic framework.

This patch allows a warning diagnostic to have multiple warning flags,
which makes setup more declarative.

The WarningWithFlag pattern synonym is added for backwards compatibility

The 'msgEnvReason' field is added to MsgEnvelope to store the
`ResolvedDiagnosticReason`, which accounts for the enabled flags, and
then that is used for pretty printing the diagnostic.

- - - - -
4cdb7409 by Matthew Pickering at 2023-06-13T02:11:33-04:00
Add a test Way for running ghci with Core optimizations

Tracking ticket: #23059

This runs compile_and_run tests with optimised code with bytecode
interpreter

Changed submodules: hpc, process

Co-authored-by: Torsten Schmits <git at tryp.io>

- - - - -
cad7a5aa by Rodrigo Mesquita at 2023-06-13T02:11:34-04:00
Configure -Qunused-arguments instead of hardcoding it

When GHC invokes clang, it currently passes -Qunused-arguments to
discard warnings resulting from GHC using multiple options that aren't
used.

In this commit, we configure -Qunused-arguments into the Cc options
instead of checking if the compiler is clang at runtime and hardcoding
the flag into GHC.

This is part of the effort to centralise toolchain information in
toolchain target files at configure time with the end goal of a runtime
retargetable GHC.

This also means we don't need to call getCompilerInfo ever, which
improves performance considerably (see !10589).

Metric Decrease:
    PmSeriesG
    T10421
    T11303b
    T12150
    T12227
    T12234
    T12425
    T13035
    T13253-spj
    T13386
    T15703
    T16875
    T17836b
    T17977
    T17977b
    T18140
    T18282
    T18304
    T18698a
    T18698b
    T18923
    T20049
    T21839c
    T3064
    T5030
    T5321FD
    T5321Fun
    T5837
    T6048
    T9020
    T9198
    T9872d
    T9961

- - - - -
6bcfbe8c by Victor Cacciari Miraldo at 2023-06-13T02:11:38-04:00
Improve docs for Data.Fixed; adds 'realToFrac' as an option for conversion
between different precisions.

- - - - -
feea9d39 by Ryan Scott at 2023-06-13T02:11:38-04:00
Add regression test for #23143

!10541, the fix for #23323, also fixes #23143. Let's add a regression test to
ensure that it stays fixed.

Fixes #23143.

- - - - -
2a70d6d5 by Emily Martins at 2023-06-13T02:11:42-04:00
delete GHCi.UI.Tags module and remove remaining references

Co-authored-by: Tilde Rose <t1lde at protonmail.com>

- - - - -
3db67af3 by Victor Cacciari Miraldo at 2023-06-13T02:11:44-04:00
Add regression test for 17328

- - - - -
faffa9dc by Victor Cacciari Miraldo at 2023-06-13T02:11:44-04:00
Skip checking whether constructors are in scope when deriving
newtype instances.

Fixes #17328

- - - - -
f55f5f03 by Philip Hazelden at 2023-06-13T02:11:48-04:00
Don't suggest `DeriveAnyClass` when instance can't be derived.

Fixes #19692.

Prototypical cases:

    class C1 a where
      x1 :: a -> Int
    data G1 = G1 deriving C1

    class C2 a where
      x2 :: a -> Int
      x2 _ = 0
    data G2 = G2 deriving C2

Both of these used to give this suggestion, but for C1 the suggestion
would have failed (generated code with undefined methods, which compiles
but warns). Now C2 still gives the suggestion but C1 doesn't.

- - - - -
737b84d6 by David Binder at 2023-06-13T02:11:53-04:00
Add testcase for error GHC-00711 to testsuite

- - - - -

30 changed files:

- compiler/GHC/Driver/Errors.hs
- compiler/GHC/Driver/Pipeline/Execute.hs
- compiler/GHC/Rename/Names.hs
- compiler/GHC/Tc/Deriv.hs
- compiler/GHC/Tc/Errors/Ppr.hs
- compiler/GHC/Tc/Errors/Types.hs
- compiler/GHC/Types/Error.hs
- compiler/GHC/Utils/Error.hs
- configure.ac
- distrib/configure.ac.in
- docs/users_guide/9.8.1-notes.rst
- docs/users_guide/ghci.rst
- ghc/GHCi/UI.hs
- − ghc/GHCi/UI/Tags.hs
- ghc/ghc-bin.cabal.in
- libraries/base/Data/Fixed.hs
- libraries/base/tests/IO/all.T
- libraries/base/tests/all.T
- libraries/ghc-compact/tests/all.T
- libraries/ghc-heap/tests/all.T
- libraries/hpc
- libraries/process
- + m4/fp_cc_ignore_unused_args.m4
- testsuite/config/ghc
- testsuite/driver/testlib.py
- testsuite/tests/cmm/should_run/all.T
- testsuite/tests/cmm/should_run/machops/all.T
- testsuite/tests/codeGen/should_fail/all.T
- testsuite/tests/codeGen/should_run/T20137/T20137.hs
- testsuite/tests/codeGen/should_run/T20137/T20137C.c

The diff was not included because it is too large.

View it on GitLab: https://gitlab.haskell.org/ghc/ghc/-/compare/b3c6d543c12ec40ac779e8c114f548fe70f70356...737b84d6b2d98d946074a2f75d2b97b68a7218cb

-- 
View it on GitLab: https://gitlab.haskell.org/ghc/ghc/-/compare/b3c6d543c12ec40ac779e8c114f548fe70f70356...737b84d6b2d98d946074a2f75d2b97b68a7218cb
You're receiving this email because of your account on gitlab.haskell.org.

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.haskell.org/pipermail/ghc-commits/attachments/20230613/849f25f2/attachment.html>