[Git][ghc/ghc][wip/simplifier-tweaks] Wibbles

[Simon Peyton Jones (@simonpj)]

Simon Peyton Jones pushed to branch wip/simplifier-tweaks at Glasgow Haskell Compiler / GHC


Commits:
2687f395 by Simon Peyton Jones at 2023-07-27T16:02:11+01:00
Wibbles

- - - - -


1 changed file:

- compiler/GHC/Core/Opt/Simplify/Iteration.hs


Changes:

=====================================
compiler/GHC/Core/Opt/Simplify/Iteration.hs
=====================================
@@ -3783,8 +3783,8 @@ mkDupableContWithDmds env _
   where
     thumbsUpPlanA (StrictBind {})              = True
     thumbsUpPlanA (Stop {})                    = True
-    thumbsUpPlanA (Select {})                  = False  -- Not quite sure of this one, but it
-                                                       -- benefits nofib digits-of-e1 quite a bit
+    thumbsUpPlanA (Select {})                  = False -- Using Plan B benefits carryPropagate
+                                                       -- in nofib digits-of-e2
     thumbsUpPlanA (StrictArg {})               = False
     thumbsUpPlanA (CastIt { sc_cont = k })     = thumbsUpPlanA k
     thumbsUpPlanA (TickIt _ k)                 = thumbsUpPlanA k
@@ -3956,7 +3956,7 @@ mkDupableAlt _env case_bndr jfloats (Alt con alt_bndrs alt_rhs_in)
 
 ok_to_dup_alt :: OutId -> [OutVar] -> OutExpr -> Bool
 -- See Note [Duplicating alternatives]
--- and Note [Duplicating join point] esp point (2)
+-- and Note [Duplicating join points] esp point (2)
 ok_to_dup_alt case_bndr alt_bndrs alt_rhs
   | exprIsTrivial alt_rhs
   = True   -- Includes things like (case x of {})



View it on GitLab: https://gitlab.haskell.org/ghc/ghc/-/commit/2687f3950d8f3f0d7f9e3d8f17e4ab9adf6ad09e

-- 
View it on GitLab: https://gitlab.haskell.org/ghc/ghc/-/commit/2687f3950d8f3f0d7f9e3d8f17e4ab9adf6ad09e
You're receiving this email because of your account on gitlab.haskell.org.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.haskell.org/pipermail/ghc-commits/attachments/20230727/f7717a7e/attachment-0001.html>