[Git][ghc/ghc][wip/romes/fix-toolchain-selection] configure: Default missing options to False when preparing ghc-toolchain Targets

Rodrigo Mesquita (@alt-romes) gitlab at gitlab.haskell.org
Tue Jul 25 10:11:26 UTC 2023



Rodrigo Mesquita pushed to branch wip/romes/fix-toolchain-selection at Glasgow Haskell Compiler / GHC


Commits:
31677778 by Rodrigo Mesquita at 2023-07-25T11:11:19+01:00
configure: Default missing options to False when preparing ghc-toolchain Targets

This commit fixes building ghc with 9.2 as the boostrap compiler.

The ghc-toolchain patch assumed all _STAGE0 options were available, and
forgot to account for this missing information in 9.2.

Ghc 9.2 does not have in settings whether ar supports -l, hence can't
report it with --info (unliked 9.4 upwards).

The fix is to default the missing information (we default "ar supports
-l" and other missing options to False)

- - - - -


1 changed file:

- m4/prep_target_file.m4


Changes:

=====================================
m4/prep_target_file.m4
=====================================
@@ -58,7 +58,8 @@ AC_DEFUN([PREP_BOOLEAN],[
           $1Bool=False
           ;;
         *)
-          AC_MSG_WARN([m4/prep_target_file.m4: Expecting YES/NO but got $$1 in $1])
+          AC_MSG_WARN([m4/prep_target_file.m4: Expecting YES/NO but got $$1 in $1. Defaulting to False.])
+          $1Bool=False
           ;;
     esac
     AC_SUBST([$1Bool])
@@ -78,7 +79,8 @@ AC_DEFUN([PREP_NOT_BOOLEAN],[
           Not$1Bool=False
           ;;
         *)
-          AC_MSG_WARN([m4/prep_target_file.m4: Expecting YES/NO but got $$1 in $1])
+          AC_MSG_WARN([m4/prep_target_file.m4: Expecting YES/NO but got $$1 in $1. Defaulting to False.])
+          Not$1Bool=False
           ;;
     esac
     AC_SUBST([Not$1Bool])



View it on GitLab: https://gitlab.haskell.org/ghc/ghc/-/commit/316777785b0b7e374060d5e55c20aa983bd79ccf

-- 
View it on GitLab: https://gitlab.haskell.org/ghc/ghc/-/commit/316777785b0b7e374060d5e55c20aa983bd79ccf
You're receiving this email because of your account on gitlab.haskell.org.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.haskell.org/pipermail/ghc-commits/attachments/20230725/1c282ac1/attachment-0001.html>


More information about the ghc-commits mailing list