[Git][ghc/ghc][wip/az/locateda-epa-improve-2023-03-27] 21 commits: EPA: Widen anchor when adding a trailingAnn

[Alan Zimmerman (@alanz)]

Alan Zimmerman pushed to branch wip/az/locateda-epa-improve-2023-03-27 at Glasgow Haskell Compiler / GHC


Commits:
2dc7df49 by Alan Zimmerman at 2023-07-15T12:36:42+01:00
EPA: Widen anchor when adding a trailingAnn

- - - - -
e9c192a0 by Alan Zimmerman at 2023-07-15T12:36:42+01:00
EPA: widen more TrailingAnn usages

- - - - -
051d2539 by Alan Zimmerman at 2023-07-15T12:36:42+01:00
EPA: Capture full range for a CaseAlt Match

- - - - -
8ae98393 by Alan Zimmerman at 2023-07-15T12:36:43+01:00
Clean up addTrailingCommaN

Remove unused parameter

- - - - -
7fa212ab by Alan Zimmerman at 2023-07-15T12:36:43+01:00
WIP

- - - - -
32ee2272 by Alan Zimmerman at 2023-07-15T12:36:43+01:00
Fixup after rebase

- - - - -
9e538fc1 by Alan Zimmerman at 2023-07-15T12:36:43+01:00
[EPA] Introduce HasTrailing in ExactPrint

Just plumbed through, not being used yet

- - - - -
72d101fe by Alan Zimmerman at 2023-07-15T12:36:43+01:00
EPA use [TrailingAnn] in enterAnn

And remove it from ExactPrint (LocatedN RdrName)

- - - - -
054418b8 by Alan Zimmerman at 2023-07-15T12:36:43+01:00
EPA Use full range for Anchor, and do not widen for [TrailingAnn]

- - - - -
4fde7d72 by Alan Zimmerman at 2023-07-15T12:36:43+01:00
EPA: Move TrailingAnns from last match to FunBind

- - - - -
1ed51a34 by Alan Zimmerman at 2023-07-15T12:36:43+01:00
EPA: In HsDo, put TrailingAnns at top of LastStmt

- - - - -
e9a24aa4 by Alan Zimmerman at 2023-07-15T12:36:43+01:00
EPA: More extending anchors to full span in Parser.y

- - - - -
9c5e7bd9 by Alan Zimmerman at 2023-07-15T12:36:43+01:00
EPA: Move TrailingAnns to the top of FieldOcc

- - - - -
579a7351 by Alan Zimmerman at 2023-07-15T12:36:43+01:00
EPA: Fix simple tests

- - - - -
d9162edd by Alan Zimmerman at 2023-07-15T12:36:43+01:00
EPA: do not convert comments to deltas when balancing.

It seems its not needed with the new approach

- - - - -
b0fa35dc by Alan Zimmerman at 2023-07-15T12:36:43+01:00
EPA: Improve annotation management in getMonoBind

Ensure the LHsDecl for a FunBind has the correct leading comments and
trailing annotations.

See the added note for details.

- - - - -
8620d7c7 by Alan Zimmerman at 2023-07-15T12:36:43+01:00
EPA: deal with fallout from getMonoBind

- - - - -
5eb51bf3 by Alan Zimmerman at 2023-07-15T12:36:43+01:00
EPA fix captureLineSpacing

- - - - -
3068ffbd by Alan Zimmerman at 2023-07-15T12:36:43+01:00
EPA print any comments in the span before exiting it

- - - - -
f4c7ac07 by Alan Zimmerman at 2023-07-15T12:36:43+01:00
EPA: getting rid of tweakDelta

WIP at present

- - - - -
86109835 by Alan Zimmerman at 2023-07-15T15:23:08+01:00
EPA: Add '=>' to TrailingAnn

This is used as a trailing annotation in a context.
Add its normal and unicode variants.

Note that we keep the parsed representation the same, but make use of
it when exact printing.

- - - - -


12 changed files:

- compiler/GHC/Hs/Type.hs
- compiler/GHC/Hs/Utils.hs
- compiler/GHC/Iface/Ext/Ast.hs
- compiler/GHC/Parser.y
- compiler/GHC/Parser/Annotation.hs
- compiler/GHC/Parser/PostProcess.hs
- compiler/GHC/ThToHs.hs
- compiler/GHC/Unit/Module/Warnings.hs
- testsuite/tests/ghc-api/exactprint/Test20239.stderr
- testsuite/tests/haddock/should_compile_flag_haddock/T17544.stderr
- testsuite/tests/haddock/should_compile_flag_haddock/T17544_kw.stderr
- testsuite/tests/parser/should_compile/DumpParsedAst.stderr


The diff was not included because it is too large.


View it on GitLab: https://gitlab.haskell.org/ghc/ghc/-/compare/63cb29c6118445b0342a2c21c72ca76cbd97d3ac...86109835e775144a72d7f4ecf09dc5d83a44f08f

-- 
View it on GitLab: https://gitlab.haskell.org/ghc/ghc/-/compare/63cb29c6118445b0342a2c21c72ca76cbd97d3ac...86109835e775144a72d7f4ecf09dc5d83a44f08f
You're receiving this email because of your account on gitlab.haskell.org.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.haskell.org/pipermail/ghc-commits/attachments/20230715/bbab2199/attachment.html>