[Git][ghc/ghc][wip/T22717] 5 commits: Detect family instance orphans correctly

[sheaf (@sheaf)]

sheaf pushed to branch wip/T22717 at Glasgow Haskell Compiler / GHC


Commits:
4ee1395b by Simon Peyton Jones at 2023-01-26T16:20:22+01:00
Detect family instance orphans correctly

We were treating a type-family instance as a non-orphan if there
was a type constructor on it /right-hand side/ that was local. Boo!
Utterly wrong. With this patch, we correctly check the /left-hand side/
instead!

Fixes #22217

- - - - -
aa982439 by Simon Peyton Jones at 2023-01-26T16:24:49+01:00
Report family instance orphans correctly

This fixes the fact that we were not reporting orphan family instance
at all. The fix here is easy, but touches a bit of code. I refactored
the code to be much more similar to the way that class instances are done:

   - Add a fi_orphan field to FamInst, like the is_orphan field in ClsInst
   - Make newFamInst initialise this field, just like newClsInst
   - And make newFamInst report a warning for an orphan, just like newClsInst
   - I moved newFamInst from GHC.Tc.Instance.Family to GHC.Tc.Utils.Instantiate,
     just like newClsInst.
   - I added mkLocalFamInst to FamInstEnv, just like mkLocalClsInst in InstEnv
   - I added a new error constructor TcRnOrphanFamInst, and renamed
     the existing TcRnOrphanInstance to TcRnOrphanClsInst
   - Ditto SuggestFixOrphanFamInst

Fixes #19773

- - - - -
19063b33 by Simon Peyton Jones at 2023-01-26T16:24:52+01:00
Avoid orphans in STG

This patch removes some orphan instances in the STG namespace
by introducing the GHC.Stg.Lift.Types module, which allows various
type family instances to be moved to GHC.Stg.Syntax, avoiding orphan
instances.

- - - - -
700eb198 by Simon Peyton Jones at 2023-01-26T16:24:53+01:00
Avoid orphans in the parser

This moves Anno instances for PatBuilder from GHC.Parser.PostProcess
to GHC.Parser.Types to avoid orphans.

- - - - -
67f904ac by Simon Peyton Jones at 2023-01-26T16:24:53+01:00
Accept an orphan declaration (sadly)

This accepts the orphan type family instance

  type instance DsForeignHook = ...

in GHC.HsToCore.Types.

See Note [The Decoupling Abstract Data Hack] in GHC.Driver.Hooks

- - - - -


30 changed files:

- compiler/GHC.hs
- compiler/GHC/Core.hs
- compiler/GHC/Core/FVs.hs
- compiler/GHC/Core/FamInstEnv.hs
- compiler/GHC/Core/InstEnv.hs
- compiler/GHC/Driver/Hooks.hs
- compiler/GHC/HsToCore/Types.hs
- compiler/GHC/Iface/Make.hs
- compiler/GHC/IfaceToCore.hs
- compiler/GHC/Parser/PostProcess.hs
- compiler/GHC/Parser/Types.hs
- compiler/GHC/Runtime/Eval.hs
- compiler/GHC/Stg/InferTags/TagSig.hs
- compiler/GHC/Stg/InferTags/Types.hs
- compiler/GHC/Stg/Lift/Analysis.hs
- + compiler/GHC/Stg/Lift/Types.hs
- compiler/GHC/Stg/Pipeline.hs
- compiler/GHC/Stg/Syntax.hs
- compiler/GHC/Tc/Deriv/Generate.hs
- compiler/GHC/Tc/Deriv/Generics.hs
- compiler/GHC/Tc/Errors/Ppr.hs
- compiler/GHC/Tc/Errors/Types.hs
- compiler/GHC/Tc/Instance/Family.hs
- compiler/GHC/Tc/Module.hs
- compiler/GHC/Tc/TyCl/Class.hs
- compiler/GHC/Tc/Utils/Instantiate.hs
- compiler/GHC/Tc/Utils/TcType.hs
- compiler/GHC/Types/Hint.hs
- compiler/GHC/Types/Hint/Ppr.hs
- compiler/ghc.cabal.in


The diff was not included because it is too large.


View it on GitLab: https://gitlab.haskell.org/ghc/ghc/-/compare/f5c31bc565bff30f9b858086e1835b482cf10ae5...67f904ac139d2af4f0051e193d83103b1899a0b0

-- 
View it on GitLab: https://gitlab.haskell.org/ghc/ghc/-/compare/f5c31bc565bff30f9b858086e1835b482cf10ae5...67f904ac139d2af4f0051e193d83103b1899a0b0
You're receiving this email because of your account on gitlab.haskell.org.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.haskell.org/pipermail/ghc-commits/attachments/20230126/c3452a58/attachment.html>