[Git][ghc/ghc][master] Do not collect compile-time metrics for T21839r

[Marge Bot (@marge-bot)]

Marge Bot pushed to branch master at Glasgow Haskell Compiler / GHC


Commits:
eee3bf05 by Matthew Craven at 2023-01-23T21:46:41-05:00
Do not collect compile-time metrics for T21839r

...the testsuite doesn't handle this properly since it
also collects run-time metrics.  Compile-time metrics
for this test are already tracked via T21839c.

Metric Decrease:
    T21839r

- - - - -


3 changed files:

- − testsuite/tests/perf/compiler/T21839c.stdout
- testsuite/tests/perf/compiler/all.T
- testsuite/tests/perf/should_run/all.T


Changes:

=====================================
testsuite/tests/perf/compiler/T21839c.stdout deleted
=====================================
@@ -1 +0,0 @@
-10008


=====================================
testsuite/tests/perf/compiler/all.T
=====================================
@@ -646,6 +646,9 @@ test ('T20261',
       [''])
 
 # Track perf of generics based binary instances
+# See also T21839r in perf/should_run... the testsuite
+# does not sensibly handle one test acting as both
+# a compile-time and a run-time performance test
 test('T21839c',
     [   collect_compiler_stats('all', 10),
         collect_compiler_stats('bytes allocated', 1),


=====================================
testsuite/tests/perf/should_run/all.T
=====================================
@@ -400,11 +400,13 @@ test('T19347',
     compile_and_run,
     ['-O'])
 
-# Track perf of generics based binary instances
+# Track runtime perf of generics based binary instances
+# See also T21839c in perf/compiler... the testsuite
+# does not sensibly handle one test acting as both
+# a compile-time and a run-time performance test
 test('T21839r',
     [   collect_stats('bytes allocated', 10),
         collect_runtime_residency(10),
-        collect_compiler_stats('bytes allocated', 1),
         only_ways(['normal'])],
     compile_and_run,
     ['-O'])



View it on GitLab: https://gitlab.haskell.org/ghc/ghc/-/commit/eee3bf05f8ee29ae6c01a29db9502a390720f3b5

-- 
View it on GitLab: https://gitlab.haskell.org/ghc/ghc/-/commit/eee3bf05f8ee29ae6c01a29db9502a390720f3b5
You're receiving this email because of your account on gitlab.haskell.org.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.haskell.org/pipermail/ghc-commits/attachments/20230123/3352d26d/attachment-0001.html>