[Git][ghc/ghc][wip/mmtk-ben] Refactor marking of static objects

[Ben Gamari (@bgamari)]

Ben Gamari pushed to branch wip/mmtk-ben at Glasgow Haskell Compiler / GHC


Commits:
be34ab23 by Ben Gamari at 2023-01-04T16:49:34-05:00
Refactor marking of static objects

- - - - -


1 changed file:

- rts/mmtk/mmtk/src/active_plan.rs


Changes:

=====================================
rts/mmtk/mmtk/src/active_plan.rs
=====================================
@@ -11,15 +11,44 @@ use crate::stg_closures::*;
 use crate::stg_info_table::*;
 
 
-static mut STATIC_FLAG: bool = false;
+enum StaticFlag { A, B }
+
+impl StaticFlag {
+    pub fn negate(self) -> self {
+        use StaticFlag::*;
+        match STATIC_FLAG {
+            A => B,
+            B => A
+        }
+    }
+}
+
+/// The tag encoded in the low bits of CAF's `static_link` field.
+/// See Note [STATIC_LINK fields].
+enum StaticTag {
+    NotVisited,          // Tag value 0
+    Visited(StaticFlag), // Tag values 1, 2
+    NotACaf              // Tag value 3
+}
+
+fn get_static_tag(r: const TaggedClosureRef) -> StaticTag {
+    match r.get_tag() {
+        0 => NotVisited,
+        1 => Visited(A),
+        2 => Visited(B),
+        3 => NotACaf,
+    }
+}
+
+static mut STATIC_FLAG: StaticFlag = StaticFlag::A;
 
 pub fn bump_static_flag() {
     unsafe {
-        STATIC_FLAG = !STATIC_FLAG;
+        STATIC_FLAG = STATIC_FLAG.negate();
     }
 }
 
-fn get_static_flag() -> bool {
+fn get_static_flag() -> StaticFlag {
     unsafe {
         STATIC_FLAG
     }
@@ -77,9 +106,12 @@ impl ActivePlan<GHCVM> for VMActivePlan {
         // Modelled after evacuate_static_object, returns true if this 
         // is the first time the object has been visited in this GC.
         let mut evacuate_static = |static_link: &mut TaggedClosureRef| -> bool {
-            let cur_static_flag = if get_static_flag() { 2 } else { 1 };
-            let prev_static_flag = if get_static_flag() { 1 } else { 2 };
-            let object_visited: bool = (static_link.get_tag() | prev_static_flag) != 3;
+            let cur_static_flag = get_static_flag();
+            let object_visited: bool = match get_static_tag(static_link) {
+                NotACaf => True,
+                NotVisited => False,
+                Visited(flag) => flag == cur_static_flag,
+            };
             if !object_visited {
                 // N.B. We don't need to maintain a list of static objects, therefore ZERO
                 *static_link = TaggedClosureRef::from_address(Address::ZERO).set_tag(cur_static_flag);
@@ -129,4 +161,4 @@ impl ActivePlan<GHCVM> for VMActivePlan {
 pub fn enqueue_roots<Q: ObjectQueue>(queue: &mut Q, object: ObjectReference)
 {
     queue.enqueue(object);
-}
\ No newline at end of file
+}



View it on GitLab: https://gitlab.haskell.org/ghc/ghc/-/commit/be34ab239bd53fa9ec85482df742b0d0df70250a

-- 
View it on GitLab: https://gitlab.haskell.org/ghc/ghc/-/commit/be34ab239bd53fa9ec85482df742b0d0df70250a
You're receiving this email because of your account on gitlab.haskell.org.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.haskell.org/pipermail/ghc-commits/attachments/20230104/5d24ab32/attachment-0001.html>