[Git][ghc/ghc][master] Explicit migration timeline for loopy SC solving
Marge Bot (@marge-bot)
gitlab at gitlab.haskell.org
Thu Feb 23 22:00:31 UTC 2023
Marge Bot pushed to branch master at Glasgow Haskell Compiler / GHC
Commits:
e9e7a00d by sheaf at 2023-02-23T17:00:01-05:00
Explicit migration timeline for loopy SC solving
This patch updates the warning message introduced in commit
9fb4ca89bff9873e5f6a6849fa22a349c94deaae to specify an explicit
migration timeline: GHC will no longer support this constraint solving
mechanism starting from GHC 9.10.
Fixes #22912
- - - - -
8 changed files:
- compiler/GHC/Tc/Errors/Ppr.hs
- testsuite/tests/typecheck/should_compile/T20666b.stderr
- testsuite/tests/typecheck/should_compile/T22891.stderr
- testsuite/tests/typecheck/should_compile/T22912.stderr
- testsuite/tests/typecheck/should_fail/T20666.stderr
- testsuite/tests/typecheck/should_fail/T20666a.stderr
- testsuite/tests/typecheck/should_fail/T6161.stderr
- testsuite/tests/typecheck/should_fail/tcfail223.stderr
Changes:
=====================================
compiler/GHC/Tc/Errors/Ppr.hs
=====================================
@@ -1321,7 +1321,7 @@ instance Diagnostic TcRnMessage where
, nest 2 $ pprCtOrigin (ctLocOrigin wtd_loc) <> comma
, text "in a way that might turn out to loop at runtime." ]
warning
- = vcat [ text "Future versions of GHC will turn this warning into an error." ]
+ = vcat [ text "Starting from GHC 9.10, this warning will turn into an error." ]
user_manual =
vcat [ text "See the user manual, § Undecidable instances and loopy superclasses." ]
=====================================
testsuite/tests/typecheck/should_compile/T20666b.stderr
=====================================
@@ -3,7 +3,7 @@ T20666b.hs:11:10: warning: [GHC-36038] [-Wloopy-superclass-solve (in -Wdefault)]
I am solving the constraint ‘Eq (F [a])’,
arising from the superclasses of an instance declaration,
in a way that might turn out to loop at runtime.
- Future versions of GHC will turn this warning into an error.
+ Starting from GHC 9.10, this warning will turn into an error.
See the user manual, § Undecidable instances and loopy superclasses.
Suggested fix:
Add the constraint ‘Eq (F [a])’ to the instance context,
=====================================
testsuite/tests/typecheck/should_compile/T22891.stderr
=====================================
@@ -3,7 +3,7 @@ T22891.hs:9:10: warning: [GHC-36038] [-Wloopy-superclass-solve (in -Wdefault)]
I am solving the constraint ‘Foo f’,
arising from the superclasses of an instance declaration,
in a way that might turn out to loop at runtime.
- Future versions of GHC will turn this warning into an error.
+ Starting from GHC 9.10, this warning will turn into an error.
See the user manual, § Undecidable instances and loopy superclasses.
Suggested fix:
Add the constraint ‘Foo f’ to the instance context,
=====================================
testsuite/tests/typecheck/should_compile/T22912.stderr
=====================================
@@ -4,7 +4,7 @@ T22912.hs:17:16: warning: [GHC-36038] [-Wloopy-superclass-solve (in -Wdefault)]
arising from the head of a quantified constraint
arising from a use of ‘go’,
in a way that might turn out to loop at runtime.
- Future versions of GHC will turn this warning into an error.
+ Starting from GHC 9.10, this warning will turn into an error.
See the user manual, § Undecidable instances and loopy superclasses.
Suggested fix:
Add the constraint ‘Implies
=====================================
testsuite/tests/typecheck/should_fail/T20666.stderr
=====================================
@@ -3,7 +3,7 @@ T20666.hs:13:10: warning: [GHC-36038] [-Wloopy-superclass-solve (in -Wdefault)]
I am solving the constraint ‘Show (T c)’,
arising from the superclasses of an instance declaration,
in a way that might turn out to loop at runtime.
- Future versions of GHC will turn this warning into an error.
+ Starting from GHC 9.10, this warning will turn into an error.
See the user manual, § Undecidable instances and loopy superclasses.
Suggested fix:
Add the constraint ‘Show (T c)’ to the instance context,
@@ -13,7 +13,7 @@ T20666.hs:17:10: warning: [GHC-36038] [-Wloopy-superclass-solve (in -Wdefault)]
I am solving the constraint ‘Show (T c)’,
arising from the superclasses of an instance declaration,
in a way that might turn out to loop at runtime.
- Future versions of GHC will turn this warning into an error.
+ Starting from GHC 9.10, this warning will turn into an error.
See the user manual, § Undecidable instances and loopy superclasses.
Suggested fix:
Add the constraint ‘Show (T c)’ to the instance context,
=====================================
testsuite/tests/typecheck/should_fail/T20666a.stderr
=====================================
@@ -3,7 +3,7 @@ T20666a.hs:11:10: warning: [GHC-36038] [-Wloopy-superclass-solve (in -Wdefault)]
I am solving the constraint ‘Eq (F [a])’,
arising from the superclasses of an instance declaration,
in a way that might turn out to loop at runtime.
- Future versions of GHC will turn this warning into an error.
+ Starting from GHC 9.10, this warning will turn into an error.
See the user manual, § Undecidable instances and loopy superclasses.
Suggested fix:
Add the constraint ‘Eq (F [a])’ to the instance context,
=====================================
testsuite/tests/typecheck/should_fail/T6161.stderr
=====================================
@@ -3,7 +3,7 @@ T6161.hs:19:10: warning: [GHC-36038] [-Wloopy-superclass-solve (in -Wdefault)]
I am solving the constraint ‘Super (Fam a)’,
arising from the superclasses of an instance declaration,
in a way that might turn out to loop at runtime.
- Future versions of GHC will turn this warning into an error.
+ Starting from GHC 9.10, this warning will turn into an error.
See the user manual, § Undecidable instances and loopy superclasses.
Suggested fix:
Add the constraint ‘Super (Fam a)’ to the instance context,
=====================================
testsuite/tests/typecheck/should_fail/tcfail223.stderr
=====================================
@@ -3,7 +3,7 @@ tcfail223.hs:10:10: warning: [GHC-36038] [-Wloopy-superclass-solve (in -Wdefault
I am solving the constraint ‘Class1 a’,
arising from the superclasses of an instance declaration,
in a way that might turn out to loop at runtime.
- Future versions of GHC will turn this warning into an error.
+ Starting from GHC 9.10, this warning will turn into an error.
See the user manual, § Undecidable instances and loopy superclasses.
Suggested fix:
Add the constraint ‘Class1 a’ to the instance context,
View it on GitLab: https://gitlab.haskell.org/ghc/ghc/-/commit/e9e7a00da2c5963a53dbcedaec793400fde07563
--
View it on GitLab: https://gitlab.haskell.org/ghc/ghc/-/commit/e9e7a00da2c5963a53dbcedaec793400fde07563
You're receiving this email because of your account on gitlab.haskell.org.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.haskell.org/pipermail/ghc-commits/attachments/20230223/a3130a7a/attachment-0001.html>
More information about the ghc-commits
mailing list