[Git][ghc/ghc][wip/int-index/visibility-check] Apply 4 suggestion(s) to 2 file(s)

[Vladislav Zavialov (@int-index)]

Vladislav Zavialov pushed to branch wip/int-index/visibility-check at Glasgow Haskell Compiler / GHC


Commits:
89801d0e by Ryan Scott at 2023-02-05T08:52:16+00:00
Apply 4 suggestion(s) to 2 file(s)
- - - - -


2 changed files:

- compiler/GHC/Tc/Errors/Ppr.hs
- compiler/GHC/Tc/Errors/Types.hs


Changes:

=====================================
compiler/GHC/Tc/Errors/Ppr.hs
=====================================
@@ -1228,7 +1228,7 @@ instance Diagnostic TcRnMessage where
          2 (text "thus:" <+> (parens (ppr expr)))
     TcRnIncompatibleForallVisibility act exp ->
       mkSimpleDecorated $
-        hang (text "Visibility of forall-bound variables is not compatible") 2 $
+        hang (text "Visibilities of forall-bound variables are not compatible") 2 $
         vcat
           [ text "Expected:" <+> ppr exp
           , text "  Actual:" <+> ppr act ]
@@ -2981,7 +2981,7 @@ pprCannotUnifyVariableReason ctxt (RepresentationalEq tv_info mb_coercible_msg)
   = pprTyVarInfo ctxt tv_info
   $$ maybe empty pprCoercibleMsg mb_coercible_msg
 pprCannotUnifyVariableReason _ (ForallKindVisDiff tv1 ty2)
-  = hang (text "Visibility of forall-bound variables in kinds differs") 2 $
+  = hang (text "Visibilities of forall-bound variables in kinds differ") 2 $
     vcat [ ppr tv1 <+> text "::" <+> ppr (tyVarKind tv1)
          , ppr ty2 <+> text "::" <+> ppr (typeKind ty2) ]
 


=====================================
compiler/GHC/Tc/Errors/Types.hs
=====================================
@@ -2926,7 +2926,7 @@ data TcRnMessage where
 
   {-| TcRnIncompatibleForallVisibility is an error that occurs when
       the expected and actual types contain forall-bound variables
-      that have incompatible visibility.
+      that have incompatible visibilities.
 
       Example:
         type family Invis :: Type -> forall a. a
@@ -3805,7 +3805,7 @@ data CannotUnifyVariableReason
   | RepresentationalEq TyVarInfo (Maybe CoercibleMsg)
 
   -- | Can't unify a kind-polymorphic type variable with a type
-  -- due to visibility difference of forall-bound variables in their kinds.
+  -- due to differences in visibility between forall-bound variables in their kinds.
   --
   -- Example:
   --    data V k (a :: k) = MkV



View it on GitLab: https://gitlab.haskell.org/ghc/ghc/-/commit/89801d0ed204d8c80e463aa9f0485cf708b2823b

-- 
View it on GitLab: https://gitlab.haskell.org/ghc/ghc/-/commit/89801d0ed204d8c80e463aa9f0485cf708b2823b
You're receiving this email because of your account on gitlab.haskell.org.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.haskell.org/pipermail/ghc-commits/attachments/20230205/2c5baf04/attachment-0001.html>