[Git][ghc/ghc][wip/marge_bot_batch_merge_job] 20 commits: cmm: Introduce MO_RelaxedRead

Thu Dec 28 05:58:36 UTC 2023

Marge Bot pushed to branch wip/marge_bot_batch_merge_job at Glasgow Haskell Compiler / GHC

Commits:
a8c6e0ee by Ben Gamari at 2023-12-28T00:58:20-05:00
cmm: Introduce MO_RelaxedRead

In hand-written Cmm it can sometimes be necessary to atomically load
from memory deep within an expression (e.g. see the `CHECK_GC` macro).
This MachOp provides a convenient way to do so without breaking the
expression into multiple statements.

- - - - -
3c9f3f72 by Ben Gamari at 2023-12-28T00:58:20-05:00
codeGen: Use relaxed accesses in ticky bumping

- - - - -
64049dc1 by Ben Gamari at 2023-12-28T00:58:20-05:00
base: use atomic write when updating timer manager

- - - - -
2d8b7b8b by Ben Gamari at 2023-12-28T00:58:20-05:00
Use relaxed atomics to manipulate TSO status fields

- - - - -
57d219cf by Ben Gamari at 2023-12-28T00:58:20-05:00
rts: Add necessary barriers when manipulating TSO owner

- - - - -
db1c4c99 by Ben Gamari at 2023-12-28T00:58:20-05:00
rts: Use `switch` to branch on why_blocked

This is a semantics-preserving refactoring.

- - - - -
ad5316bf by Ben Gamari at 2023-12-28T00:58:20-05:00
rts: Fix synchronization on thread blocking state

We now use a release barrier whenever we update a thread's blocking
state. This required widening StgTSO.why_blocked as AArch64 does not
support atomic writes on 16-bit values.

- - - - -
cc724782 by Ben Gamari at 2023-12-28T00:58:20-05:00
rts: Fix data race in threadPaused

This only affects an assertion in the debug RTS and only needs relaxed
ordering.

- - - - -
20ce02f1 by Ben Gamari at 2023-12-28T00:58:20-05:00
rts: Fix data race in threadStatus#

- - - - -
c72ae94e by Ben Gamari at 2023-12-28T00:58:20-05:00
rts: Fix data race in Interpreter's preemption check

- - - - -
bed1160a by Ben Gamari at 2023-12-28T00:58:20-05:00
rts/Messages: Fix data race

- - - - -
a6e8e72a by Ben Gamari at 2023-12-28T00:58:20-05:00
rts/Prof: Fix data race

- - - - -
3d0d0855 by Ben Gamari at 2023-12-28T00:58:20-05:00
rts: Use relaxed ordering on dirty/clean info tables updates

When changing the dirty/clean state of a mutable object we needn't have
any particular ordering.

- - - - -
5e9715f2 by Ben Gamari at 2023-12-28T00:58:20-05:00
codeGen: Use relaxed-read in closureInfoPtr

- - - - -
dae4ec32 by Ben Gamari at 2023-12-28T00:58:20-05:00
STM: Use acquire loads when possible

Full sequential consistency is not needed here.

- - - - -
2fb117b5 by Ben Gamari at 2023-12-28T00:58:20-05:00
rts: Use fence rather than redundant load

Previously we would use an atomic load to ensure acquire ordering.
However, we now have `ACQUIRE_FENCE_ON`, which allows us to express this
more directly.

- - - - -
a99ba2b2 by Ben Gamari at 2023-12-28T00:58:20-05:00
rts: Fix data races in profiling timer

- - - - -
e54f8d1d by Ben Gamari at 2023-12-28T00:58:20-05:00
Add Note [C11 memory model]

- - - - -
66864b52 by Ben Gamari at 2023-12-28T00:58:21-05:00
genSym: Reimplement via CAS on 32-bit platforms

Previously the remaining use of the C implementation on 32-bit platforms
resulted in a subtle bug, #24261. This was due to the C object (which
used the RTS's `atomic_inc64` macro) being compiled without `-threaded`
yet later being used in a threaded compiler.

Side-step this issue by using the pure Haskell `genSym` implementation on
all platforms. This required implementing `fetchAddWord64Addr#` in terms
of CAS on 64-bit platforms.

- - - - -
11678057 by Xiaoyan Ren at 2023-12-28T00:58:24-05:00
Do not color the diagnostic code in error messages (#24172)

- - - - -

30 changed files:

- compiler/GHC/Cmm/Expr.hs
- compiler/GHC/Cmm/Info.hs
- compiler/GHC/Cmm/MachOp.hs
- compiler/GHC/Cmm/Parser.y
- compiler/GHC/Cmm/ThreadSanitizer.hs
- compiler/GHC/CmmToAsm/AArch64/CodeGen.hs
- compiler/GHC/CmmToAsm/PPC/CodeGen.hs
- compiler/GHC/CmmToAsm/Wasm/FromCmm.hs
- compiler/GHC/CmmToAsm/X86/CodeGen.hs
- compiler/GHC/CmmToC.hs
- compiler/GHC/CmmToLlvm/CodeGen.hs
- compiler/GHC/StgToCmm/Ticky.hs
- compiler/GHC/StgToCmm/Utils.hs
- compiler/GHC/Types/Error.hs
- compiler/GHC/Types/Unique/Supply.hs
- compiler/cbits/genSym.c
- compiler/jsbits/genSym.js
- libraries/base/src/GHC/Event/Thread.hs
- rts/Exception.cmm
- rts/HeapStackCheck.cmm
- rts/Interpreter.c
- rts/Messages.c
- rts/PrimOps.cmm
- rts/Proftimer.c
- rts/RaiseAsync.c
- rts/STM.c
- rts/Schedule.c
- rts/StgMiscClosures.cmm
- rts/StgStartup.cmm
- rts/ThreadPaused.c

The diff was not included because it is too large.

View it on GitLab: https://gitlab.haskell.org/ghc/ghc/-/compare/3f93b494a0d31b26cb83ff222952f4023649c8ec...116780576bda7ffeeed7a160e58b79a999815e80

-- 
View it on GitLab: https://gitlab.haskell.org/ghc/ghc/-/compare/3f93b494a0d31b26cb83ff222952f4023649c8ec...116780576bda7ffeeed7a160e58b79a999815e80
You're receiving this email because of your account on gitlab.haskell.org.

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.haskell.org/pipermail/ghc-commits/attachments/20231228/2c7b218b/attachment.html>