[Git][ghc/ghc][wip/marge_bot_batch_merge_job] 15 commits: testsuite: add test for #23944

Thu Dec 7 23:44:40 UTC 2023

Marge Bot pushed to branch wip/marge_bot_batch_merge_job at Glasgow Haskell Compiler / GHC

Commits:
90dfa9e1 by Zubin Duggal at 2023-12-07T18:43:49-05:00
testsuite: add test for #23944

- - - - -
3335071c by Zubin Duggal at 2023-12-07T18:43:49-05:00
driver: Only run a dynamic-too pipeline if object files are going to be generated

Otherwise we run into a panic in hscMaybeWriteIface: "Unexpected DT_Dyn state
when writing simple interface" when dynamic-too is enabled

We could remove the panic and just write the interface even if the state is `DT_Dyn`,
but it seems pointless to run the pipeline twice when `hscMaybeWriteIface` is already
designed to write both `hi` and `dyn_hi` files if dynamic-too is enabled.

Fixes #23944.

- - - - -
ea367904 by Zubin Duggal at 2023-12-07T18:43:50-05:00
driver: Ensure we actually clear the interactive context before reloading

Previously we called discardIC, but immediately after set the session
back to an old HscEnv that still contained the IC

Partially addresses #24107
Fixes #23405

- - - - -
354bbf27 by Zubin Duggal at 2023-12-07T18:43:50-05:00
driver: Ensure we force the lookup of old build artifacts before returning the build plan

This prevents us from retaining all previous build artifacts in memory until a
recompile finishes, instead only retaining the exact artifacts we need.

Fixes #24118

- - - - -
27486891 by Zubin Duggal at 2023-12-07T18:43:50-05:00
testsuite: add test for #24118 and #24107

MultiLayerModulesDefsGhci was not able to catch the leak because it uses
:l which discards the previous environment.

Using :r catches both of these leaks

- - - - -
7b2c077a by Zubin Duggal at 2023-12-07T18:43:50-05:00
compiler: Add some strictness annotations to ImportSpec and related constructors
This prevents us from retaining entire HscEnvs.

Force these ImportSpecs when forcing the GlobalRdrEltX

Adds an NFData instance for Bag

Fixes #24107

- - - - -
03789b49 by Zubin Duggal at 2023-12-07T18:43:50-05:00
compiler: Force IfGlobalRdrEnv in NFData instance.

- - - - -
70411d07 by Simon Peyton Jones at 2023-12-07T18:43:50-05:00
Improve duplicate elimination in SpecConstr

This partially fixes #24229.

See the new Note [Pattern duplicate elimination] in SpecConstr

- - - - -
da7b278a by Simon Peyton Jones at 2023-12-07T18:43:51-05:00
Make SpecConstr deal with casts better

This patch does two things, to fix #23209:

* It improves SpecConstr so that it no longer quantifies over
  coercion variables.  See Note [SpecConstr and casts]

* It improves the rule matcher to deal nicely with the case where
  the rule does not quantify over coercion variables, but the the
  template has a cast in it.  See Note [Casts in the template]

- - - - -
d639549f by Zubin Duggal at 2023-12-07T18:43:51-05:00
driver: Don't lose track of nodes when we fail to resolve cycles

The nodes that take part in a cycle should include both hs-boot and hs files,
but when we fail to resolve a cycle, we were only counting the nodes from the
graph without boot files.

Fixes #24196

- - - - -
7a9cdad3 by Zubin Duggal at 2023-12-07T18:43:52-05:00
testsuite: Skip MultiLayerModulesTH_OneShot on darwin

See #24177

- - - - -
ed186746 by Wendao Lee at 2023-12-07T18:43:55-05:00
docs(Data.Char):Add more detailed descriptions for some functions

Related changed function's docs:

-GHC.Unicode.isAlpha
-GHC.Unicode.isPrint
-GHC.Unicode.isAlphaNum

Add more details for what the function will return.

Co-authored-by: Bodigrim <andrew.lelechenko at gmail.com>

- - - - -
e8131379 by Malik Ammar Faisal at 2023-12-07T18:43:58-05:00
Fix float parsing in GHC Cmm Lexer

Add test case for bug #24224

- - - - -
87e7fd75 by Simon Peyton Jones at 2023-12-07T18:43:59-05:00
Comments only in FloatIn

Relevant to #3458

- - - - -
886d86a0 by Simon Peyton Jones at 2023-12-07T18:43:59-05:00
Comments only in SpecConstr

- - - - -

30 changed files:

- compiler/GHC/Cmm/Lexer.x
- compiler/GHC/Core/Opt/FloatIn.hs
- compiler/GHC/Core/Opt/Simplify/Env.hs
- compiler/GHC/Core/Opt/SpecConstr.hs
- compiler/GHC/Core/Rules.hs
- compiler/GHC/Core/SimpleOpt.hs
- compiler/GHC/Core/Subst.hs
- compiler/GHC/Core/TyCo/Subst.hs
- compiler/GHC/Core/Type.hs
- compiler/GHC/Core/Unify.hs
- compiler/GHC/Data/Bag.hs
- compiler/GHC/Driver/Make.hs
- compiler/GHC/Driver/Pipeline.hs
- compiler/GHC/Tc/Utils/TcType.hs
- compiler/GHC/Types/Name/Reader.hs
- compiler/GHC/Unit/Module/ModIface.hs
- libraries/base/src/GHC/Unicode.hs
- + testsuite/tests/cmm/should_compile/T24224.cmm
- + testsuite/tests/cmm/should_compile/T24224.stderr
- testsuite/tests/cmm/should_compile/all.T
- + testsuite/tests/driver/T23944.hs
- + testsuite/tests/driver/T23944.stderr
- + testsuite/tests/driver/T23944A.hs
- + testsuite/tests/driver/T24196/T24196.stderr
- + testsuite/tests/driver/T24196/T24196A.hs
- + testsuite/tests/driver/T24196/T24196A.hs-boot
- + testsuite/tests/driver/T24196/T24196B.hs
- + testsuite/tests/driver/T24196/all.T
- testsuite/tests/driver/all.T
- + testsuite/tests/ghci/T23405/T23405.hs

The diff was not included because it is too large.

View it on GitLab: https://gitlab.haskell.org/ghc/ghc/-/compare/412e120ce7d5528325125dd4250f0c1066b6da88...886d86a0dadcad19d22aa82fb1e4a82fb33aa84f

-- 
View it on GitLab: https://gitlab.haskell.org/ghc/ghc/-/compare/412e120ce7d5528325125dd4250f0c1066b6da88...886d86a0dadcad19d22aa82fb1e4a82fb33aa84f
You're receiving this email because of your account on gitlab.haskell.org.

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.haskell.org/pipermail/ghc-commits/attachments/20231207/4d0c7580/attachment.html>