[Git][ghc/ghc][wip/T21623] 30 commits: Remove source location information from interface files

Fri Oct 28 15:57:50 UTC 2022

Simon Peyton Jones pushed to branch wip/T21623 at Glasgow Haskell Compiler / GHC

Commits:
223e159d by Owen Shepherd at 2022-10-27T13:54:33-04:00
Remove source location information from interface files

This change aims to minimize source location information leaking
into interface files, which makes ABI hashes dependent on the
build location.

The `Binary (Located a)` instance has been removed completely.

It seems that the HIE interface still needs the ability to
serialize SrcSpans, but by wrapping the instances, it should
be a lot more difficult to inadvertently add source location
information.

- - - - -
22e3deb9 by Simon Peyton Jones at 2022-10-27T13:55:37-04:00
Add missing dict binds to specialiser

I had forgotten to add the auxiliary dict bindings to the
/unfolding/ of a specialised function.  This caused #22358,
which reports failures when compiling Hackage packages
     fixed-vector
     indexed-traversable

Regression test T22357 is snarfed from indexed-traversable

- - - - -
a8ed36f9 by Evan Relf at 2022-10-27T13:56:36-04:00
Fix broken link to `async` package

- - - - -
750846cd by Zubin Duggal at 2022-10-28T00:49:22-04:00
Pass correct package db when testing stage1.

It used to pick the db for stage-2 which obviously didn't work.

- - - - -
ad612f55 by Krzysztof Gogolewski at 2022-10-28T00:50:00-04:00
Minor SDoc-related cleanup

* Rename pprCLabel to pprCLabelStyle, and use the name pprCLabel
  for a function using CStyle (analogous to pprAsmLabel)
* Move LabelStyle to the CLabel module, it no longer needs to be in Outputable.
* Move calls to 'text' right next to literals, to make sure the text/str
  rule is triggered.
* Remove FastString/String roundtrip in Tc.Deriv.Generate
* Introduce showSDocForUser', which abstracts over a pattern in
  GHCi.UI

- - - - -
75e6ed35 by Simon Peyton Jones at 2022-10-28T09:03:04+01:00
Start work

Not ready for review

More progress

Wibbles

Stage1 compiles

More wibbles

More wibbles

More -- almost working

Comments

Wibbles

Wibbles

Wibble inlineId

Wibbles

Infinite loop somewhere

More wibbles.  Maybe can build stage2

Make FuNCo a thing by itself

Wibble

Wibble

Wibbles

Fix OptCoercion

Wibble

Wibble to optCoercion

Replace SORT with TYPE and CONSTRAINT

Wibble

Delete unused import

Delete TypeOrConstraint from ghc-prim:GHC.Types

Move from NthCo to SelCo

Wibbles

Wibbles in RepType

Wibble

Add mkWpEta

Really add mkWpEta

Wibble Typeable binds etc

Improve error messages

More wibbles, mainly to error messages

Wibbles

Wibbles to errors

Wibbles

But especially: treat Constraint as Typeable

More wibbles

More changes

* Move role into SelTyCon
* Get rid of mkTcSymCo and friends

Unused variable

Wibbles

Wibble

Accept error message changes

Refactoring...

Remove tc functions like tcKind, tcGetTyVar.

Move tyConsOfType, occCheckExpand to TyCo.FVs.

Introduce GHC.Core.TyCo.Compare

Lots of import changes!

Update haddock submodule (I hope)

Wibbles (notably: actually add GHC.Core.TyCo.Compare)

Wibbles

Wibble output of T16575

Wibbles

More wibbles

Remove infinite loop in T1946

See Note [ForAllTy and type equality]

Deal with rejigConRes

Needs a Note to be written by Richard

Some renaming

AnonArgFlag -->  FunTyFlag
ArgFlag     -->  ForAllTyFlag

Update haddock submodule

Rename TyCoBinder to ForAllTyBinder

Wibbles

Update haddock

Wibble

Update unix submodule

I think I accidentally got it out of sync with HEAD;
this puts it back.

Rename TyCoBinder to PiTyBinder

Update Haddock submodule

Wrap dictionaries in tuples

This fixes the kind bugs in arrow desugaring.  Needs some Notes,
but I want to try CI.

More on boxing data cons

Rebase and update GHC.Tc.Errors/GHC.Tc.Errors.Ppr

Revert accidental changes in SameOccInfo

fixes mod180, tcfail182

Wibbles in error messages

..plus eqType comes from GHC.Core.TyCo.Compare

Wibbles

More wibbles

Reaedy for RAE review

Fix fragile rule setup in GHC.Float

See Note [realToFrac natural-to-float]

Wibbles

More wibbles

Remove unused import

Remove another unused import

Wibbles

Update haddock submodule

Respond to Sam's suggestions

Wibbles

Wibbles

- - - - -
f7198556 by Simon Peyton Jones at 2022-10-28T09:03:04+01:00
Wibbles

- - - - -
0265200c by Simon Peyton Jones at 2022-10-28T09:03:04+01:00
Unused import

- - - - -
b2cf94c8 by Simon Peyton Jones at 2022-10-28T09:03:04+01:00
Better boxingCon_maybe

- - - - -
89fcaf13 by Richard Eisenberg at 2022-10-28T09:03:05+01:00
Improvements to comments, etc., from Richard

- - - - -
a57662d5 by Simon Peyton Jones at 2022-10-28T09:03:05+01:00
Respond to Richard

- - - - -
a44cc500 by Simon Peyton Jones at 2022-10-28T09:03:05+01:00
Improve boxing-data-con API

- - - - -
023674c1 by Simon Peyton Jones at 2022-10-28T09:03:05+01:00
Update error messages

- - - - -
0cbceec2 by Richard Eisenberg at 2022-10-28T09:03:05+01:00
Fix the equality constraint problem

- - - - -
fd5ecadb by Simon Peyton Jones at 2022-10-28T09:03:05+01:00
Wibbles

- - - - -
b3921173 by Simon Peyton Jones at 2022-10-28T09:03:05+01:00
Add isCovertGadtDataCon, fixing build

- - - - -
7270a489 by Simon Peyton Jones at 2022-10-28T09:03:05+01:00
Wibbles

- - - - -
0dde5fc4 by Simon Peyton Jones at 2022-10-28T09:03:05+01:00
Wibbles

- - - - -
87ec6da0 by Simon Peyton Jones at 2022-10-28T09:03:05+01:00
Move RoughMatch code out of Unify into RoughMatch

- - - - -
a0cd2ea4 by Simon Peyton Jones at 2022-10-28T09:03:05+01:00
Wibble

- - - - -
a14ebc44 by Simon Peyton Jones at 2022-10-28T09:03:05+01:00
Wibbles

- - - - -
c4f9739d by Simon Peyton Jones at 2022-10-28T09:03:05+01:00
Update haddock submodule again

- - - - -
047277ec by Simon Peyton Jones at 2022-10-28T09:03:05+01:00
Wibbles, esp in RoughMap

- - - - -
667bb0e3 by Simon Peyton Jones at 2022-10-28T09:03:05+01:00
Upate haddock submodule

- - - - -
29d6e307 by Simon Peyton Jones at 2022-10-28T09:03:05+01:00
Define eqType using tcEqType

A one-line change

- - - - -
d2785c43 by Simon Peyton Jones at 2022-10-28T09:03:05+01:00
Revert "Define eqType using tcEqType"

This reverts commit eaf04c17c6a159ddb70eedd6fb8ab0b4fc180b7a.

Performance got worse!
   T18223 was 60% worse
   T8095      75%
   T12227  9%
   T13386  6%
   T15703  7%
   T5030   8%

- - - - -
666d7bc0 by Simon Peyton Jones at 2022-10-28T09:03:05+01:00
Refactor FunTyFlag

Mostly just renaming stuff

- - - - -
b3d29a46 by Simon Peyton Jones at 2022-10-28T09:03:05+01:00
Wibbles

- - - - -
590c4c9b by Simon Peyton Jones at 2022-10-28T09:03:05+01:00
Wibble

- - - - -
8fb07079 by Simon Peyton Jones at 2022-10-28T16:59:17+01:00
Add FunTyFlags to FunCo

- - - - -

18 changed files:

- compiler/GHC.hs
- compiler/GHC/Builtin/Names.hs
- compiler/GHC/Builtin/Types.hs
- compiler/GHC/Builtin/Types.hs-boot
- compiler/GHC/Builtin/Types/Literals.hs
- compiler/GHC/Builtin/Types/Prim.hs
- − compiler/GHC/Builtin/Types/Prim.hs-boot
- compiler/GHC/Builtin/Uniques.hs
- compiler/GHC/Cmm/CLabel.hs
- compiler/GHC/Cmm/CLabel.hs-boot
- compiler/GHC/Cmm/Parser.y
- compiler/GHC/CmmToAsm/Dwarf/Types.hs
- compiler/GHC/CmmToC.hs
- compiler/GHC/CmmToLlvm/Base.hs
- compiler/GHC/Core/Coercion.hs
- compiler/GHC/Core/Coercion.hs-boot
- compiler/GHC/Core/Coercion/Opt.hs
- compiler/GHC/Core/ConLike.hs

The diff was not included because it is too large.

View it on GitLab: https://gitlab.haskell.org/ghc/ghc/-/compare/ad81a5d1c4b769df0710b41b2e78b4287e02cd22...8fb07079deea7679aa683bd961f96c1fa5c1165b

-- 
View it on GitLab: https://gitlab.haskell.org/ghc/ghc/-/compare/ad81a5d1c4b769df0710b41b2e78b4287e02cd22...8fb07079deea7679aa683bd961f96c1fa5c1165b
You're receiving this email because of your account on gitlab.haskell.org.

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.haskell.org/pipermail/ghc-commits/attachments/20221028/af74cef6/attachment-0001.html>