[Git][ghc/ghc][wip/T21623] 25 commits: Testsuite: more precise test options

Simon Peyton Jones (@simonpj) gitlab at gitlab.haskell.org
Thu Oct 27 12:56:11 UTC 2022 


Simon Peyton Jones pushed to branch wip/T21623 at Glasgow Haskell Compiler / GHC


Commits:
9ab31f42 by Sylvain Henry at 2022-10-26T09:32:20+02:00
Testsuite: more precise test options

Necessary for newer cross-compiling backends (JS, Wasm) that don't
support TH yet.

- - - - -
f60a1a62 by Vladislav Zavialov at 2022-10-26T12:17:14-04:00
Use TcRnVDQInTermType in noNestedForallsContextsErr (#20115)

When faced with VDQ in the type of a term, GHC generates the following
error message:

	Illegal visible, dependent quantification in the type of a term
	(GHC does not yet support this)

Prior to this patch, there were two ways this message could have been
generated and represented:

	1. with the dedicated constructor TcRnVDQInTermType
	    (see check_type in GHC.Tc.Validity)
	2. with the transitional constructor TcRnUnknownMessage
	    (see noNestedForallsContextsErr in GHC.Rename.Utils)

Not only this led to duplication of code generating the final SDoc,
it also made it tricky to track the origin of the error message.

This patch fixes the problem by using TcRnVDQInTermType exclusively.

- - - - -
4667a453 by Simon Peyton Jones at 2022-10-27T10:50:48+01:00
Start work

Not ready for review

More progress

Wibbles

Stage1 compiles

More wibbles

More wibbles

More -- almost working

Comments

Wibbles

Wibbles

Wibble inlineId

Wibbles

Infinite loop somewhere

More wibbles.  Maybe can build stage2

Make FuNCo a thing by itself

Wibble

Wibble

Wibbles

Fix OptCoercion

Wibble

Wibble to optCoercion

Replace SORT with TYPE and CONSTRAINT

Wibble

Delete unused import

Delete TypeOrConstraint from ghc-prim:GHC.Types

Move from NthCo to SelCo

Wibbles

Wibbles in RepType

Wibble

Add mkWpEta

Really add mkWpEta

Wibble Typeable binds etc

Improve error messages

More wibbles, mainly to error messages

Wibbles

Wibbles to errors

Wibbles

But especially: treat Constraint as Typeable

More wibbles

More changes

* Move role into SelTyCon
* Get rid of mkTcSymCo and friends

Unused variable

Wibbles

Wibble

Accept error message changes

Refactoring...

Remove tc functions like tcKind, tcGetTyVar.

Move tyConsOfType, occCheckExpand to TyCo.FVs.

Introduce GHC.Core.TyCo.Compare

Lots of import changes!

Update haddock submodule (I hope)

Wibbles (notably: actually add GHC.Core.TyCo.Compare)

Wibbles

Wibble output of T16575

Wibbles

More wibbles

Remove infinite loop in T1946

See Note [ForAllTy and type equality]

Deal with rejigConRes

Needs a Note to be written by Richard

Some renaming

AnonArgFlag -->  FunTyFlag
ArgFlag     -->  ForAllTyFlag

Update haddock submodule

Rename TyCoBinder to ForAllTyBinder

Wibbles

Update haddock

Wibble

Update unix submodule

I think I accidentally got it out of sync with HEAD;
this puts it back.

Rename TyCoBinder to PiTyBinder

Update Haddock submodule

Wrap dictionaries in tuples

This fixes the kind bugs in arrow desugaring.  Needs some Notes,
but I want to try CI.

More on boxing data cons

Rebase and update GHC.Tc.Errors/GHC.Tc.Errors.Ppr

Revert accidental changes in SameOccInfo

fixes mod180, tcfail182

Wibbles in error messages

..plus eqType comes from GHC.Core.TyCo.Compare

Wibbles

More wibbles

Reaedy for RAE review

Fix fragile rule setup in GHC.Float

See Note [realToFrac natural-to-float]

Wibbles

More wibbles

Remove unused import

Remove another unused import

Wibbles

Update haddock submodule

Respond to Sam's suggestions

Wibbles

Wibbles

- - - - -
4e78dac3 by Simon Peyton Jones at 2022-10-27T10:50:48+01:00
Wibbles

- - - - -
bad22411 by Simon Peyton Jones at 2022-10-27T10:50:48+01:00
Unused import

- - - - -
6df39669 by Simon Peyton Jones at 2022-10-27T10:50:48+01:00
Better boxingCon_maybe

- - - - -
5a52cffd by Richard Eisenberg at 2022-10-27T10:50:48+01:00
Improvements to comments, etc., from Richard

- - - - -
24cf0ab3 by Simon Peyton Jones at 2022-10-27T10:50:48+01:00
Respond to Richard

- - - - -
ce6e212f by Simon Peyton Jones at 2022-10-27T10:50:48+01:00
Improve boxing-data-con API

- - - - -
bddf0335 by Simon Peyton Jones at 2022-10-27T10:50:48+01:00
Update error messages

- - - - -
f4800d11 by Richard Eisenberg at 2022-10-27T10:50:48+01:00
Fix the equality constraint problem

- - - - -
03bb3f8b by Simon Peyton Jones at 2022-10-27T10:50:48+01:00
Wibbles

- - - - -
8cd229c2 by Simon Peyton Jones at 2022-10-27T10:50:48+01:00
Add isCovertGadtDataCon, fixing build

- - - - -
180150bb by Simon Peyton Jones at 2022-10-27T10:50:48+01:00
Wibbles

- - - - -
fee7c91e by Simon Peyton Jones at 2022-10-27T10:50:48+01:00
Wibbles

- - - - -
fc4412b1 by Simon Peyton Jones at 2022-10-27T10:50:48+01:00
Move RoughMatch code out of Unify into RoughMatch

- - - - -
560bfaaf by Simon Peyton Jones at 2022-10-27T10:50:48+01:00
Wibble

- - - - -
d0670df0 by Simon Peyton Jones at 2022-10-27T10:50:48+01:00
Wibbles

- - - - -
a1e3811e by Simon Peyton Jones at 2022-10-27T10:50:48+01:00
Update haddock submodule again

- - - - -
d4a99c9c by Simon Peyton Jones at 2022-10-27T10:50:48+01:00
Wibbles, esp in RoughMap

- - - - -
b157856e by Simon Peyton Jones at 2022-10-27T10:50:48+01:00
Upate haddock submodule

- - - - -
ec8c6417 by Simon Peyton Jones at 2022-10-27T10:50:48+01:00
Define eqType using tcEqType

A one-line change

- - - - -
19e72fbe by Simon Peyton Jones at 2022-10-27T10:50:48+01:00
Revert "Define eqType using tcEqType"

This reverts commit eaf04c17c6a159ddb70eedd6fb8ab0b4fc180b7a.

Performance got worse!
   T18223 was 60% worse
   T8095      75%
   T12227  9%
   T13386  6%
   T15703  7%
   T5030   8%

- - - - -
4c151c53 by Simon Peyton Jones at 2022-10-27T10:50:49+01:00
Refactor FunTyFlag

Mostly just renaming stuff

- - - - -
12cae4a2 by Simon Peyton Jones at 2022-10-27T10:50:49+01:00
Wibbles

- - - - -


12 changed files:

- compiler/GHC.hs
- compiler/GHC/Builtin/Names.hs
- compiler/GHC/Builtin/Types.hs
- compiler/GHC/Builtin/Types.hs-boot
- compiler/GHC/Builtin/Types/Literals.hs
- compiler/GHC/Builtin/Types/Prim.hs
- − compiler/GHC/Builtin/Types/Prim.hs-boot
- compiler/GHC/Builtin/Uniques.hs
- compiler/GHC/Core/Coercion.hs
- compiler/GHC/Core/Coercion.hs-boot
- compiler/GHC/Core/Coercion/Opt.hs
- compiler/GHC/Core/ConLike.hs


The diff was not included because it is too large.


View it on GitLab: https://gitlab.haskell.org/ghc/ghc/-/compare/42196a762dfe3317c9fe4fc0e8daa7394189eb8b...12cae4a2550e0af63223d53926473670bdb1e080

-- 
View it on GitLab: https://gitlab.haskell.org/ghc/ghc/-/compare/42196a762dfe3317c9fe4fc0e8daa7394189eb8b...12cae4a2550e0af63223d53926473670bdb1e080
You're receiving this email because of your account on gitlab.haskell.org.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.haskell.org/pipermail/ghc-commits/attachments/20221027/f620dfdf/attachment-0001.html>

More information about the ghc-commits mailing list