[Git][ghc/ghc][wip/js-staging] 3 commits: Compactor: remove unused debug code

Sylvain Henry (@hsyl20) gitlab at gitlab.haskell.org
Fri Oct 14 11:47:25 UTC 2022



Sylvain Henry pushed to branch wip/js-staging at Glasgow Haskell Compiler / GHC


Commits:
fce6ce82 by Sylvain Henry at 2022-10-14T12:32:00+02:00
Compactor: remove unused debug code

- - - - -
920e8999 by Sylvain Henry at 2022-10-14T12:32:35+02:00
Compactor: remove unimplemented packStrings

- - - - -
d68c8309 by Sylvain Henry at 2022-10-14T13:45:33+02:00
RTS: fix query/replace error

- - - - -


2 changed files:

- compiler/GHC/StgToJS/Linker/Compactor.hs
- rts/js/environment.js


Changes:

=====================================
compiler/GHC/StgToJS/Linker/Compactor.hs
=====================================
@@ -32,8 +32,6 @@
 
 module GHC.StgToJS.Linker.Compactor
   ( compact
-  , debugShowStat
-  , packStrings
   ) where
 
 
@@ -73,28 +71,6 @@ import Prelude
 import GHC.Utils.Encoding
 
 
-debugShowStat :: (JStat, [ClosureInfo], [StaticInfo]) -> String
-debugShowStat (_s, cis, sis) =
-  "closures:\n" ++
-  unlines (map show cis) ++
-  "\nstatics:" ++
-  unlines (map show sis) ++
-  "\n\n"
-
-{- create a single string initializer for all StaticUnboxedString references
-   in the code, and rewrite all references to point to it
-
-   if incremental linking is used, each increment gets its own packed string
-   blob. if a string value already exists in an earlier blob it is not added
-   again
- -}
-packStrings :: HasDebugCallStack
-            => JSLinkConfig
-            -> CompactorState
-            -> [LinkedUnit]
-            -> (CompactorState, [LinkedUnit])
-packStrings _settings _cstate _code = panic "Compactor.packstrings not yet implemented!"
-
 renameInternals :: HasDebugCallStack
                 => JSLinkConfig
                 -> StgToJSConfig


=====================================
rts/js/environment.js
=====================================
@@ -174,7 +174,7 @@ function h$setProgArgv(n, ptr_d, ptr_o) {
     var arg = h$decodeUtf8z(p[0], p[1]);
     args.push(arg);
   }
-  h$programArgs() = args;
+  h$programArgs_ = args;
 }
 
 function h$getpid() {



View it on GitLab: https://gitlab.haskell.org/ghc/ghc/-/compare/43477793b9d373d28d449892ef14078c128ffd76...d68c8309a7b18781c03bd2941b5c2e3ed1974183

-- 
View it on GitLab: https://gitlab.haskell.org/ghc/ghc/-/compare/43477793b9d373d28d449892ef14078c128ffd76...d68c8309a7b18781c03bd2941b5c2e3ed1974183
You're receiving this email because of your account on gitlab.haskell.org.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.haskell.org/pipermail/ghc-commits/attachments/20221014/e38cc28c/attachment-0001.html>


More information about the ghc-commits mailing list