[Git][ghc/ghc][wip/add_clangd_flag] 3 commits: Convert diagnostics in GHC.Rename.Expr to proper TcRnMessage (#20115)

[Sven Tennie (@supersven)]

Sven Tennie pushed to branch wip/add_clangd_flag at Glasgow Haskell Compiler / GHC


Commits:
86ff1523 by Andrei Borzenkov at 2022-11-24T17:24:51-05:00
Convert diagnostics in GHC.Rename.Expr to proper TcRnMessage (#20115)

Problem: avoid usage of TcRnMessageUnknown

Solution:
The following `TcRnMessage` messages has been introduced:
  TcRnNoRebindableSyntaxRecordDot
  TcRnNoFieldPunsRecordDot
  TcRnIllegalStaticExpression
  TcRnIllegalStaticFormInSplice
  TcRnListComprehensionDuplicateBinding
  TcRnEmptyStmtsGroup
  TcRnLastStmtNotExpr
  TcRnUnexpectedStatementInContext
  TcRnIllegalTupleSection
  TcRnIllegalImplicitParameterBindings
  TcRnSectionWithoutParentheses

Co-authored-by: sheaf <sam.derbyshire at gmail.com>

- - - - -
d198a19a by Cheng Shao at 2022-11-24T17:25:29-05:00
rts: fix missing Arena.h symbols in RtsSymbols.c

It was an unfortunate oversight in !8961 and broke devel2 builds.

- - - - -
dff43862 by Sven Tennie at 2022-11-25T08:53:51+00:00
Add clangd flag to include generated header files

This enables clangd to correctly check C files that import Rts.h.
(The added include directory contains ghcautoconf.h et. al.)

- - - - -


30 changed files:

- compile_flags.txt
- compiler/GHC/Hs/Expr.hs
- compiler/GHC/Rename/Expr.hs
- compiler/GHC/Rename/Expr.hs-boot
- compiler/GHC/Rename/Utils.hs
- compiler/GHC/Tc/Errors/Ppr.hs
- compiler/GHC/Tc/Errors/Types.hs
- compiler/GHC/Types/Error/Codes.hs
- rts/RtsSymbols.c
- testsuite/tests/ghci/prog011/prog011.stderr
- testsuite/tests/parser/should_fail/NondecreasingIndentationFail.stderr
- testsuite/tests/parser/should_fail/RecordDotSyntaxFail12.stderr
- testsuite/tests/parser/should_fail/RecordDotSyntaxFail5.stderr
- testsuite/tests/parser/should_fail/T3811g.stderr
- testsuite/tests/parser/should_fail/readFail028.stderr
- testsuite/tests/parser/should_fail/readFail038.stderr
- testsuite/tests/parser/should_fail/readFail042.stderr
- testsuite/tests/parser/should_fail/readFail043.stderr
- + testsuite/tests/rename/should_fail/RnEmptyStatementGroup1.hs
- + testsuite/tests/rename/should_fail/RnEmptyStatementGroup1.stderr
- + testsuite/tests/rename/should_fail/RnImplicitBindInMdoNotation.hs
- + testsuite/tests/rename/should_fail/RnImplicitBindInMdoNotation.stderr
- testsuite/tests/rename/should_fail/T20147.stderr
- testsuite/tests/rename/should_fail/T2490.stderr
- testsuite/tests/rename/should_fail/T5657.stderr
- testsuite/tests/rename/should_fail/T6060.stderr
- testsuite/tests/rename/should_fail/all.T
- testsuite/tests/rename/should_fail/rnfail056.stderr
- testsuite/tests/th/T14204.stderr
- testsuite/tests/th/TH_StaticPointers02.stderr


The diff was not included because it is too large.


View it on GitLab: https://gitlab.haskell.org/ghc/ghc/-/compare/616abbb87695768329fafc76dcd9235fa633af8d...dff43862b1ca0745f73379e861166dc7d3dcfa0e

-- 
View it on GitLab: https://gitlab.haskell.org/ghc/ghc/-/compare/616abbb87695768329fafc76dcd9235fa633af8d...dff43862b1ca0745f73379e861166dc7d3dcfa0e
You're receiving this email because of your account on gitlab.haskell.org.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.haskell.org/pipermail/ghc-commits/attachments/20221125/6f190fc6/attachment.html>